[WindowsSettings Plugin] Improve subtitle and area naming (#12915)

* Update WindowsSettings clas

* Update TranslationHelper

* Adding ToDos to code

* Adding ToDo notes

* Introduce AreaPathHelper

* Small improvement

* Improve helper class

* Update ResultHelper

* Fix spelling

* adding todo marker

* Improve calling of <WindowsSettingsPathHelper>: Update class <WindowsSetting>

* Improve calling of <WindowsSettingsPathHelper>: Update helper class

* Improve calling of <WindowsSettingsPathHelper>: Implement method call

* TranslationHelper: Small fixes

* Fix scoring for areas property

* Fix search filters for area property

* small fixes

* Update WindowsSettings.json

* adding todos

* Code cleanup, improvements and fixes

* Small changes

* Update resource strings

* Fix msitakes

* Update settings

* resolve review feedback
This commit is contained in:
Heiko
2021-09-06 12:46:14 +02:00
committed by GitHub
parent a4f84844bc
commit dcc4563c8c
9 changed files with 415 additions and 329 deletions

View File

@@ -17,7 +17,6 @@ namespace Microsoft.PowerToys.Run.Plugin.WindowsSettings
public WindowsSetting()
{
Name = string.Empty;
Area = string.Empty;
Command = string.Empty;
Type = string.Empty;
}
@@ -28,9 +27,9 @@ namespace Microsoft.PowerToys.Run.Plugin.WindowsSettings
public string Name { get; set; }
/// <summary>
/// Gets or sets the area of this setting.
/// Gets or sets the areas of this setting. The order is fixed to the order in json.
/// </summary>
public string Area { get; set; }
public IList<string>? Areas { get; set; }
/// <summary>
/// Gets or sets the command of this setting.
@@ -62,5 +61,19 @@ namespace Microsoft.PowerToys.Run.Plugin.WindowsSettings
/// Gets or sets the Windows build since this settings is not longer present.
/// </summary>
public uint? DeprecatedInBuild { get; set; }
/// <summary>
/// Gets or sets the the value with the generated area path as string.
/// This Property IS NOT PART OF THE DATA IN "WindowsSettings.json".
/// This property will be filled on runtime by "WindowsSettingsPathHelper".
/// </summary>
public string? JoinedAreaPath { get; set; }
/// <summary>
/// Gets or sets the the value with the generated full settings path (App and areas) as string.
/// This Property IS NOT PART OF THE DATA IN "WindowsSettings.json".
/// This property will be filled on runtime by "WindowsSettingsPathHelper".
/// </summary>
public string? JoinedFullSettingsPath { get; set; }
}
}