Remove fxcop leftovers (#19772)

* Fixed FxCop leftovers

* Fixed FxCop leftovers
This commit is contained in:
CleanCodeDeveloper
2022-08-09 06:35:46 +02:00
committed by GitHub
parent 1fe9d95322
commit dae63ce3b9
2 changed files with 8 additions and 32 deletions

View File

@@ -643,10 +643,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_zoneHighlightColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_zoneHighlightColor, StringComparison.OrdinalIgnoreCase))
{ {
_zoneHighlightColor = value; _zoneHighlightColor = value;
@@ -665,10 +662,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_zoneBorderColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_zoneBorderColor, StringComparison.OrdinalIgnoreCase))
{ {
_zoneBorderColor = value; _zoneBorderColor = value;
@@ -687,10 +681,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_zoneInActiveColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_zoneInActiveColor, StringComparison.OrdinalIgnoreCase))
{ {
_zoneInActiveColor = value; _zoneInActiveColor = value;
@@ -709,10 +700,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_zoneNumberColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_zoneNumberColor, StringComparison.OrdinalIgnoreCase))
{ {
_zoneNumberColor = value; _zoneNumberColor = value;

View File

@@ -360,10 +360,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_highlighterLeftButtonClickColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_highlighterLeftButtonClickColor, StringComparison.OrdinalIgnoreCase))
{ {
_highlighterLeftButtonClickColor = value; _highlighterLeftButtonClickColor = value;
@@ -382,10 +379,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_highlighterRightButtonClickColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_highlighterRightButtonClickColor, StringComparison.OrdinalIgnoreCase))
{ {
_highlighterRightButtonClickColor = value; _highlighterRightButtonClickColor = value;
@@ -523,10 +517,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_mousePointerCrosshairsColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_mousePointerCrosshairsColor, StringComparison.OrdinalIgnoreCase))
{ {
_mousePointerCrosshairsColor = value; _mousePointerCrosshairsColor = value;
@@ -599,10 +590,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
set set
{ {
// The fallback value is based on ToRGBHex's behavior, which returns value = SettingsUtilities.ToRGBHex(value);
// #FFFFFF if any exceptions are encountered, e.g. from passing in a null value.
// This extra handling is added here to deal with FxCop warnings.
value = (value != null) ? SettingsUtilities.ToRGBHex(value) : "#FFFFFF";
if (!value.Equals(_mousePointerCrosshairsBorderColor, StringComparison.OrdinalIgnoreCase)) if (!value.Equals(_mousePointerCrosshairsBorderColor, StringComparison.OrdinalIgnoreCase))
{ {
_mousePointerCrosshairsBorderColor = value; _mousePointerCrosshairsBorderColor = value;