mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-03 09:46:54 +02:00
[PowerRename] Fix tests inconsistency, improve test performance (#8129)
* Move retrieveing file attibutes to PowerRenameRegex Move file attributes unit tests to PowerRenameRegexTests Add file time field to MockPowerRenameItem * Add file attributes unittests to PowerRenameManagerTests * Change variable name * Rearrange function arguments * Check if file attributes are used only once * Change variable name LocalTime -> fileTime, date -> time * Set fileTime as a member of PowerRenameRegEx rather than passing as an argument * Change function name isFileAttributesUsed() -> isFileTimeUsed() Check before resetting fileTime * Fix small bugs * Fix typos * Refactor for readability, move free calls to reachable places * Fix search for area empty bug searchTerm being empty is not an invalid argument rather it must return OK without any operation Tests must check if Replace() returns S_OK becuase later it checks its result * Check return values of method calls in PowerRenameManager Remove received argments checks from some methods because argument being null or empty string doesnt mean it is invalid or method fails * Fix formatting. Remove overlooked comment. Fix error message. * Change HRESULT declarations according to coding style * Fix unhandled case. Refactor.
This commit is contained in:
committed by
GitHub
parent
4403876320
commit
da22e21a0e
2
.github/actions/spell-check/expect.txt
vendored
2
.github/actions/spell-check/expect.txt
vendored
@@ -2126,6 +2126,7 @@ tif
|
||||
TILEDWINDOW
|
||||
timeinfo
|
||||
Timeline
|
||||
timeunion
|
||||
timeutil
|
||||
titlecase
|
||||
tlb
|
||||
@@ -2191,6 +2192,7 @@ uint
|
||||
UIPI
|
||||
UIs
|
||||
ul
|
||||
ULARGE
|
||||
ULLONG
|
||||
ulong
|
||||
unchecks
|
||||
|
||||
Reference in New Issue
Block a user