Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-04 10:16:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Removing hardcoded version numbers from c# telemetry events. (#5283)

Browse Source 
* Removing hardcoded version numbers from c# telemetry events.

* Removing dependency on powertoysInterop for getting version string.

* Defensive checks around getting assembly version
This commit is contained in:
ryanbodrug-microsoft
2020-07-29 11:18:21 -07:00
committed by GitHub
parent e23b406364
commit d98d1193fc
5 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/modules/launcher/PowerLauncher.Telemetry/Events/LauncherBootEvent.cs
View File

@@ -7,11 +7,6 @@ namespace Microsoft.PowerLauncher.Telemetry
[EventData]
public class LauncherBootEvent : EventBase, IEvent
{
/// <summary>
/// TODO: This should be replaced by a P/Invoke call to get_product_version
/// </summary>
public string Version => "v0.19.3";
public double BootTimeMs { get; set; }
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServicePerformance;

5
src/modules/previewpane/MarkdownPreviewHandler/Telemetry/Events/MarkdownFileHandlerLoaded.cs
View File

@@ -14,11 +14,6 @@ namespace MarkdownPreviewHandler.Telemetry.Events
[EventData]
public class MarkdownFileHandlerLoaded : EventBase, IEvent
{
/// <summary>
/// Gets The version string. TODO: This should be replaced by a P/Invoke call to get_product_version.
/// </summary>
public string Version => "v0.19.3";
/// <inheritdoc/>
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
}

5
src/modules/previewpane/SvgPreviewHandler/Telemetry/Events/SvgFileHandlerLoaded.cs
View File

@@ -14,11 +14,6 @@ namespace SvgPreviewHandler.Telemetry.Events
[EventData]
public class SvgFileHandlerLoaded : EventBase, IEvent
{
/// <summary>
/// Gets The version string. TODO: This should be replaced by a P/Invoke call to get_product_version.
/// </summary>
public string Version => "v0.19.3";
/// <inheritdoc/>
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
}