Fix unremoved resource bug #711

Wox.Core/Resource/Internationalization.cs

@@ -86,9 +86,10 @@ namespace Wox.Core.Resource
 
         public override ResourceDictionary GetResourceDictionary()
         {
+            var uri = GetLanguageFile(DirectoryPath);
             var dictionary = new ResourceDictionary
             {
-                Source = new Uri(GetLanguageFile(DirectoryPath), UriKind.Absolute)
+                Source = new Uri(uri, UriKind.Absolute)
             };
             return dictionary;
         }

Wox.Core/Resource/ResourceMerger.cs

@@ -1,9 +1,11 @@
 using System;
+using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Reflection;
 using System.Windows;
 using Wox.Core.Plugin;
+using Wox.Infrastructure;
 using Wox.Plugin;
 using Wox.Infrastructure.Exception;
 using Wox.Infrastructure.Logger;
@@ -12,18 +14,23 @@ namespace Wox.Core.Resource
 {
     public static class ResourceMerger
     {
+        static ResourceMerger()
+        {
+            // remove all dictionaries defined in xaml e.g.g App.xaml
+            Application.Current.Resources.MergedDictionaries.Clear();
+        }
         private static void RemoveResource(string directoryName)
         {
-            directoryName = $"{Path.DirectorySeparatorChar}{directoryName}";
             var dictionaries = Application.Current.Resources.MergedDictionaries;
-            foreach (var resource in dictionaries)
+            var invalids = dictionaries.Where(dict =>
             {
-                string currentDirectoryName = Path.GetDirectoryName(resource.Source.AbsolutePath);
+                var dir = Path.GetDirectoryName(dict.Source.AbsolutePath).NonNull();
-                if (currentDirectoryName == directoryName)
+                var invalid = dir.Contains(directoryName);
-                {
+                return invalid;
-                    dictionaries.Remove(resource);
+            }).ToList();
-                    break;
+            foreach (var i in invalids)
-                }
+            {
+                dictionaries.Remove(i);
             }
         }
 
@@ -44,13 +51,15 @@ namespace Wox.Core.Resource
                 {
                     var internationalization = InternationalizationManager.Instance;
                     var folder = Path.Combine(directoryName, internationalization.DirectoryName);
+
                     var file = internationalization.GetLanguageFile(folder);
                     if (!string.IsNullOrEmpty(file))
                     {
-                        Application.Current.Resources.MergedDictionaries.Add(new ResourceDictionary
+                        var resource = new ResourceDictionary
                         {
                             Source = new Uri(file, UriKind.Absolute)
-                        });
+                        };
+                        Application.Current.Resources.MergedDictionaries.Add(resource);
                     }
                 }
                 else

Wox.Core/Resource/Theme.cs

@@ -77,9 +77,10 @@ namespace Wox.Core.Resource
 
         public override ResourceDictionary GetResourceDictionary()
         {
+            var uri = GetThemePath(Settings.Theme);
             var dict = new ResourceDictionary
             {
-                Source = new Uri(GetThemePath(Settings.Theme), UriKind.Absolute)
+                Source = new Uri(uri, UriKind.Absolute)
             };
 
             Style queryBoxStyle = dict["QueryBoxStyle"] as Style;

Wox/Themes/Base.xaml

@@ -20,6 +20,7 @@
     </Style>
     <Style x:Key="BaseWindowStyle" TargetType="{x:Type Window}">
         <Setter Property="Width" Value="800" />
+        <Setter Property="MaxWidth" Value="800" />
     </Style>
 
     <Style x:Key="BasePendingLineStyle" TargetType="{x:Type Line}">