last nuget packages and fixed small errors (#5334)

Co-authored-by: Clint Rutkas <crutkas@microsoft.com>
This commit is contained in:
Clint Rutkas
2020-07-30 14:01:02 -07:00
committed by GitHub
parent cfbf3cd4b3
commit d35f1ea802
9 changed files with 22 additions and 32 deletions

View File

@@ -101,7 +101,7 @@ namespace Microsoft.Plugin.Calculator
return new List<Result>();
}
private bool IsBracketComplete(string query)
private static bool IsBracketComplete(string query)
{
var matchs = RegBrackets.Matches(query);
var leftBracketCount = 0;

View File

@@ -98,10 +98,10 @@
<ItemGroup>
<PackageReference Include="JetBrains.Annotations" Version="2020.1.0" />
<PackageReference Include="Mages" Version="1.6.0" >
<PackageReference Include="Mages" Version="1.6.0">
<NoWarn>NU1701</NoWarn>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.6">
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>

View File

@@ -91,7 +91,7 @@ namespace Microsoft.Plugin.Calculator
return outputBuilder.ToString();
}
private Regex GetSplitRegex(CultureInfo culture)
private static Regex GetSplitRegex(CultureInfo culture)
{
var splitPattern = $"((?:\\d|{Regex.Escape(culture.NumberFormat.NumberDecimalSeparator)}";
if (!string.IsNullOrEmpty(culture.NumberFormat.NumberGroupSeparator))

View File

@@ -130,20 +130,6 @@ namespace Microsoft.Plugin.Folder
{
Log.Exception($"|Microsoft.Plugin.Folder.ContextMenu|{message}", e);
}
private bool CanRunAsDifferentUser(string path)
{
switch (Path.GetExtension(path))
{
case ".exe":
case ".bat":
return true;
default:
return false;
}
}
}
public class SearchResult

View File

@@ -132,7 +132,7 @@ namespace Microsoft.Plugin.Folder
}
[System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1308:Normalize strings to uppercase", Justification = "Do not want to change the behavior of the application, but want to enforce static analysis")]
private void InitialDriverList()
private static void InitialDriverList()
{
if (_driverNames == null)
{
@@ -151,7 +151,7 @@ namespace Microsoft.Plugin.Folder
};
[System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1308:Normalize strings to uppercase", Justification = "Do not want to change the behavior of the application, but want to enforce static analysis")]
private List<Result> QueryInternal_Directory_Exists(Query query)
private static List<Result> QueryInternal_Directory_Exists(Query query)
{
var search = query.Search;
var results = new List<Result>();

View File

@@ -95,7 +95,7 @@
<ItemGroup>
<PackageReference Include="JetBrains.Annotations" Version="2020.1.0" />
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.6">
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>