Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-15 19:27:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ImageResizer]Fix silent context menu crash (#22503)

Browse Source
This commit is contained in:
Jaime Bernardo
2022-12-05 23:53:59 +00:00
committed by GitHub
parent ba9e2449f3
commit d300b007f2
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/modules/imageresizer/ImageResizerContextMenu/dllmain.cpp
View File

@@ -79,6 +79,12 @@ public:
IFACEMETHODIMP GetState(_In_opt_ IShellItemArray* selection, _In_ BOOL okToBeSlow, _Out_ EXPCMDSTATE* cmdState) IFACEMETHODIMP GetState(_In_opt_ IShellItemArray* selection, _In_ BOOL okToBeSlow, _Out_ EXPCMDSTATE* cmdState)
{ {
if (nullptr == selection) {
// We've observed that it's possible that a null gets passed instead of an empty array. Just don't show the context menu in this case.
*cmdState = ECS_HIDDEN;
return S_OK;
}
if (!CSettingsInstance().GetEnabled()) if (!CSettingsInstance().GetEnabled())
{ {
*cmdState = ECS_HIDDEN; *cmdState = ECS_HIDDEN;
@@ -90,9 +96,14 @@ public:
#pragma warning(suppress : 26812) #pragma warning(suppress : 26812)
PERCEIVED type; PERCEIVED type;
PERCEIVEDFLAG flag; PERCEIVEDFLAG flag;
IShellItem* shellItem; IShellItem* shellItem=nullptr;
//Check extension of first item in the list (the item which is right-clicked on) //Check extension of first item in the list (the item which is right-clicked on)
selection->GetItemAt(0, &shellItem); HRESULT getItemResult = selection->GetItemAt(0, &shellItem);
if (S_OK != getItemResult || nullptr == shellItem) {
// Some safeguards to avoid runtime errors.
*cmdState = ECS_HIDDEN;
return S_OK;
}
LPTSTR pszPath; LPTSTR pszPath;
// Retrieves the entire file system path of the file from its shell item // Retrieves the entire file system path of the file from its shell item
shellItem->GetDisplayName(SIGDN_FILESYSPATH, &pszPath); shellItem->GetDisplayName(SIGDN_FILESYSPATH, &pszPath);