diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Bookmarks.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Bookmarks.cs index 708c3080c4..98c79b429a 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Bookmarks.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Bookmarks.cs @@ -42,11 +42,4 @@ public sealed class Bookmarks File.WriteAllText(BookmarksCommandProvider.StateJsonPath(), jsonString); } - - public enum BookmarkType - { - File, - Url, - Folder, - } } diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Command/ShellCommand.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Command/ShellCommand.cs index 38f7fa8508..1debd22aac 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Command/ShellCommand.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Command/ShellCommand.cs @@ -37,10 +37,7 @@ public sealed partial class ShellCommand : InvokableCommand BookmarkType = type; BookmarkValue = value; Icon = IconHelper.GetIconByType(type); - Name = name; - - // Icon = new IconInfo(IconFromUrl(Value, type)); } public override CommandResult Invoke() diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Helpers/IconHelper.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Helpers/IconHelper.cs index 18718f7236..e00b8fdcc7 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Helpers/IconHelper.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Bookmark/Helpers/IconHelper.cs @@ -64,12 +64,10 @@ public static class IconHelper return new IconInfo(faviconUrl); } } - catch (UriFormatException) + catch (UriFormatException ex) { - // return "🔗"; + ExtensionHost.LogMessage(new LogMessage() { Message = $"Create Icon failed. {ex}: {ex.Message}" }); } - - return GetIconByType(bookmarkType); } return GetIconByType(bookmarkType);