Assert was switched in these instances, so I changed it to the "expected, actual" (#7142)

Co-authored-by: p-storm <paul.de.man@gmail.com>

src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Programs/UWPTests.cs

@@ -51,7 +51,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             var applications = UWP.All();
 
             // Assert
-            Assert.AreEqual(applications.Length, 2);
+            Assert.AreEqual(2, applications.Length);
             Assert.IsTrue(applications.FindAll(x => x.Name == "DevelopmentApp").Length > 0);
             Assert.IsTrue(applications.FindAll(x => x.Name == "PackagedApp").Length > 0);
         }
@@ -70,7 +70,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             var applications = UWP.All();
 
             // Assert
-            Assert.AreEqual(applications.Length, 1);
+            Assert.AreEqual(1, applications.Length);
             Assert.IsTrue(applications.FindAll(x => x.Name == "PackagedApp").Length > 0);
         }
 
@@ -89,7 +89,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             var applications = UWP.All();
 
             // Assert
-            Assert.AreEqual(applications.Length, 0);
+            Assert.AreEqual(0, applications.Length);
         }
     }
 }

src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Programs/Win32Tests.cs

@@ -256,7 +256,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
 
             // Assert
-            Assert.AreEqual(apps.Length, 1);
+            Assert.AreEqual(1, apps.Length);
         }
 
         [Test]
@@ -273,7 +273,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
 
             // Assert
-            Assert.AreEqual(apps.Length, 1);
+            Assert.AreEqual(1, apps.Length);
         }
 
         [Test]
@@ -289,7 +289,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
 
             // Assert
-            Assert.AreEqual(apps.Length, 1);
+            Assert.AreEqual(1, apps.Length);
         }
 
         [Test]
@@ -306,7 +306,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
 
             // Assert
-            Assert.AreEqual(apps.Length, 1);
+            Assert.AreEqual(1, apps.Length);
             Assert.IsTrue(!string.IsNullOrEmpty(apps[0].LnkResolvedPath));
         }
 
@@ -325,7 +325,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
 
             // Assert
-            Assert.AreEqual(apps.Length, 3);
+            Assert.AreEqual(3, apps.Length);
         }
 
         [Test]
@@ -442,10 +442,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _pinnedWebpage.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 3);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_run_as_administrator);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[2].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(3, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_run_as_administrator, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[1].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[2].Title);
         }
 
         [Test]
@@ -458,9 +458,9 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _dummyInternetShortcutApp.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 2);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(2, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[1].Title);
         }
 
         [Test]
@@ -473,10 +473,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _chrome.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 3);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_run_as_administrator);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[2].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(3, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_run_as_administrator, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[1].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[2].Title);
         }
 
         [Test]
@@ -489,10 +489,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _cmdRunCommand.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 3);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_run_as_administrator);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[2].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(3, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_run_as_administrator, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[1].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[2].Title);
         }
 
         [Test]
@@ -505,10 +505,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _dummyAppRefApp.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 3);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_run_as_administrator);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[2].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(3, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_run_as_administrator, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[1].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[2].Title);
         }
 
         [Test]
@@ -521,10 +521,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _dummyShortcutApp.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 3);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_run_as_administrator);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[2].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(3, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_run_as_administrator, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[1].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[2].Title);
         }
 
         [Test]
@@ -537,9 +537,9 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _dummyFolderApp.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 2);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(2, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[1].Title);
         }
 
         [Test]
@@ -552,9 +552,9 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
             List<ContextMenuResult> contextMenuResults = _dummyGenericFileApp.ContextMenus(mock.Object);
 
             // Assert
-            Assert.AreEqual(contextMenuResults.Count, 2);
-            Assert.AreEqual(contextMenuResults[0].Title, Properties.Resources.wox_plugin_program_open_containing_folder);
-            Assert.AreEqual(contextMenuResults[1].Title, Properties.Resources.wox_plugin_program_open_in_console);
+            Assert.AreEqual(2, contextMenuResults.Count);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_containing_folder, contextMenuResults[0].Title);
+            Assert.AreEqual(Properties.Resources.wox_plugin_program_open_in_console, contextMenuResults[1].Title);
         }
 
         [Test]

src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/ConcurrentQueueEventHandlerTest.cs

@@ -42,8 +42,8 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             string pathFromQueue = EventHandler.GetAppPathFromQueue(eventHandlingQueue, dequeueDelay);
 
             // Assert
-            Assert.AreEqual(pathFromQueue, appPath);
-            Assert.AreEqual(eventHandlingQueue.Count, 0);
+            Assert.AreEqual(appPath, pathFromQueue);
+            Assert.AreEqual(0, eventHandlingQueue.Count);
         }
 
         [TestCase(5)]
@@ -68,8 +68,8 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             string pathFromQueue = EventHandler.GetAppPathFromQueue(eventHandlingQueue, dequeueDelay);
 
             // Assert
-            Assert.AreEqual(pathFromQueue, firstAppPath);
-            Assert.AreEqual(eventHandlingQueue.Count, itemCount);
+            Assert.AreEqual(firstAppPath, pathFromQueue);
+            Assert.AreEqual(itemCount, eventHandlingQueue.Count);
         }
 
         [TestCase(5)]
@@ -99,8 +99,8 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             string pathFromQueue = EventHandler.GetAppPathFromQueue(eventHandlingQueue, dequeueDelay);
 
             // Assert
-            Assert.AreEqual(pathFromQueue, firstAppPath);
-            Assert.AreEqual(eventHandlingQueue.Count, itemCount * 2);
+            Assert.AreEqual(firstAppPath, pathFromQueue);
+            Assert.AreEqual(itemCount * 2, eventHandlingQueue.Count);
         }
     }
 }

src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/Win32ProgramRepositoryTest.cs

@@ -63,13 +63,13 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             // Act
             win32ProgramRepository.Add(item1);
 
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
 
             // To add an item with the same hashCode, ie, same name, exename and fullPath
             win32ProgramRepository.Add(item2);
 
             // Assert, count still remains 1 because they are duplicate items
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
         }
 
         [TestCase("path.appref-ms")]
@@ -83,8 +83,8 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Created += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
-            Assert.AreEqual(win32ProgramRepository.ElementAt(0).AppType, Win32Program.ApplicationType.ApprefApplication);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
+            Assert.AreEqual(Win32Program.ApplicationType.ApprefApplication, win32ProgramRepository.ElementAt(0).AppType);
         }
 
         [TestCase("directory", "path.appref-ms")]
@@ -102,7 +102,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Deleted += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 0);
+            Assert.AreEqual(0, win32ProgramRepository.Count());
         }
 
         [TestCase("directory", "oldpath.appref-ms", "newpath.appref-ms")]
@@ -123,7 +123,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Renamed += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
             Assert.IsTrue(win32ProgramRepository.Contains(newitem));
             Assert.IsFalse(win32ProgramRepository.Contains(olditem));
         }
@@ -144,8 +144,8 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Created += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
-            Assert.AreEqual(win32ProgramRepository.ElementAt(0).AppType, Win32Program.ApplicationType.Win32Application);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
+            Assert.AreEqual(Win32Program.ApplicationType.Win32Application, win32ProgramRepository.ElementAt(0).AppType);
         }
 
         [TestCase("directory", "path.exe")]
@@ -168,7 +168,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Deleted += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 0);
+            Assert.AreEqual(0, win32ProgramRepository.Count());
         }
 
         [TestCase("directory", "oldpath.appref-ms", "newpath.appref-ms")]
@@ -194,7 +194,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Renamed += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
             Assert.IsTrue(win32ProgramRepository.Contains(newitem));
             Assert.IsFalse(win32ProgramRepository.Contains(olditem));
         }
@@ -217,7 +217,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Created += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 0);
+            Assert.AreEqual(0, win32ProgramRepository.Count());
         }
 
         [TestCase("path.exe")]
@@ -245,7 +245,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Changed += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 0);
+            Assert.AreEqual(0, win32ProgramRepository.Count());
         }
 
         [TestCase("directory", "path.url")]
@@ -268,7 +268,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Deleted += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 0);
+            Assert.AreEqual(0, win32ProgramRepository.Count());
         }
 
         [TestCase("directory", "oldpath.url", "newpath.url")]
@@ -294,7 +294,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Renamed += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
             Assert.IsTrue(win32ProgramRepository.Contains(newitem));
             Assert.IsFalse(win32ProgramRepository.Contains(olditem));
         }
@@ -326,7 +326,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Deleted += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 0);
+            Assert.AreEqual(0, win32ProgramRepository.Count());
         }
 
         [TestCase("directory", "oldpath.lnk", "path.lnk")]
@@ -365,7 +365,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
             _fileSystemMocks[0].Raise(m => m.Renamed += null, e);
 
             // Assert
-            Assert.AreEqual(win32ProgramRepository.Count(), 1);
+            Assert.AreEqual(1, win32ProgramRepository.Count());
             Assert.IsTrue(win32ProgramRepository.Contains(newitem));
             Assert.IsFalse(win32ProgramRepository.Contains(olditem));
         }