Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 19:57:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

installer: reduce notification spam

Browse Source
This commit is contained in:
yuyoyuppe
2020-09-08 12:49:55 +03:00
committed by Andrey Nekrasov
parent c2d6f740a1
commit cbd3516fc4
4 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
installer/PowerToysBootstrapper/bootstrapper/bootstrapper.cpp
View File

@@ -297,7 +297,6 @@ int bootstrapper()
sei.fMask = { SEE_MASK_FLAG_NO_UI | SEE_MASK_NOASYNC | SEE_MASK_NO_CONSOLE }; sei.fMask = { SEE_MASK_FLAG_NO_UI | SEE_MASK_NOASYNC | SEE_MASK_NO_CONSOLE };
sei.lpFile = newPTPath->c_str(); sei.lpFile = newPTPath->c_str();
sei.nShow = SW_SHOWNORMAL; sei.nShow = SW_SHOWNORMAL;
sei.lpParameters = UPDATE_REPORT_SUCCESS;
ShellExecuteExW(&sei); ShellExecuteExW(&sei);
} }

6
src/common/updating/toast_notifications_helper.cpp
View File

@@ -25,7 +25,6 @@ namespace localized_strings
const wchar_t GITHUB_NEW_VERSION_UPDATE_NOW[] = L"Update now"; const wchar_t GITHUB_NEW_VERSION_UPDATE_NOW[] = L"Update now";
const wchar_t GITHUB_NEW_VERSION_UPDATE_AFTER_RESTART[] = L"At next launch"; const wchar_t GITHUB_NEW_VERSION_UPDATE_AFTER_RESTART[] = L"At next launch";
const wchar_t UNINSTALLATION_SUCCESS[] = L"Previous version of PowerToys was uninstalled successfully.";
const wchar_t UNINSTALLATION_UNKNOWN_ERROR[] = L"Error: please uninstall the previous version of PowerToys manually."; const wchar_t UNINSTALLATION_UNKNOWN_ERROR[] = L"Error: please uninstall the previous version of PowerToys manually.";
const wchar_t GITHUB_NEW_VERSION_AVAILABLE_OFFER_VISIT[] = L"An update to PowerToys is available. Visit our GitHub page to update.\n"; const wchar_t GITHUB_NEW_VERSION_AVAILABLE_OFFER_VISIT[] = L"An update to PowerToys is available. Visit our GitHub page to update.\n";
@@ -131,11 +130,6 @@ namespace updating
std::move(toast_params)); std::move(toast_params));
} }
void show_uninstallation_success()
{
::notifications::show_toast(localized_strings::UNINSTALLATION_SUCCESS, TOAST_TITLE);
}
void show_uninstallation_error() void show_uninstallation_error()
{ {
::notifications::show_toast(localized_strings::UNINSTALLATION_UNKNOWN_ERROR, TOAST_TITLE); ::notifications::show_toast(localized_strings::UNINSTALLATION_UNKNOWN_ERROR, TOAST_TITLE);

1
src/common/updating/toast_notifications_helper.h
View File

@@ -12,7 +12,6 @@ namespace updating
void show_visit_github(const updating::new_version_download_info& info); void show_visit_github(const updating::new_version_download_info& info);
void show_install_error(const updating::new_version_download_info& info); void show_install_error(const updating::new_version_download_info& info);
void show_version_ready(const updating::new_version_download_info& info); void show_version_ready(const updating::new_version_download_info& info);
void show_uninstallation_success();
void show_uninstallation_error(); void show_uninstallation_error();
void update_download_progress(const updating::new_version_download_info& info, float progress); void update_download_progress(const updating::new_version_download_info& info, float progress);

1
src/common/updating/updating.cpp
View File

@@ -84,7 +84,6 @@ namespace updating
const auto uninstall_result = MsiInstallProductW(package_path.c_str(), L"REMOVE=ALL"); const auto uninstall_result = MsiInstallProductW(package_path.c_str(), L"REMOVE=ALL");
if (ERROR_SUCCESS == uninstall_result) if (ERROR_SUCCESS == uninstall_result)
{ {
notifications::show_uninstallation_success();
return true; return true;
} }
else if (auto system_message = get_last_error_message(uninstall_result); system_message.has_value()) else if (auto system_message = get_last_error_message(uninstall_result); system_message.has_value())