[fxcop] Fixes for Wox.Plugin (1of3) (#7457)

* Added CultureInfo (CA1307: Specify StringComparison for clarity / CA1304: Specify CultureInfo)

* Check arguments and throw ArgumentNullException (CA1062: Validate arguments of public methods)

* Changed url parameter from string to System.Uri and added null checks (CA1054: URI parameters should not be strings)

* Rethrow exception without specifying the exception explicitly (CA2200: Rethrow to preserve stack details)

* Changed from Collection property to methods for PluginMetadata::ActionKeywords (CA2227: Collection properties should be read only)

* Changed from Collection property to methods for Result::GetTitleHighlightData (CA2227: Collection properties should be read only)

* Made Collection property read-only and added parameter in constructor for Result::SubTitleHighlightData (CA2227: Collection properties should be read only)

* Made Collection property read only and added parameter in constructor for ResultUpdatedEventArgs::Results (CA2227: Collection properties should be read only)

* CA1507: Use nameof in place of string

* Removed initialization for ThemeManager::_disposed (CA1805: Do not initialize unnecessarily)

* Changed Query::Terms array property to ReadOnlyCollection and added private set (CA1819: Properties should not return arrays)

* CA1060: Move P/Invokes to NativeMethods class

* CA1806: Do not ignore method results

* CA2101: Specify marshaling for P/Invoke string arguments

* Removed unnecessary empty interface IFeatures (CA1040: Avoid empty interfaces)

- Removed IFeatures interface and references
- Renamed IFeatures.cs to IContextMenu.cs according to guidelines

* Added comments for CultureInfo (CA1307: Specify StringComparison for clarity / CA1304: Specify CultureInfo)

* Added localization for Wox.Plugin and localized strings in FilesFolders.cs

src/modules/launcher/Wox.Plugin/SharedCommands/FilesFolders.cs

@@ -3,9 +3,11 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Globalization;
 using System.IO;
 using System.Reflection;
 using Wox.Plugin.Logger;
+using Wox.Plugin.Properties;
 
 namespace Wox.Plugin.SharedCommands
 {
@@ -56,9 +58,10 @@ namespace Wox.Plugin.SharedCommands
                 string error = $"Copying path {targetPath} has failed";
                 Log.Exception(error, e, MethodBase.GetCurrentMethod().DeclaringType);
 #if DEBUG
-                throw e;
+                throw;
 #else
-                System.Windows.MessageBox.Show(string.Format("Copying path {0} has failed, it will now be deleted for consistency", targetPath));
+                // Using CurrentCulture since this is user facing
+                System.Windows.MessageBox.Show(string.Format(CultureInfo.CurrentCulture, Resources.filesfolder_copy_failed, targetPath));
                 RemoveFolder(targetPath);
 #endif
             }
@@ -91,9 +94,10 @@ namespace Wox.Plugin.SharedCommands
                 string error = $"Unable to verify folders and files between {fromPath} and {toPath}";
                 Log.Exception(error, e, MethodBase.GetCurrentMethod().DeclaringType);
 #if DEBUG
-                throw e;
+                throw;
 #else
-                System.Windows.MessageBox.Show(string.Format(error));
+                // Using CurrentCulture since this is user facing
+                System.Windows.MessageBox.Show(string.Format(CultureInfo.CurrentCulture, Resources.filesfolder_verifybothfolderfilesequal_failed, fromPath, toPath));
                 return false;
 #endif
             }
@@ -113,12 +117,13 @@ namespace Wox.Plugin.SharedCommands
             catch (Exception e)
 #pragma warning restore CS0168 // Variable is declared but never used
             {
-                string error = $"Not able to delete folder {path}, please go to the location and manually delete it";
+                string error = $"Not able to delete folder {path}";
                 Log.Exception(error, e, MethodBase.GetCurrentMethod().DeclaringType);
 #if DEBUG
-                throw e;
+                throw;
 #else
-                System.Windows.MessageBox.Show(string.Format(error));
+                // Using CurrentCulture since this is user facing
+                System.Windows.MessageBox.Show(string.Format(CultureInfo.CurrentCulture, Resources.filesfolder_removefolder_failed, path));
 #endif
             }
         }

src/modules/launcher/Wox.Plugin/SharedCommands/NativeMethods.cs

@@ -0,0 +1,23 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System;
+using System.Runtime.InteropServices;
+using System.Text;
+using static Wox.Plugin.SharedCommands.ShellCommand;
+
+namespace Wox.Plugin.SharedCommands
+{
+    internal static class NativeMethods
+    {
+        [DllImport("user32.dll")]
+        public static extern bool EnumThreadWindows(uint threadId, EnumThreadDelegate lpfn, IntPtr lParam);
+
+        [DllImport("user32.dll", CharSet = CharSet.Unicode)]
+        public static extern int GetWindowText(IntPtr hwnd, StringBuilder lpString, int nMaxCount);
+
+        [DllImport("user32.dll")]
+        public static extern int GetWindowTextLength(IntPtr hwnd);
+    }
+}

src/modules/launcher/Wox.Plugin/SharedCommands/SearchWeb.cs

@@ -15,8 +15,13 @@ namespace Wox.Plugin.SharedCommands
         /// Opens search in a new browser. If no browser path is passed in then Chrome is used.
         /// Leave browser path blank to use Chrome.
         /// </summary>
-        public static void NewBrowserWindow(this string url, string browserPath)
+        public static void NewBrowserWindow(this Uri url, string browserPath)
         {
+            if (url == null)
+            {
+                throw new ArgumentNullException(nameof(url));
+            }
+
             var browserExecutableName = browserPath?
                                         .Split(new[] { Path.DirectorySeparatorChar }, StringSplitOptions.None)
                                         .Last();
@@ -24,7 +29,7 @@ namespace Wox.Plugin.SharedCommands
             var browser = string.IsNullOrEmpty(browserExecutableName) ? "chrome" : browserPath;
 
             // Internet Explorer will open url in new browser window, and does not take the --new-window parameter
-            var browserArguments = browserExecutableName == "iexplore.exe" ? url : "--new-window " + url;
+            var browserArguments = browserExecutableName == "iexplore.exe" ? url.AbsoluteUri : "--new-window " + url.AbsoluteUri;
 
             try
             {
@@ -34,7 +39,7 @@ namespace Wox.Plugin.SharedCommands
             {
                 var psi = new ProcessStartInfo
                 {
-                    FileName = url,
+                    FileName = url.AbsoluteUri,
                     UseShellExecute = true,
                 };
                 Process.Start(psi);
@@ -44,24 +49,29 @@ namespace Wox.Plugin.SharedCommands
         /// <summary>
         /// Opens search as a tab in the default browser chosen in Windows settings.
         /// </summary>
-        public static void NewTabInBrowser(this string url, string browserPath)
+        public static void NewTabInBrowser(this Uri url, string browserPath)
         {
+            if (url == null)
+            {
+                throw new ArgumentNullException(nameof(url));
+            }
+
             try
             {
                 if (!string.IsNullOrEmpty(browserPath))
                 {
-                    Process.Start(browserPath, url);
+                    Process.Start(browserPath, url.AbsoluteUri);
                 }
                 else
                 {
-                    Process.Start(url);
+                    Process.Start(url.AbsoluteUri);
                 }
             }
 
             // This error may be thrown for Process.Start(browserPath, url)
             catch (System.ComponentModel.Win32Exception)
             {
-                Process.Start(url);
+                Process.Start(url.AbsoluteUri);
             }
         }
     }

src/modules/launcher/Wox.Plugin/SharedCommands/ShellCommand.cs

@@ -4,7 +4,6 @@
 
 using System;
 using System.Diagnostics;
-using System.Runtime.InteropServices;
 using System.Text;
 using System.Threading;
 
@@ -14,19 +13,15 @@ namespace Wox.Plugin.SharedCommands
     {
         public delegate bool EnumThreadDelegate(IntPtr hwnd, IntPtr lParam);
 
-        [DllImport("user32.dll")]
-        private static extern bool EnumThreadWindows(uint threadId, EnumThreadDelegate lpfn, IntPtr lParam);
-
-        [DllImport("user32.dll")]
-        private static extern int GetWindowText(IntPtr hwnd, StringBuilder lpString, int nMaxCount);
-
-        [DllImport("user32.dll")]
-        private static extern int GetWindowTextLength(IntPtr hwnd);
-
         private static bool containsSecurityWindow;
 
         public static Process RunAsDifferentUser(ProcessStartInfo processStartInfo)
         {
+            if (processStartInfo == null)
+            {
+                throw new ArgumentNullException(nameof(processStartInfo));
+            }
+
             processStartInfo.Verb = "RunAsUser";
             var process = Process.Start(processStartInfo);
 
@@ -55,7 +50,7 @@ namespace Wox.Plugin.SharedCommands
             ProcessThreadCollection ptc = Process.GetCurrentProcess().Threads;
             for (int i = 0; i < ptc.Count; i++)
             {
-                EnumThreadWindows((uint)ptc[i].Id, CheckSecurityThread, IntPtr.Zero);
+                NativeMethods.EnumThreadWindows((uint)ptc[i].Id, CheckSecurityThread, IntPtr.Zero);
             }
         }
 
@@ -71,8 +66,8 @@ namespace Wox.Plugin.SharedCommands
 
         private static string GetWindowTitle(IntPtr hwnd)
         {
-            StringBuilder sb = new StringBuilder(GetWindowTextLength(hwnd) + 1);
-            GetWindowText(hwnd, sb, sb.Capacity);
+            StringBuilder sb = new StringBuilder(NativeMethods.GetWindowTextLength(hwnd) + 1);
+            _ = NativeMethods.GetWindowText(hwnd, sb, sb.Capacity);
             return sb.ToString();
         }