Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 11:48:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

FxCop enabled (#6758)

Browse Source
This commit is contained in:
Clint Rutkas
2020-09-22 09:14:42 -07:00
committed by GitHub
parent 55b36d44fa
commit c1e9f2de6a
3 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/modules/previewpane/PreviewPaneUnitTests/HTMLParsingExtensionTest.cs
View File

@@ -11,15 +11,16 @@ namespace PreviewPaneUnitTests
[TestClass] [TestClass]
public class HTMLParsingExtensionTest public class HTMLParsingExtensionTest
{ {
private MarkdownPipeline BuidPipeline(IMarkdownExtension extension) private static MarkdownPipeline BuidPipeline(IMarkdownExtension extension)
{ {
MarkdownPipelineBuilder pipelineBuilder = new MarkdownPipelineBuilder().UseAdvancedExtensions(); MarkdownPipelineBuilder pipelineBuilder = new MarkdownPipelineBuilder().UseAdvancedExtensions();
pipelineBuilder.Extensions.Add(extension); pipelineBuilder.Extensions.Add(extension);
return pipelineBuilder.Build(); return pipelineBuilder.Build();
} }
[TestMethod] [TestMethod]
public void Extension_UpdatesTablesClass_WhenUsed() public void ExtensionUpdatesTablesClassWhenUsed()
{ {
// Arrange // Arrange
string mdString = "| A | B |\n| -- | -- | "; string mdString = "| A | B |\n| -- | -- | ";
@@ -34,7 +35,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void Extension_UpdatesBlockQuotesClass_WhenUsed() public void ExtensionUpdatesBlockQuotesClassWhenUsed()
{ {
// Arrange // Arrange
string mdString = "> Blockquotes."; string mdString = "> Blockquotes.";
@@ -49,7 +50,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void Extension_UpdatesFigureClassAndBlocksRelativeUrl_WhenUsed() public void ExtensionUpdatesFigureClassAndBlocksRelativeUrlWhenUsed()
{ {
// arrange // arrange
string mdString = "![text](a.jpg \"Figure\")"; string mdString = "![text](a.jpg \"Figure\")";
@@ -64,7 +65,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void Extension_AddsClassToFigureCaption_WhenUsed() public void ExtensionAddsClassToFigureCaptionWhenUsed()
{ {
// arrange // arrange
string mdString = "^^^ This is a caption"; string mdString = "^^^ This is a caption";
@@ -79,7 +80,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void Extension_RemovesExternalImageUrlAndMakeCallback_WhenUsed() public void ExtensionRemovesExternalImageUrlAndMakeCallbackWhenUsed()
{ {
// arrange // arrange
int count = 0; int count = 0;

12
src/modules/previewpane/PreviewPaneUnitTests/MarkdownPreviewHandlerTest.cs
View File

@@ -14,7 +14,7 @@ namespace PreviewPaneUnitTests
public class MarkdownPreviewHandlerTest public class MarkdownPreviewHandlerTest
{ {
[TestMethod] [TestMethod]
public void MarkdownPreviewHandlerControl__AddsBrowserToForm_WhenDoPreviewIsCalled() public void MarkdownPreviewHandlerControlAddsBrowserToFormWhenDoPreviewIsCalled()
{ {
// Arrange // Arrange
using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl()) using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl())
@@ -29,7 +29,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void MarkdownPreviewHandlerControl__AddsInfoBarToFormIfExternalImageLinkPresent_WhenDoPreviewIsCalled() public void MarkdownPreviewHandlerControlAddsInfoBarToFormIfExternalImageLinkPresentWhenDoPreviewIsCalled()
{ {
// Arrange // Arrange
using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl()) using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl())
@@ -44,7 +44,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void MarkdownPreviewHandlerControl__AddsInfoBarToFormIfHTMLImageTagIsPresent_WhenDoPreviewIsCalled() public void MarkdownPreviewHandlerControlAddsInfoBarToFormIfHTMLImageTagIsPresentWhenDoPreviewIsCalled()
{ {
// Arrange // Arrange
using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl()) using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl())
@@ -59,7 +59,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void MarkdownPreviewHandlerControl__DoesNotAddInfoBarToFormIfExternalImageLinkNotPresent_WhenDoPreviewIsCalled() public void MarkdownPreviewHandlerControlDoesNotAddInfoBarToFormIfExternalImageLinkNotPresentWhenDoPreviewIsCalled()
{ {
// Arrange // Arrange
using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl()) using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl())
@@ -74,7 +74,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void MarkdownPreviewHandlerControl__UpdatesWebBrowserSettings_WhenDoPreviewIsCalled() public void MarkdownPreviewHandlerControlUpdatesWebBrowserSettingsWhenDoPreviewIsCalled()
{ {
// Arrange // Arrange
using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl()) using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl())
@@ -94,7 +94,7 @@ namespace PreviewPaneUnitTests
} }
[TestMethod] [TestMethod]
public void MarkdownPreviewHandlerControl__UpdateInfobarSettings_WhenDoPreviewIsCalled() public void MarkdownPreviewHandlerControlUpdateInfobarSettingsWhenDoPreviewIsCalled()
{ {
// Arrange // Arrange
using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl()) using (var markdownPreviewHandlerControl = new MarkdownPreviewHandlerControl())

5
src/modules/previewpane/PreviewPaneUnitTests/UnitTests-MarkdownPreviewHandler.csproj
View File

@@ -102,6 +102,11 @@
<PackageReference Include="Markdig.Signed"> <PackageReference Include="Markdig.Signed">
<Version>0.21.1</Version> <Version>0.21.1</Version>
</PackageReference> </PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers">
<Version>3.3.0</Version>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="MSTest.TestAdapter"> <PackageReference Include="MSTest.TestAdapter">
<Version>2.1.2</Version> <Version>2.1.2</Version>
</PackageReference> </PackageReference>