mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-05 02:36:19 +02:00
Updates for check-spelling v0.0.25 (#40386)
## Summary of the Pull Request - #39572 updated check-spelling but ignored: > 🐣 Breaking Changes [Code Scanning action requires a Code Scanning Ruleset](https://github.com/check-spelling/check-spelling/wiki/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset) If you use SARIF reporting, then instead of the workflow yielding an ❌ when it fails, it will rely on [github-advanced-security 🤖](https://github.com/apps/github-advanced-security) to report the failure. You will need to adjust your checks for PRs. This means that check-spelling hasn't been properly doing its job 😦. I'm sorry, I should have pushed a thing to this repo earlier,... Anyway, as with most refreshes, this comes with a number of fixes, some are fixes for typos that snuck in before the 0.0.25 upgrade, some are for things that snuck in after, some are based on new rules in spell-check-this, and some are hand written patterns based on running through this repository a few times. About the 🐣 **breaking change**: someone needs to create a ruleset for this repository (see [Code Scanning action requires a Code Scanning Ruleset: Sample ruleset ](https://github.com/check-spelling/check-spelling/wiki/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset#sample-ruleset)). The alternative to adding a ruleset is to change the condition to not use sarif for this repository. In general, I think the github integration from sarif is prettier/more helpful, so I think that it's the better choice. You can see an example of it working in: - https://github.com/check-spelling-sandbox/PowerToys/pull/23 --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Dustin L. Howett <dustin@howett.net>
This commit is contained in:
@@ -384,7 +384,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Method <c>GetSettingsBackupAndRestoreDir</c> returns the path the backup and restore location.
|
||||
/// Method <c>GetSettingsBackupAndRestoreDir</c> returns the path of the backup and restore location.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// This will return a default location based on user documents if non is set.
|
||||
@@ -959,7 +959,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
|
||||
|
||||
if (item.Value.Contains("PowerToys_settings_", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
// this is a temp backup and we want to clean based on the time it was created in the temp place, not the time the backup was made.
|
||||
// this is a temp backup and we want to clean based on the time it was created in the temp place, not the time that the backup was made.
|
||||
var folderCreatedTime = new DirectoryInfo(item.Value).CreationTimeUtc;
|
||||
|
||||
if (folderCreatedTime > backupTime)
|
||||
|
||||
Reference in New Issue
Block a user