mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-06 03:07:04 +02:00
Updates for check-spelling v0.0.25 (#40386)
## Summary of the Pull Request - #39572 updated check-spelling but ignored: > 🐣 Breaking Changes [Code Scanning action requires a Code Scanning Ruleset](https://github.com/check-spelling/check-spelling/wiki/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset) If you use SARIF reporting, then instead of the workflow yielding an ❌ when it fails, it will rely on [github-advanced-security 🤖](https://github.com/apps/github-advanced-security) to report the failure. You will need to adjust your checks for PRs. This means that check-spelling hasn't been properly doing its job 😦. I'm sorry, I should have pushed a thing to this repo earlier,... Anyway, as with most refreshes, this comes with a number of fixes, some are fixes for typos that snuck in before the 0.0.25 upgrade, some are for things that snuck in after, some are based on new rules in spell-check-this, and some are hand written patterns based on running through this repository a few times. About the 🐣 **breaking change**: someone needs to create a ruleset for this repository (see [Code Scanning action requires a Code Scanning Ruleset: Sample ruleset ](https://github.com/check-spelling/check-spelling/wiki/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset#sample-ruleset)). The alternative to adding a ruleset is to change the condition to not use sarif for this repository. In general, I think the github integration from sarif is prettier/more helpful, so I think that it's the better choice. You can see an example of it working in: - https://github.com/check-spelling-sandbox/PowerToys/pull/23 --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Dustin L. Howett <dustin@howett.net>
This commit is contained in:
@@ -58,7 +58,7 @@ namespace Common.Utilities
|
||||
{
|
||||
foundBlockedElement = true;
|
||||
|
||||
// No need to iterate further since we are displaying info bar with condition of atleast one occurrence of blocked element is present.
|
||||
// No need to iterate further since we are displaying info bar with condition of at least one occurrence of blocked element is present.
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -23,7 +23,7 @@ namespace Common.ComInterlop
|
||||
void GetWindowContext(IntPtr pinfo);
|
||||
|
||||
/// <summary>
|
||||
/// Directs the host to handle an keyboard shortcut passed from the preview handler.
|
||||
/// Directs the host to handle a keyboard shortcut passed from the preview handler.
|
||||
/// </summary>
|
||||
/// <param name="pmsg">A reference to <see cref="MSG"/> that corresponds to a keyboard shortcut.</param>
|
||||
/// <returns>If the keyboard shortcut is one that the host intends to handle, the host will process it and return S_OK(0); otherwise, it returns S_FALSE(1).</returns>
|
||||
|
||||
@@ -17,7 +17,7 @@ namespace Common
|
||||
public abstract class FormHandlerControl : Form, IPreviewHandlerControl
|
||||
{
|
||||
/// <summary>
|
||||
/// Needed to make the form a child window.
|
||||
/// Needed to make the form into a child window.
|
||||
/// </summary>
|
||||
private static int gwlStyle = -16;
|
||||
private static int wsChild = 0x40000000;
|
||||
|
||||
Reference in New Issue
Block a user