Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-10 05:06:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

[Settings]Better logging when upgrading settings from a old format (#22497)

Browse Source 
* SettingUtils fixing error reporting when reading settings in old format

* Making the error message even more informative
This commit is contained in:
Laszlo Nemeth
2022-12-05 19:52:43 +01:00
committed by GitHub
parent 42c77d7d42
commit ba9e2449f3
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/settings-ui/Settings.UI.Library/SettingsUtils.cs
View File

@@ -115,18 +115,20 @@ namespace Microsoft.PowerToys.Settings.UI.Library
// This is different from the case where we have trailing zeros following a valid json file, which we have handled by trimming the trailing zeros. // This is different from the case where we have trailing zeros following a valid json file, which we have handled by trimming the trailing zeros.
catch (JsonException ex) catch (JsonException ex)
{ {
Logger.LogError($"Exception encountered while loading {powertoy} settings.", ex); Logger.LogInfo($"Settings file {fileName} for {powertoy} was unrecognized. Possibly containing an older version. Trying to read again.");
// try to deserialize to the old format, which is presented in T2 // try to deserialize to the old format, which is presented in T2
try try
{ {
T2 oldSettings = GetSettings<T2>(powertoy, fileName); T2 oldSettings = GetSettings<T2>(powertoy, fileName);
T newSettings = (T)settingsUpgrader(oldSettings); T newSettings = (T)settingsUpgrader(oldSettings);
Logger.LogInfo($"Settings file {fileName} for {powertoy} was read successfully in the old format.");
return newSettings; return newSettings;
} }
catch (Exception) catch (Exception)
{ {
// do nothing, the problem wasn't that the settings was stored in the previous format, continue with the default settings // do nothing, the problem wasn't that the settings was stored in the previous format, continue with the default settings
Logger.LogError($"{powertoy} settings are corrupt or the format is not supported any longer. Using default settings instead.", ex);
} }
} }
catch (FileNotFoundException) catch (FileNotFoundException)