Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-15 11:17:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Installer]Don't enable pdf preview by default (#17274)

Browse Source 
* [Installer]Don't enable pdf preview by default

* Change settings UI when there's no settings as well

* clear analyzer errors
This commit is contained in:
Jaime Bernardo
2022-03-25 21:01:09 +00:00
committed by GitHub
parent bdbf0b8c14
commit ba73bc7d50
3 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
installer/PowerToysSetupCustomActions/CustomAction.cpp
View File

@@ -75,7 +75,7 @@ UINT __stdcall ApplyModulesRegistryChangeSetsCA(MSIHANDLE hInstall)
hr = getInstallFolder(hInstall, installationFolder); hr = getInstallFolder(hInstall, installationFolder);
ExitOnFailure(hr, "Failed to get installFolder."); ExitOnFailure(hr, "Failed to get installFolder.");
for (const auto& changeSet : getAllModulesChangeSets(installationFolder)) for (const auto& changeSet : getAllOnByDefaultModulesChangeSets(installationFolder))
{ {
if (!changeSet.apply()) if (!changeSet.apply())
{ {

12
src/common/utils/modulesRegistry.h
View File

@@ -201,6 +201,18 @@ inline registry::ChangeSet getStlThumbnailHandlerChangeSet(const std::wstring in
NonLocalizable::ExtSTL); NonLocalizable::ExtSTL);
} }
inline std::vector<registry::ChangeSet> getAllOnByDefaultModulesChangeSets(const std::wstring installationDir)
{
constexpr bool PER_USER = true;
return { getSvgPreviewHandlerChangeSet(installationDir, PER_USER),
getMdPreviewHandlerChangeSet(installationDir, PER_USER),
getMonacoPreviewHandlerChangeSet(installationDir, PER_USER),
getGcodePreviewHandlerChangeSet(installationDir, PER_USER),
getSvgThumbnailHandlerChangeSet(installationDir, PER_USER),
getGcodeThumbnailHandlerChangeSet(installationDir, PER_USER),
getStlThumbnailHandlerChangeSet(installationDir, PER_USER) };
}
inline std::vector<registry::ChangeSet> getAllModulesChangeSets(const std::wstring installationDir) inline std::vector<registry::ChangeSet> getAllModulesChangeSets(const std::wstring installationDir)
{ {
constexpr bool PER_USER = true; constexpr bool PER_USER = true;

4
src/settings-ui/Settings.UI.Library/PowerPreviewProperties.cs
View File

@@ -97,7 +97,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
} }
} }
private bool enablePdfPreview = true; private bool enablePdfPreview;
[JsonPropertyName("pdf-previewer-toggle-setting")] [JsonPropertyName("pdf-previewer-toggle-setting")]
[JsonConverter(typeof(BoolPropertyJsonConverter))] [JsonConverter(typeof(BoolPropertyJsonConverter))]
@@ -114,7 +114,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
} }
} }
private bool enablePdfThumbnail = true; private bool enablePdfThumbnail;
[JsonPropertyName("pdf-thumbnail-toggle-setting")] [JsonPropertyName("pdf-thumbnail-toggle-setting")]
[JsonConverter(typeof(BoolPropertyJsonConverter))] [JsonConverter(typeof(BoolPropertyJsonConverter))]