From b68b84532c43ab1e7065b02f29d65df93097cf01 Mon Sep 17 00:00:00 2001 From: leileizhang Date: Tue, 13 Jan 2026 12:36:23 +0800 Subject: [PATCH] Fix ESRP Code Signing Node 16 EOL is blocking app signing (#44695) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary of the Pull Request We’re hitting an issue where ESRP Code Signing (EsrpCodeSigning@5) is now blocking our app from being signed. The pipeline reports a Node 16 EOL dependency, and at this point the app can no longer be signed successfully. Fix Upgrade the version to 6 ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- .pipelines/v2/templates/steps-esrp-signing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pipelines/v2/templates/steps-esrp-signing.yml b/.pipelines/v2/templates/steps-esrp-signing.yml index 5f76f077e2..bff0bce0f1 100644 --- a/.pipelines/v2/templates/steps-esrp-signing.yml +++ b/.pipelines/v2/templates/steps-esrp-signing.yml @@ -10,7 +10,7 @@ parameters: default: {} steps: - - task: EsrpCodeSigning@5 + - task: EsrpCodeSigning@6 displayName: 🔏 ${{ parameters.displayName }} inputs: ConnectedServiceName: ${{ parameters.signingIdentity.serviceName }}