[Analyzers][CPP]Turn on Warning 4239 (#21588)

* Turn on warning 4239

* changes from comments
fix a 4100 that wasnt showing up before
This commit is contained in:
sosssego
2022-11-15 12:33:31 +00:00
committed by GitHub
parent 59fd84c5ec
commit b482188782
2 changed files with 6 additions and 7 deletions

View File

@@ -305,12 +305,11 @@ void AppZoneHistory::AdjustWorkAreaIds(const std::vector<FancyZonesDataTypes::Mo
{
bool dirtyFlag = false;
for (auto iter = m_history.begin(); iter != m_history.end(); ++iter)
for (auto& [app, data] : m_history)
{
auto& [app, data] = *iter;
for (auto& dataIter = data.begin(); dataIter != data.end(); ++dataIter)
for (auto& dataIter : data)
{
auto& dataMonitorId = dataIter->workAreaId.monitorId;
auto& dataMonitorId = dataIter.workAreaId.monitorId;
bool serialNumberNotSet = dataMonitorId.serialNumber.empty() && !dataMonitorId.deviceId.isDefault();
bool monitorNumberNotSet = dataMonitorId.deviceId.number == 0;
if (serialNumberNotSet || monitorNumberNotSet)