Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 10:46:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

🚧 [Dev][Build] .NET 8 Upgrade (#28655)

Browse Source 
* Upgraded projects to target .NET 8

* Updated .NET runtime package targets to use latest .NET 8 build

* Updated PowerToys Interop to target .NET 8

* Switch to use ArgumentNullException.ThrowIfNull

* ArgumentNullException.ThrowIfNull for CropAndLockViewModel

* Switching to ObjectDisposedException.ThrowIf

* Upgrade System.ComponentModel.Composition to 8.0

* ArgumentNullException.ThrowIfNull in Helper

* Switch to StartsWith using StringComparison.Ordinal

* Disabled CA1859, CA1716, SYSLIB1096 analyzers

* Update RIDs to reflect breaking changes in .NET 8

* Updated Microsoft NuGet packages to RC1

* Updated Analyzer package to latest .NET 8 preview package

* CA1854: Use TryGetValue instead of ContainsKey

* [Build] Update TFM to .NET 8 for publish profiles

* [Analyzers] Remove CA1309, CA1860-CA1865, CA1869, CA2208 from warning.

* [Analyzers] Fix for C26495

* [Analyzers] Disable CS1615, CS9191

* [CI] Target .NET 8 in YAML

* [CI] Add .NET preview version flag temporarily.

* [FileLocksmith] Update TFM to .NET 8

* [CI] Switch to preview agent

* [CI] Update NOTICE.md

* [CI] Update Release to target .NET 8 and use Preview agent

* [Analyzers] Disable CA1854

* Fix typo

* Updated Microsoft.CodeAnalysis.NetAnalyzers to latest preview

Updated packages to rc2

* [Analyzers][CPP] Turn off warning for 5271

* [Analyzers][CPP] Turn off warning for 26493

* [KeyboardListener] Add mutex include to resolve error

* [PT Run][Folder] Use static SearchValues to resolve CA1870

* [PowerLauncher] Fix TryGetValue

* [MouseJumpSettings] Use ArgumentNullException.ThrowIfNull

* [Build] Disable parallel dotnet tool restore

* [Build] No cache of dotnet tool packages

* [Build] Temporarily move .NET 8 SDK task before XAML formatting

* [Build][Temp] Try using .NET 7 prior to XAML formatting and then switch to .NET 8 after

* [Build] Use .NET 6 for XAML Styler

* [CI] Updated NOTICE.md

* [FancyZones] Update TFM to .NET 8

* [EnvVar] Update TFM to .NET 8 and update RID

* [EnvVar] Use ArgumentNullException.ThrowIfNull

* [Dev] Updated packages to .NET 8 RTM version

* [Dev] Updated Microsoft.CodeAnalysis.NetAnalyzers to latest

* [CI] Updated NOTICE.md with latest package versions

* Fix new utility target fameworks and runtimeids

* Don't use preview images anymore

* [CI] Add script to update VCToolsVersion environment variable

* [CI] Add Step to Verify VCToolsVersion

* [CI] Use latest flag for vswhere to set proper VCToolsVersion

* Add VCToolsVersion checking to release.yml

* Remove net publishing from local/ PR CI builds

* Revert "Remove net publishing from local/ PR CI builds"

This reverts commit f469778996.

* Only publish necessary projects

* Add verbosity to release pipelines builds of PowerTOys

* Set VCToolsVersion for publish.cmd when called from installer

* [Installer] Moved project publish logic to MSBuild Task

* [CI] Revert using publish.cmd

* [CI] Set VCToolsVersion and unset ClearDevCommandPromptEnvVars property

* Installer publishes for x64 too

* Revert "Add verbosity to release pipelines builds of PowerTOys"

This reverts commit 654d4a7f78.

* [Dev] Update CodeAnalysis library to non-preview package

* Remove unneeded warning removal

* Fix Notice.md

* Rename VCToolsVersion file and task name

* Remove unneeded mutex header include

---------

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
This commit is contained in:
Jeremy Sinclair
2023-11-22 12:46:59 -05:00
committed by GitHub
parent b41129d489
commit b2b2856e52
206 changed files with 473 additions and 841 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/settings-ui/Settings.UI.Library/AppSpecificKeysDataModel.cs
View File

@@ -25,10 +25,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
public bool Compare(AppSpecificKeysDataModel arg)
{
if (arg == null)
{
throw new ArgumentNullException(nameof(arg));
}
ArgumentNullException.ThrowIfNull(arg);
// Using Ordinal comparison for internal text
return OriginalKeys.Equals(arg.OriginalKeys, StringComparison.Ordinal) &&

5
src/settings-ui/Settings.UI.Library/ColorPickerSettings.cs
View File

@@ -34,10 +34,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/ColorPickerSettingsVersion1.cs
View File

@@ -31,10 +31,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/EnvironmentVariablesSettings.cs
View File

@@ -31,10 +31,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/FileLocksmithSettings.cs
View File

@@ -25,10 +25,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
public FileLocksmithSettings(FileLocksmithLocalProperties localProperties)
{
if (localProperties == null)
{
throw new ArgumentNullException(nameof(localProperties));
}
ArgumentNullException.ThrowIfNull(localProperties);
Properties = new FileLocksmithProperties();
Properties.ExtendedContextMenuOnly.Value = localProperties.ExtendedContextMenuOnly;

5
src/settings-ui/Settings.UI.Library/HostsSettings.cs
View File

@@ -31,10 +31,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/ImageSize.cs
View File

@@ -225,10 +225,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
public void Update(ImageSize modifiedSize)
{
if (modifiedSize == null)
{
throw new ArgumentNullException(nameof(modifiedSize));
}
ArgumentNullException.ThrowIfNull(modifiedSize);
Id = modifiedSize.Id;
Name = modifiedSize.Name;

5
src/settings-ui/Settings.UI.Library/MouseJumpSettings.cs
View File

@@ -31,10 +31,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/MouseWithoutBordersSettings.cs
View File

@@ -98,10 +98,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
IncludeFields = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/PastePlainSettings.cs
View File

@@ -31,10 +31,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/PeekSettings.cs
View File

@@ -42,10 +42,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/PowerLauncherSettings.cs
View File

@@ -36,10 +36,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/PowerOcrSettings.cs
View File

@@ -31,10 +31,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
WriteIndented = true,
};
if (settingsUtils == null)
{
throw new ArgumentNullException(nameof(settingsUtils));
}
ArgumentNullException.ThrowIfNull(settingsUtils);
settingsUtils.SaveSettings(JsonSerializer.Serialize(this, options), ModuleName);
}

5
src/settings-ui/Settings.UI.Library/PowerRenameSettings.cs
View File

@@ -24,10 +24,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
public PowerRenameSettings(PowerRenameLocalProperties localProperties)
{
if (localProperties == null)
{
throw new ArgumentNullException(nameof(localProperties));
}
ArgumentNullException.ThrowIfNull(localProperties);
Properties = new PowerRenameProperties();
Properties.PersistState.Value = localProperties.PersistState;

6
src/settings-ui/Settings.UI.Library/Settings.UI.Library.csproj
View File

@@ -3,7 +3,7 @@
<Import Project="..\..\Version.props" />
<PropertyGroup>
<TargetFramework>net7.0-windows</TargetFramework>
<TargetFramework>net8.0-windows</TargetFramework>
<Version>$(Version).0</Version>
<Authors>Microsoft Corporation</Authors>
<Product>PowerToys</Product>
@@ -14,10 +14,10 @@
<!-- SelfContained=true requires RuntimeIdentifier to be set -->
<PropertyGroup Condition="'$(Platform)'=='x64'">
<RuntimeIdentifier>win10-x64</RuntimeIdentifier>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
</PropertyGroup>
<PropertyGroup Condition="'$(Platform)'=='ARM64'">
<RuntimeIdentifier>win10-arm64</RuntimeIdentifier>
<RuntimeIdentifier>win-arm64</RuntimeIdentifier>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)'=='Debug'">

10
src/settings-ui/Settings.UI.Library/SettingsBackupAndRestoreUtils.cs
View File

@@ -858,10 +858,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
/// </summary>
private static JsonArray GetPTRunIgnoredSettings(JsonNode backupRestoreSettings)
{
if (backupRestoreSettings == null)
{
throw new ArgumentNullException(nameof(backupRestoreSettings));
}
ArgumentNullException.ThrowIfNull(backupRestoreSettings);
if (backupRestoreSettings["IgnoredPTRunSettings"] != null)
{
@@ -876,10 +873,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
/// </summary>
private static string[] GetIgnoredSettings(JsonNode backupRestoreSettings, string settingFileKey)
{
if (backupRestoreSettings == null)
{
throw new ArgumentNullException(nameof(backupRestoreSettings));
}
ArgumentNullException.ThrowIfNull(backupRestoreSettings);
if (settingFileKey.StartsWith("\\", StringComparison.OrdinalIgnoreCase))
{

10
src/settings-ui/Settings.UI.Library/Utilities/Helper.cs
View File

@@ -114,14 +114,8 @@ namespace Microsoft.PowerToys.Settings.UI.Library.Utilities
{
// Split up the version strings into int[]
// Example: v10.0.2 -> {10, 0, 2};
if (version1 == null)
{
throw new ArgumentNullException(nameof(version1));
}
else if (version2 == null)
{
throw new ArgumentNullException(nameof(version2));
}
ArgumentNullException.ThrowIfNull(version1);
ArgumentNullException.ThrowIfNull(version2);
var v1 = version1.Substring(1).Split('.').Select(int.Parse).ToArray();
var v2 = version2.Substring(1).Split('.').Select(int.Parse).ToArray();