mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-05 02:36:19 +02:00
🚧 [Dev][Build] .NET 8 Upgrade (#28655)
* Upgraded projects to target .NET 8 * Updated .NET runtime package targets to use latest .NET 8 build * Updated PowerToys Interop to target .NET 8 * Switch to use ArgumentNullException.ThrowIfNull * ArgumentNullException.ThrowIfNull for CropAndLockViewModel * Switching to ObjectDisposedException.ThrowIf * Upgrade System.ComponentModel.Composition to 8.0 * ArgumentNullException.ThrowIfNull in Helper * Switch to StartsWith using StringComparison.Ordinal * Disabled CA1859, CA1716, SYSLIB1096 analyzers * Update RIDs to reflect breaking changes in .NET 8 * Updated Microsoft NuGet packages to RC1 * Updated Analyzer package to latest .NET 8 preview package * CA1854: Use TryGetValue instead of ContainsKey * [Build] Update TFM to .NET 8 for publish profiles * [Analyzers] Remove CA1309, CA1860-CA1865, CA1869, CA2208 from warning. * [Analyzers] Fix for C26495 * [Analyzers] Disable CS1615, CS9191 * [CI] Target .NET 8 in YAML * [CI] Add .NET preview version flag temporarily. * [FileLocksmith] Update TFM to .NET 8 * [CI] Switch to preview agent * [CI] Update NOTICE.md * [CI] Update Release to target .NET 8 and use Preview agent * [Analyzers] Disable CA1854 * Fix typo * Updated Microsoft.CodeAnalysis.NetAnalyzers to latest preview Updated packages to rc2 * [Analyzers][CPP] Turn off warning for 5271 * [Analyzers][CPP] Turn off warning for 26493 * [KeyboardListener] Add mutex include to resolve error * [PT Run][Folder] Use static SearchValues to resolve CA1870 * [PowerLauncher] Fix TryGetValue * [MouseJumpSettings] Use ArgumentNullException.ThrowIfNull * [Build] Disable parallel dotnet tool restore * [Build] No cache of dotnet tool packages * [Build] Temporarily move .NET 8 SDK task before XAML formatting * [Build][Temp] Try using .NET 7 prior to XAML formatting and then switch to .NET 8 after * [Build] Use .NET 6 for XAML Styler * [CI] Updated NOTICE.md * [FancyZones] Update TFM to .NET 8 * [EnvVar] Update TFM to .NET 8 and update RID * [EnvVar] Use ArgumentNullException.ThrowIfNull * [Dev] Updated packages to .NET 8 RTM version * [Dev] Updated Microsoft.CodeAnalysis.NetAnalyzers to latest * [CI] Updated NOTICE.md with latest package versions * Fix new utility target fameworks and runtimeids * Don't use preview images anymore * [CI] Add script to update VCToolsVersion environment variable * [CI] Add Step to Verify VCToolsVersion * [CI] Use latest flag for vswhere to set proper VCToolsVersion * Add VCToolsVersion checking to release.yml * Remove net publishing from local/ PR CI builds * Revert "Remove net publishing from local/ PR CI builds" This reverts commitf469778996. * Only publish necessary projects * Add verbosity to release pipelines builds of PowerTOys * Set VCToolsVersion for publish.cmd when called from installer * [Installer] Moved project publish logic to MSBuild Task * [CI] Revert using publish.cmd * [CI] Set VCToolsVersion and unset ClearDevCommandPromptEnvVars property * Installer publishes for x64 too * Revert "Add verbosity to release pipelines builds of PowerTOys" This reverts commit654d4a7f78. * [Dev] Update CodeAnalysis library to non-preview package * Remove unneeded warning removal * Fix Notice.md * Rename VCToolsVersion file and task name * Remove unneeded mutex header include --------- Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
This commit is contained in:
@@ -157,10 +157,7 @@ namespace Microsoft.Plugin.Program
|
||||
|
||||
public List<ContextMenuResult> LoadContextMenus(Result selectedResult)
|
||||
{
|
||||
if (selectedResult == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(selectedResult));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(selectedResult);
|
||||
|
||||
var menuOptions = new List<ContextMenuResult>();
|
||||
if (selectedResult.ContextData is IProgram program)
|
||||
@@ -175,15 +172,9 @@ namespace Microsoft.Plugin.Program
|
||||
{
|
||||
try
|
||||
{
|
||||
if (runProcess == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(runProcess));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(runProcess);
|
||||
|
||||
if (info == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(info));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(info);
|
||||
|
||||
runProcess(info);
|
||||
}
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
<Import Project="..\..\..\..\Version.props" />
|
||||
|
||||
<PropertyGroup>
|
||||
<TargetFramework>net7.0-windows10.0.20348.0</TargetFramework>
|
||||
<TargetFramework>net8.0-windows10.0.20348.0</TargetFramework>
|
||||
<TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
|
||||
<SupportedOSPlatformVersion>10.0.19041.0</SupportedOSPlatformVersion>
|
||||
<ProjectGuid>{FDB3555B-58EF-4AE6-B5F1-904719637AB4}</ProjectGuid>
|
||||
|
||||
@@ -44,10 +44,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public static PackageWrapper GetWrapperFromPackage(Package package)
|
||||
{
|
||||
if (package == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(package));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(package);
|
||||
|
||||
string path;
|
||||
try
|
||||
|
||||
@@ -47,10 +47,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public UWP(IPackage package)
|
||||
{
|
||||
if (package == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(package));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(package);
|
||||
|
||||
Name = package.Name;
|
||||
FullName = package.FullName;
|
||||
|
||||
@@ -91,10 +91,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public Result Result(string query, string queryArguments, IPublicAPI api)
|
||||
{
|
||||
if (api == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(api));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(api);
|
||||
|
||||
var score = Score(query);
|
||||
if (score <= 0)
|
||||
@@ -130,10 +127,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public List<ContextMenuResult> ContextMenus(string queryArguments, IPublicAPI api)
|
||||
{
|
||||
if (api == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(api));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(api);
|
||||
|
||||
var contextMenus = new List<ContextMenuResult>();
|
||||
|
||||
@@ -229,10 +223,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public UWPApplication(IAppxManifestApplication manifestApp, UWP package)
|
||||
{
|
||||
if (manifestApp == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(manifestApp));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(manifestApp);
|
||||
|
||||
var hr = manifestApp.GetAppUserModelId(out var tmpUserModelId);
|
||||
UserModelId = AppxPackageHelper.CheckHRAndReturnOrThrow(hr, tmpUserModelId);
|
||||
|
||||
@@ -205,10 +205,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public Result Result(string query, string queryArguments, IPublicAPI api)
|
||||
{
|
||||
if (api == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(api));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(api);
|
||||
|
||||
var score = Score(query);
|
||||
if (score <= 0)
|
||||
@@ -274,10 +271,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public List<ContextMenuResult> ContextMenus(string queryArguments, IPublicAPI api)
|
||||
{
|
||||
if (api == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(api));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(api);
|
||||
|
||||
var contextMenus = new List<ContextMenuResult>();
|
||||
|
||||
@@ -605,10 +599,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
// Function to get the application type, given the path to the application
|
||||
public static ApplicationType GetAppTypeFromPath(string path)
|
||||
{
|
||||
if (path == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(path));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(path);
|
||||
|
||||
string extension = Extension(path);
|
||||
|
||||
@@ -640,10 +631,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
// Function to get the Win32 application, given the path to the application
|
||||
public static Win32Program GetAppFromPath(string path)
|
||||
{
|
||||
if (path == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(path));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(path);
|
||||
|
||||
Win32Program app;
|
||||
switch (GetAppTypeFromPath(path))
|
||||
@@ -985,10 +973,7 @@ namespace Microsoft.Plugin.Program.Programs
|
||||
|
||||
public static IList<Win32Program> All(ProgramPluginSettings settings)
|
||||
{
|
||||
if (settings == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(settings));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(settings);
|
||||
|
||||
try
|
||||
{
|
||||
|
||||
@@ -14,10 +14,7 @@ namespace Microsoft.Plugin.Program.Storage
|
||||
// On the first occurrence of a different file path, the existing app path is to be returned without removing any more elements from the queue.
|
||||
public static async Task<string> GetAppPathFromQueueAsync(ConcurrentQueue<string> eventHandlingQueue, int dequeueDelay)
|
||||
{
|
||||
if (eventHandlingQueue == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(eventHandlingQueue));
|
||||
}
|
||||
ArgumentNullException.ThrowIfNull(eventHandlingQueue);
|
||||
|
||||
string previousAppPath = string.Empty;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user