[Analyzers][CPP]Turn on warning 26466 (#22639)

* Turn on warning 26466

* changes from comments

CppRuleSet.ruleset

@@ -63,7 +63,7 @@
     <Rule Id="C26463" Action="Error" />
     <Rule Id="C26464" Action="Error" />
     <Rule Id="C26465" Action="Info" />
-    <Rule Id="C26466" Action="Info" />
+    <Rule Id="C26466" Action="Error" />
     <Rule Id="C26471" Action="Info" />
     <Rule Id="C26472" Action="Info" />
     <Rule Id="C26473" Action="Info" />

src/common/UnitTests-CommonLib/pch.h

@@ -12,6 +12,11 @@
 #include <winrt/base.h>
 #include <winrt/Windows.Foundation.h>
 #include <winrt/Windows.Foundation.Collections.h>
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
 
 #endif //PCH_H

src/modules/MeasureTool/MeasureToolCore/DxgiAPI.h

@@ -4,7 +4,13 @@
 #include <dcomp.h>
 #include <dxgi1_3.h>
 #include <inspectable.h>
+
+// Suppressing 26466 - Don't use static_cast downcasts - in base.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include <winrt/base.h>
+#pragma warning(pop)
+
 
 struct DxgiWindowState
 {

src/modules/MeasureTool/MeasureToolCore/PerGlyphOpacityTextRender.cpp

@@ -74,7 +74,12 @@ HRESULT __stdcall PerGlyphOpacityTextRender::DrawGlyphRun(void* /*clientDrawingC
     auto opacityEffect = clientDrawingEffect.try_query<IDrawingEffect>();
 
     if (opacityEffect)
-        _baseBrush->SetOpacity(static_cast<OpacityEffect*>(opacityEffect.get())->alpha);
+    {
+        const auto temp_opacity = dynamic_cast<OpacityEffect*>(opacityEffect.get());
+        assert(nullptr != temp_opacity);
+        _baseBrush->SetOpacity(temp_opacity->alpha);
+    }
+    
 
     if (SUCCEEDED(hr))
     {

src/modules/fancyzones/FancyZonesTests/UnitTests/pch.h

@@ -13,6 +13,11 @@
 #include <winrt/Windows.Foundation.h>
 #include <winrt/Windows.Foundation.Collections.h>
 #include "FancyZonesLib/pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
 
 #endif //PCH_H

src/modules/keyboardmanager/KeyboardManagerEditorTest/BufferValidationTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include <keyboardmanager/KeyboardManagerEditorLibrary/BufferValidationHelpers.h>
 #include <common/interop/keyboard_layout.h>
 #include <common/interop/shared_constants.h>

src/modules/keyboardmanager/KeyboardManagerEditorTest/EditorHelpersTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include <keyboardmanager/KeyboardManagerEditorLibrary/ShortcutErrorType.h>
 #include <keyboardmanager/common/Helpers.h>
 #include <common/interop/keyboard_layout.h>

src/modules/keyboardmanager/KeyboardManagerEditorTest/LoadingAndSavingRemappingTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include <keyboardmanager/common/MappingConfiguration.h>
 #include <keyboardmanager/KeyboardManagerEditorLibrary/LoadingAndSavingRemappingHelper.h>
 #include <common/interop/shared_constants.h>

src/modules/keyboardmanager/KeyboardManagerEngineTest/AppSpecificShortcutRemappingTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include "MockedInput.h"
 #include <keyboardmanager/KeyboardManagerEngineLibrary/State.h>
 #include <keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.h>

src/modules/keyboardmanager/KeyboardManagerEngineTest/MockedInputSanityTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include "MockedInput.h"
 #include <keyboardmanager/KeyboardManagerEngineLibrary/State.h>
 #include <keyboardmanager/common/KeyboardEventHandlers.h>

src/modules/keyboardmanager/KeyboardManagerEngineTest/OSLevelShortcutRemappingTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include "MockedInput.h"
 #include <keyboardmanager/KeyboardManagerEngineLibrary/State.h>
 #include <keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.h>

src/modules/keyboardmanager/KeyboardManagerEngineTest/SetKeyEventTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include "MockedInput.h"
 #include <keyboardmanager/KeyboardManagerEngineLibrary/State.h>
 #include <keyboardmanager/common/KeyboardEventHandlers.h>

src/modules/keyboardmanager/KeyboardManagerEngineTest/SingleKeyRemappingTests.cpp

@@ -1,5 +1,11 @@
 #include "pch.h"
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)
+
 #include "MockedInput.h"
 #include <keyboardmanager/KeyboardManagerEngineLibrary/State.h>
 #include <keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.h>

src/modules/powerrename/unittests/PowerRenameManagerTests.cpp

@@ -1,5 +1,4 @@
 #include "pch.h"
-#include "CppUnitTest.h"
 #include <PowerRenameInterfaces.h>
 #include <PowerRenameManager.h>
 #include <PowerRenameItem.h>

src/modules/powerrename/unittests/PowerRenameRegExBoostTests.cpp

@@ -1,5 +1,4 @@
 #include "pch.h"
-#include "CppUnitTest.h"
 #include "powerrename/lib/Settings.h"
 #include <PowerRenameInterfaces.h>
 #include <PowerRenameRegEx.h>

src/modules/powerrename/unittests/PowerRenameRegExTests.cpp

@@ -1,5 +1,4 @@
 #include "pch.h"
-#include "CppUnitTest.h"
 #include "powerrename/lib/Settings.h"
 #include <PowerRenameInterfaces.h>
 #include <PowerRenameRegEx.h>

src/modules/powerrename/unittests/pch.h

@@ -5,4 +5,9 @@
 #include <atlbase.h>
 
 // Headers for CppUnitTest
+
+// Suppressing 26466 - Don't use static_cast downcasts - in CppUnitTest.h
+#pragma warning(push)
+#pragma warning(disable : 26466)
 #include "CppUnitTest.h"
+#pragma warning(pop)