[Analyzers][CPP]Turn on warning 26466 (#22639)

* Turn on warning 26466

* changes from comments
This commit is contained in:
sosssego
2023-01-03 09:19:07 -03:00
committed by GitHub
parent 6287460614
commit b1c535a2ce
17 changed files with 76 additions and 5 deletions

View File

@@ -4,7 +4,13 @@
#include <dcomp.h>
#include <dxgi1_3.h>
#include <inspectable.h>
// Suppressing 26466 - Don't use static_cast downcasts - in base.h
#pragma warning(push)
#pragma warning(disable : 26466)
#include <winrt/base.h>
#pragma warning(pop)
struct DxgiWindowState
{

View File

@@ -74,7 +74,12 @@ HRESULT __stdcall PerGlyphOpacityTextRender::DrawGlyphRun(void* /*clientDrawingC
auto opacityEffect = clientDrawingEffect.try_query<IDrawingEffect>();
if (opacityEffect)
_baseBrush->SetOpacity(static_cast<OpacityEffect*>(opacityEffect.get())->alpha);
{
const auto temp_opacity = dynamic_cast<OpacityEffect*>(opacityEffect.get());
assert(nullptr != temp_opacity);
_baseBrush->SetOpacity(temp_opacity->alpha);
}
if (SUCCEEDED(hr))
{