From ae9ba62a40799c79d7f6a8f109a796a110b07871 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Pol=C3=A1=C5=A1ek?= Date: Fri, 9 Jan 2026 02:42:06 +0100 Subject: [PATCH] CmdPal: Remove subtitle from all built-in top level commands (#44621) ## Summary of the Pull Request This PR removes subtitles from all built-in top-level commands, except for fallbacks, apps, and bookmarks. image ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- .../Commands/BuiltInsCommandProvider.cs | 2 +- .../TimeDateCommandsProviderTests.cs | 15 --------------- .../CalculatorCommandProvider.cs | 1 - .../ClipboardHistoryCommandsProvider.cs | 1 - .../RemoteDesktopCommandProvider.cs | 1 - .../ShellCommandsProvider.cs | 1 - .../TimeDateCommandsProvider.cs | 1 - .../WindowWalkerCommandsProvider.cs | 1 - .../WindowsSettingsCommandsProvider.cs | 1 - 9 files changed, 1 insertion(+), 23 deletions(-) diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/BuiltInsCommandProvider.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/BuiltInsCommandProvider.cs index 0167f6f7a1..02da2b81f2 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/BuiltInsCommandProvider.cs +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/BuiltInsCommandProvider.cs @@ -21,7 +21,7 @@ public sealed partial class BuiltInsCommandProvider : CommandProvider public override ICommandItem[] TopLevelCommands() => [ new CommandItem(openSettings) { }, - new CommandItem(_newExtension) { Title = _newExtension.Title, Subtitle = Properties.Resources.builtin_new_extension_subtitle }, + new CommandItem(_newExtension) { Title = _newExtension.Title }, ]; public override IFallbackCommandItem[] FallbackCommands() => diff --git a/src/modules/cmdpal/Tests/Microsoft.CmdPal.Ext.TimeDate.UnitTests/TimeDateCommandsProviderTests.cs b/src/modules/cmdpal/Tests/Microsoft.CmdPal.Ext.TimeDate.UnitTests/TimeDateCommandsProviderTests.cs index 00f1af30a8..2006154600 100644 --- a/src/modules/cmdpal/Tests/Microsoft.CmdPal.Ext.TimeDate.UnitTests/TimeDateCommandsProviderTests.cs +++ b/src/modules/cmdpal/Tests/Microsoft.CmdPal.Ext.TimeDate.UnitTests/TimeDateCommandsProviderTests.cs @@ -90,20 +90,5 @@ namespace Microsoft.CmdPal.Ext.TimeDate.UnitTests // Assert Assert.IsFalse(string.IsNullOrEmpty(displayName)); } - - [TestMethod] - public void GetTranslatedPluginDescriptionTest() - { - // Setup - var provider = new TimeDateCommandsProvider(); - - // Act - var commands = provider.TopLevelCommands(); - var subtitle = commands[0].Subtitle; - - // Assert - Assert.IsFalse(string.IsNullOrEmpty(subtitle)); - Assert.IsTrue(subtitle.Contains("Show time and date values in different formats")); - } } } diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Calc/CalculatorCommandProvider.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Calc/CalculatorCommandProvider.cs index 1cb0c57f28..2fe90c6121 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Calc/CalculatorCommandProvider.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Calc/CalculatorCommandProvider.cs @@ -15,7 +15,6 @@ public partial class CalculatorCommandProvider : CommandProvider private static ISettingsInterface settings = new SettingsManager(); private readonly ListItem _listItem = new(new CalculatorListPage(settings)) { - Subtitle = Resources.calculator_top_level_subtitle, MoreCommands = [new CommandContextItem(((SettingsManager)settings).Settings.SettingsPage)], }; diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.ClipboardHistory/ClipboardHistoryCommandsProvider.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.ClipboardHistory/ClipboardHistoryCommandsProvider.cs index d88bffc9e0..6620902eca 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.ClipboardHistory/ClipboardHistoryCommandsProvider.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.ClipboardHistory/ClipboardHistoryCommandsProvider.cs @@ -19,7 +19,6 @@ public partial class ClipboardHistoryCommandsProvider : CommandProvider _clipboardHistoryListItem = new ListItem(new ClipboardHistoryListPage(_settingsManager)) { Title = Properties.Resources.list_item_title, - Subtitle = Properties.Resources.list_item_subtitle, Icon = Icons.ClipboardListIcon, MoreCommands = [ new CommandContextItem(_settingsManager.Settings.SettingsPage), diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.RemoteDesktop/RemoteDesktopCommandProvider.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.RemoteDesktop/RemoteDesktopCommandProvider.cs index 1ce307b301..005c93c7e1 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.RemoteDesktop/RemoteDesktopCommandProvider.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.RemoteDesktop/RemoteDesktopCommandProvider.cs @@ -31,7 +31,6 @@ public partial class RemoteDesktopCommandProvider : CommandProvider listPageCommand = new CommandItem(listPage) { - Subtitle = Resources.remotedesktop_subtitle, Icon = Icons.RDPIcon, MoreCommands = [ new CommandContextItem(settingsManager.Settings.SettingsPage), diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/ShellCommandsProvider.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/ShellCommandsProvider.cs index 943a3a1c8f..20c81d7832 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/ShellCommandsProvider.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/ShellCommandsProvider.cs @@ -39,7 +39,6 @@ public partial class ShellCommandsProvider : CommandProvider { Icon = Icons.RunV2Icon, Title = Resources.shell_command_name, - Subtitle = Resources.cmd_plugin_description, MoreCommands = [ new CommandContextItem(Settings.SettingsPage), ], diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/TimeDateCommandsProvider.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/TimeDateCommandsProvider.cs index 0ad8c339ff..8689d51078 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/TimeDateCommandsProvider.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/TimeDateCommandsProvider.cs @@ -28,7 +28,6 @@ public sealed partial class TimeDateCommandsProvider : CommandProvider { Icon = _timeDateExtensionPage.Icon, Title = Resources.Microsoft_plugin_timedate_plugin_name, - Subtitle = GetTranslatedPluginDescription(), MoreCommands = [new CommandContextItem(_settingsManager.Settings.SettingsPage)], }; diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/WindowWalkerCommandsProvider.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/WindowWalkerCommandsProvider.cs index 5b9bc79c9c..4862261a12 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/WindowWalkerCommandsProvider.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/WindowWalkerCommandsProvider.cs @@ -26,7 +26,6 @@ public partial class WindowWalkerCommandsProvider : CommandProvider _windowWalkerPageItem = new CommandItem(new WindowWalkerListPage()) { Title = Resources.window_walker_top_level_command_title, - Subtitle = Resources.windowwalker_name, MoreCommands = [ new CommandContextItem(Settings.SettingsPage), ], diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsSettings/WindowsSettingsCommandsProvider.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsSettings/WindowsSettingsCommandsProvider.cs index dd13d5295a..13728f3992 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsSettings/WindowsSettingsCommandsProvider.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsSettings/WindowsSettingsCommandsProvider.cs @@ -30,7 +30,6 @@ public sealed partial class WindowsSettingsCommandsProvider : CommandProvider _searchSettingsListItem = new CommandItem(new WindowsSettingsListPage(_windowsSettings)) { Title = Resources.settings_title, - Subtitle = Resources.settings_subtitle, }; _fallback = new(_windowsSettings);