Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 11:48:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Added additional checks in version info methods (#5173)

Browse Source
This commit is contained in:
Arjun Balgovind
2020-07-24 13:34:17 -07:00
committed by GitHub
parent 39ec10cbba
commit ab0047a9b7
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/modules/launcher/Wox.Infrastructure/Storage/StoragePowerToysVersionInfo.cs
View File

@@ -40,13 +40,29 @@ namespace Wox.Infrastructure.Storage
string[] split1 = version1.Split(new string[] { version, period }, StringSplitOptions.RemoveEmptyEntries);
string[] split2 = version2.Split(new string[] { version, period }, StringSplitOptions.RemoveEmptyEntries);
// If an incomplete file write resulted in the version number not being saved completely, then the cache must be deleted
if (split1.Length != split2.Length || split1.Length != versionLength)
{
return true;
}
for (int i = 0; i < versionLength; i++)
{
if (int.Parse(split1[i]) < int.Parse(split2[i]))
if (int.TryParse(split1[i], out int version1AsInt) && int.TryParse(split2[i], out int version2AsInt))
{
if (version1AsInt < version2AsInt)
{
return true;
}
}
// If either of the values could not be parsed, the version number was not saved correctly and the cache must be deleted
else
{
return true;
}
}
return false;
}