Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 02:36:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

.NET 8 Upgrade Silenced Errors Fix (#30469)

Browse Source 
* [Dev][Build] .NET 8 Upgrade Silenced errors first fix.

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1859

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1854.

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1860

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1861

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1862

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1863

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1864

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA1865

* [Dev][Build] .NET 8 Upgrade Silenced errors. CA2208

* [Dev][Build] .NET 8 Upgrade Silenced errors. CS9191

* [Dev][Build] .NET 8 Upgrade Silenced errors. Spell check

* [Dev][Build] .NET 8 Upgrade Silenced errors. Spell check

* [Dev][Build] .NET 8 Upgrade Silenced errors.
- CompositeFormat variables used more than once in the same file were assigned to a single variable.
- GetProcessesByName logic fix.
- String comparion fix.
- ArgumentOutOfRangeException message change.

* [Dev][Build] .NET 8 Upgrade Silenced errors.
- Null check added.
- static readonly CompositeFormat added for all fields.
This commit is contained in:
gokcekantarci
2023-12-28 13:37:13 +03:00
committed by GitHub
parent cd57659ef6
commit a94b3eec39
112 changed files with 429 additions and 291 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/modules/registrypreview/RegistryPreviewUI/MainWindow.Utilities.cs
View File

@@ -249,7 +249,7 @@ namespace RegistryPreview
// do not track the result of this node, since it should have no children
AddTextToTree(registryLine, imageName);
}
else if (registryLine.StartsWith("[", StringComparison.InvariantCulture))
else if (registryLine.StartsWith('['))
{
string imageName = KEYIMAGE;
CheckKeyLineForBrackets(ref registryLine, ref imageName);
@@ -259,7 +259,7 @@ namespace RegistryPreview
treeViewNode = AddTextToTree(registryLine, imageName);
}
else if (registryLine.StartsWith("\"", StringComparison.InvariantCulture) && registryLine.EndsWith("=-", StringComparison.InvariantCulture))
else if (registryLine.StartsWith('"') && registryLine.EndsWith("=-", StringComparison.InvariantCulture))
{
// this line deletes this value so it gets special treatment for the UI
registryLine = registryLine.Replace("=-", string.Empty);
@@ -277,7 +277,7 @@ namespace RegistryPreview
StoreTheListValue((RegistryKey)treeViewNode.Content, registryValue);
}
}
else if (registryLine.StartsWith("\"", StringComparison.InvariantCulture))
else if (registryLine.StartsWith('"'))
{
// this is a named value
@@ -310,16 +310,16 @@ namespace RegistryPreview
registryValue = new RegistryValue(name, "REG_SZ", string.Empty);
// if the first character is a " then this is a string value, so find the last most " which will avoid comments
if (value.StartsWith("\"", StringComparison.InvariantCulture))
if (value.StartsWith('"'))
{
int last = value.LastIndexOf("\"", StringComparison.InvariantCulture);
int last = value.LastIndexOf('"');
if (last >= 0)
{
value = value.Substring(0, last + 1);
}
}
if (value.StartsWith("\"", StringComparison.InvariantCulture) && value.EndsWith("\"", StringComparison.InvariantCulture))
if (value.StartsWith('"') && value.EndsWith('"'))
{
value = StripFirstAndLast(value);
}
@@ -988,7 +988,7 @@ namespace RegistryPreview
{
try
{
TextReader reader = new StreamReader(storageFile);
StreamReader reader = new StreamReader(storageFile);
fileContents = reader.ReadToEnd();
reader.Close();
}
@@ -1167,7 +1167,7 @@ namespace RegistryPreview
private string ScanAndRemoveComments(string value)
{
// scan for comments and remove them
int indexOf = value.IndexOf(";", StringComparison.InvariantCulture);
int indexOf = value.IndexOf(';');
if (indexOf > -1)
{
// presume that there is nothing following the start of the comment