Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-08 20:27:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed some minor code styling issues. Removed some minor redundant calculations for a small performance enhancement with zone detection.

Browse Source
This commit is contained in:
ebbyd3
2019-09-26 12:47:44 -05:00
committed by Enrico Giordani
parent af67f7782c
commit a8f0d3298f
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/modules/fancyzones/lib/ZoneSet.cpp
View File

@@ -78,6 +78,8 @@ IFACEMETHODIMP ZoneSet::RemoveZone(winrt::com_ptr<IZone> zone) noexcept
IFACEMETHODIMP_(winrt::com_ptr<IZone>) ZoneSet::ZoneFromPoint(POINT pt) noexcept IFACEMETHODIMP_(winrt::com_ptr<IZone>) ZoneSet::ZoneFromPoint(POINT pt) noexcept
{ {
winrt::com_ptr<IZone> smallestKnownZone = nullptr; winrt::com_ptr<IZone> smallestKnownZone = nullptr;
// To reduce redundant calculations, we will store the last known zones area.
int smallestKnownZoneArea = INT32_MAX;
for (auto iter = m_zones.begin(); iter != m_zones.end(); iter++) for (auto iter = m_zones.begin(); iter != m_zones.end(); iter++)
{ {
if (winrt::com_ptr<IZone> zone = iter->try_as<IZone>()) if (winrt::com_ptr<IZone> zone = iter->try_as<IZone>())
@@ -85,19 +87,22 @@ IFACEMETHODIMP_(winrt::com_ptr<IZone>) ZoneSet::ZoneFromPoint(POINT pt) noexcept
RECT* newZoneRect = &zone->GetZoneRect(); RECT* newZoneRect = &zone->GetZoneRect();
if (PtInRect(newZoneRect, pt)) if (PtInRect(newZoneRect, pt))
{ {
if(smallestKnownZone == nullptr) if (smallestKnownZone == nullptr)
{ {
smallestKnownZone = zone; smallestKnownZone = zone;
RECT* r = &smallestKnownZone->GetZoneRect();
smallestKnownZoneArea = (r->right-r->left)*(r->bottom-r->top);
} }
else else
{ {
RECT* r = &smallestKnownZone->GetZoneRect();
int knownZoneArea = (r->right-r->left)*(r->bottom-r->top);
int newZoneArea = (newZoneRect->right-newZoneRect->left)*(newZoneRect->bottom-newZoneRect->top); int newZoneArea = (newZoneRect->right-newZoneRect->left)*(newZoneRect->bottom-newZoneRect->top);
if(newZoneArea<knownZoneArea) if (newZoneArea<smallestKnownZoneArea)
{
smallestKnownZone = zone; smallestKnownZone = zone;
newZoneArea = smallestKnownZoneArea;
}
} }
} }
} }