[MouseHighlighter]Add always-on pointer (#27186)

* [MouseHighlighter]Add always pointer

Make color pick UI ARGB
Delete Opacity setting

* Fix opacity and color

Fix "always color" incorrectly initialized
Revert default opacity to 65%, which was unintentionally lowered to 25% when
changing to percent

* Fix crash when opening MouseUtils settings page

Migration code was bugged, made malformed json and led to settings page crash.

* Implement migration in module side

src/settings-ui/Settings.UI.Library/Helpers/SettingsUtilities.cs

@@ -35,5 +35,33 @@ namespace Microsoft.PowerToys.Settings.UI.Library.Helpers
                 return "#FFFFFF";
             }
         }
+
+        public static string ToARGBHex(string color)
+        {
+            if (color == null)
+            {
+                return "#FFFFFFFF";
+            }
+
+            // Using InvariantCulture as these are expected to be hex codes.
+            bool success = int.TryParse(
+                color.Replace("#", string.Empty),
+                System.Globalization.NumberStyles.HexNumber,
+                CultureInfo.InvariantCulture,
+                out int argb);
+
+            if (success)
+            {
+                Color clr = Color.FromArgb(argb);
+                return "#" + clr.A.ToString("X2", CultureInfo.InvariantCulture) +
+                    clr.R.ToString("X2", CultureInfo.InvariantCulture) +
+                    clr.G.ToString("X2", CultureInfo.InvariantCulture) +
+                    clr.B.ToString("X2", CultureInfo.InvariantCulture);
+            }
+            else
+            {
+                return "#FFFFFFFF";
+            }
+        }
     }
 }

src/settings-ui/Settings.UI.Library/MouseHighlighterProperties.cs

@@ -22,6 +22,9 @@ namespace Microsoft.PowerToys.Settings.UI.Library
         [JsonPropertyName("highlight_opacity")]
         public IntProperty HighlightOpacity { get; set; }
 
+        [JsonPropertyName("always_color")]
+        public StringProperty AlwaysColor { get; set; }
+
         [JsonPropertyName("highlight_radius")]
         public IntProperty HighlightRadius { get; set; }
 
@@ -34,9 +37,10 @@ namespace Microsoft.PowerToys.Settings.UI.Library
         public MouseHighlighterProperties()
         {
             ActivationShortcut = DefaultActivationShortcut;
-            LeftButtonClickColor = new StringProperty("#FFFF00");
-            RightButtonClickColor = new StringProperty("#0000FF");
-            HighlightOpacity = new IntProperty(65);
+            LeftButtonClickColor = new StringProperty("#a6FFFF00");
+            RightButtonClickColor = new StringProperty("#a60000FF");
+            AlwaysColor = new StringProperty("#00FF0000");
+            HighlightOpacity = new IntProperty(166); // for migration from <=1.1 to 1.2
             HighlightRadius = new IntProperty(20);
             HighlightFadeDelayMs = new IntProperty(500);
             HighlightFadeDurationMs = new IntProperty(250);

src/settings-ui/Settings.UI.Library/MouseHighlighterSettings.cs

@@ -2,6 +2,8 @@
 // The Microsoft Corporation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System.Globalization;
+using System.Runtime.InteropServices;
 using System.Text.Json.Serialization;
 using Microsoft.PowerToys.Settings.UI.Library.Interfaces;
 
@@ -18,7 +20,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
         {
             Name = ModuleName;
             Properties = new MouseHighlighterProperties();
-            Version = "1.1";
+            Version = "1.2";
         }
 
         public string GetModuleName()
@@ -29,11 +31,22 @@ namespace Microsoft.PowerToys.Settings.UI.Library
         // This can be utilized in the future if the settings.json file is to be modified/deleted.
         public bool UpgradeSettingsConfiguration()
         {
-            // Migrate settings from 1.0 to 1.1
-            if (Version == "1.0")
+            if (Version == "1.0" || Version == "1.1")
             {
-                Version = "1.1";
-                Properties.HighlightOpacity = new IntProperty(Properties.HighlightOpacity.Value * 100 / 255);
+                string opacity;
+                if (Version == "1.0")
+                {
+                    opacity = string.Format(CultureInfo.InvariantCulture, "{0:X2}", Properties.HighlightOpacity.Value);
+                }
+                else
+                {
+                    // 1.1
+                    opacity = string.Format(CultureInfo.InvariantCulture, "{0:X2}", Properties.HighlightOpacity.Value * 255 / 100);
+                }
+
+                Properties.LeftButtonClickColor = new StringProperty(string.Concat("#", opacity, Properties.LeftButtonClickColor.Value.ToString().Substring(1, 6)));
+                Properties.RightButtonClickColor = new StringProperty(string.Concat("#", opacity, Properties.RightButtonClickColor.Value.ToString().Substring(1, 6)));
+                Version = "1.2";
                 return true;
             }