Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-07 11:46:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

[fxcop] Settings UI unit tests (#6987)

Browse Source 
* Add FxCop to project

* Remove underscores from method names

* Add message to obsolete test method

* Mark method static

* Method renames and remove unused ToRGBHex method

* Method renames and replace Count() with the List.Count property

* Method renames, rename unused OnSend argument, validate argument for AssertHotkeySettings
This commit is contained in:
Luthfi Mawarid
2020-10-06 15:00:25 -07:00
committed by GitHub
parent 206397dc86
commit a2fce22973
13 changed files with 114 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/General.cs
View File

@@ -17,18 +17,18 @@ namespace ViewModelTests
[TestClass]
public class General
{
public const string generalSettings_file_name = "Test\\GenealSettings";
public const string generalSettingsFileName = "Test\\GenealSettings";
private Mock<ISettingsUtils> mockGeneralSettingsUtils;
[TestInitialize]
public void SetUp_StubSettingUtils()
public void SetUpStubSettingUtils()
{
mockGeneralSettingsUtils = ISettingsUtilsMocks.GetStubSettingsUtils<GeneralSettings>();
}
[TestMethod]
public void IsElevated_ShouldUpdateRunasAdminStatusAttrs_WhenSuccessful()
public void IsElevatedShouldUpdateRunasAdminStatusAttrsWhenSuccessful()
{
// Arrange
Func<string, int> SendMockIPCConfigMSG = msg => { return 0; };
@@ -44,7 +44,7 @@ namespace ViewModelTests
SendMockIPCConfigMSG,
SendRestartAdminIPCMessage,
SendCheckForUpdatesIPCMessage,
generalSettings_file_name);
generalSettingsFileName);
Assert.AreEqual(viewModel.RunningAsUserDefaultText, viewModel.RunningAsText);
Assert.IsFalse(viewModel.IsElevated);
@@ -58,7 +58,7 @@ namespace ViewModelTests
}
[TestMethod]
public void Startup_ShouldEnableRunOnStartUp_WhenSuccessful()
public void StartupShouldEnableRunOnStartUpWhenSuccessful()
{
// Assert
Func<string, int> SendMockIPCConfigMSG = msg =>
@@ -81,7 +81,7 @@ namespace ViewModelTests
SendMockIPCConfigMSG,
SendRestartAdminIPCMessage,
SendCheckForUpdatesIPCMessage,
generalSettings_file_name);
generalSettingsFileName);
Assert.IsFalse(viewModel.Startup);
// act
@@ -89,7 +89,7 @@ namespace ViewModelTests
}
[TestMethod]
public void RunElevated_ShouldEnableAlwaysRunElevated_WhenSuccessful()
public void RunElevatedShouldEnableAlwaysRunElevatedWhenSuccessful()
{
// Assert
Func<string, int> SendMockIPCConfigMSG = msg =>
@@ -113,7 +113,7 @@ namespace ViewModelTests
SendMockIPCConfigMSG,
SendRestartAdminIPCMessage,
SendCheckForUpdatesIPCMessage,
generalSettings_file_name);
generalSettingsFileName);
Assert.IsFalse(viewModel.RunElevated);
@@ -122,7 +122,7 @@ namespace ViewModelTests
}
[TestMethod]
public void IsLightThemeRadioButtonChecked_ShouldThemeToLight_WhenSuccessful()
public void IsLightThemeRadioButtonCheckedShouldThemeToLightWhenSuccessful()
{
// Arrange
GeneralViewModel viewModel = null;
@@ -146,7 +146,7 @@ namespace ViewModelTests
SendMockIPCConfigMSG,
SendRestartAdminIPCMessage,
SendCheckForUpdatesIPCMessage,
generalSettings_file_name);
generalSettingsFileName);
Assert.IsFalse(viewModel.IsLightThemeRadioButtonChecked);
// act
@@ -154,7 +154,7 @@ namespace ViewModelTests
}
[TestMethod]
public void IsDarkThemeRadioButtonChecked_ShouldThemeToDark_WhenSuccessful()
public void IsDarkThemeRadioButtonCheckedShouldThemeToDarkWhenSuccessful()
{
// Arrange
// Assert
@@ -177,7 +177,7 @@ namespace ViewModelTests
SendMockIPCConfigMSG,
SendRestartAdminIPCMessage,
SendCheckForUpdatesIPCMessage,
generalSettings_file_name);
generalSettingsFileName);
Assert.IsFalse(viewModel.IsDarkThemeRadioButtonChecked);
@@ -204,7 +204,7 @@ namespace ViewModelTests
Assert.IsTrue(modules.ColorPicker);
}
public int UpdateUIThemeMethod(string themeName)
public static int UpdateUIThemeMethod(string themeName)
{
return 0;
}