diff --git a/src/settings-ui/PowerToys.Settings/App.xaml.cs b/src/settings-ui/PowerToys.Settings/App.xaml.cs index f83b026198..50d0f989b5 100644 --- a/src/settings-ui/PowerToys.Settings/App.xaml.cs +++ b/src/settings-ui/PowerToys.Settings/App.xaml.cs @@ -62,13 +62,13 @@ namespace PowerToys.Settings if (ShowOobe) { PowerToysTelemetry.Log.WriteEvent(new OobeStartedEvent()); - OobeWindow oobeWindow = new OobeWindow((int)Microsoft.PowerToys.Settings.UI.OOBE.Enums.PowerToysModulesEnum.Overview); + OobeWindow oobeWindow = new OobeWindow(Microsoft.PowerToys.Settings.UI.OOBE.Enums.PowerToysModulesEnum.Overview); oobeWindow.Show(); } else if (ShowScoobe) { PowerToysTelemetry.Log.WriteEvent(new ScoobeStartedEvent()); - OobeWindow scoobeWindow = new OobeWindow((int)Microsoft.PowerToys.Settings.UI.OOBE.Enums.PowerToysModulesEnum.WhatsNew); + OobeWindow scoobeWindow = new OobeWindow(Microsoft.PowerToys.Settings.UI.OOBE.Enums.PowerToysModulesEnum.WhatsNew); scoobeWindow.Show(); } } diff --git a/src/settings-ui/PowerToys.Settings/MainWindow.xaml.cs b/src/settings-ui/PowerToys.Settings/MainWindow.xaml.cs index 87c89a6e4c..eedcb8c289 100644 --- a/src/settings-ui/PowerToys.Settings/MainWindow.xaml.cs +++ b/src/settings-ui/PowerToys.Settings/MainWindow.xaml.cs @@ -125,7 +125,7 @@ namespace PowerToys.Settings // open oobe ShellPage.SetOpenOobeCallback(() => { - var oobe = new OobeWindow((int)Microsoft.PowerToys.Settings.UI.OOBE.Enums.PowerToysModulesEnum.Overview); + var oobe = new OobeWindow(Microsoft.PowerToys.Settings.UI.OOBE.Enums.PowerToysModulesEnum.Overview); oobe.Show(); }); diff --git a/src/settings-ui/PowerToys.Settings/OobeWindow.xaml.cs b/src/settings-ui/PowerToys.Settings/OobeWindow.xaml.cs index 660570eb46..fe21a6cf48 100644 --- a/src/settings-ui/PowerToys.Settings/OobeWindow.xaml.cs +++ b/src/settings-ui/PowerToys.Settings/OobeWindow.xaml.cs @@ -7,6 +7,7 @@ using System.Windows; using System.Windows.Interop; using interop; using Microsoft.PowerToys.Settings.UI.Helpers; +using Microsoft.PowerToys.Settings.UI.OOBE.Enums; using Microsoft.PowerToys.Settings.UI.OOBE.Views; using Microsoft.Toolkit.Wpf.UI.XamlHost; using Windows.ApplicationModel.Resources; @@ -20,7 +21,7 @@ namespace PowerToys.Settings { private static Window inst; private OobeShellPage shellPage; - private int initialModule; + private PowerToysModulesEnum initialModule; public static bool IsOpened { @@ -30,7 +31,7 @@ namespace PowerToys.Settings } } - public OobeWindow(int initialModule) + public OobeWindow(PowerToysModulesEnum initialModule) { InitializeComponent(); Utils.FitToScreen(this); diff --git a/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml b/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml index 8d39aae96a..d256adf903 100644 --- a/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml +++ b/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml @@ -17,7 +17,7 @@ diff --git a/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml.cs b/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml.cs index 8d2ab0693c..9683210ae2 100644 --- a/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml.cs +++ b/src/settings-ui/Settings.UI/Controls/OOBEPageControl/OOBEPageControl.xaml.cs @@ -14,33 +14,33 @@ namespace Microsoft.PowerToys.Settings.UI.Controls this.InitializeComponent(); } - public string ModuleTitle + public string Title { - get { return (string)GetValue(ModuleTitleProperty); } - set { SetValue(ModuleTitleProperty, value); } + get { return (string)GetValue(TitleProperty); } + set { SetValue(TitleProperty, value); } } - public string ModuleDescription + public string Description { - get => (string)GetValue(ModuleDescriptionProperty); - set => SetValue(ModuleDescriptionProperty, value); + get => (string)GetValue(DescriptionProperty); + set => SetValue(DescriptionProperty, value); } - public string ModuleImageSource + public string HeroImage { - get => (string)GetValue(ModuleImageSourceProperty); - set => SetValue(ModuleImageSourceProperty, value); + get => (string)GetValue(HeroImageProperty); + set => SetValue(HeroImageProperty, value); } - public object ModuleContent + public object PageContent { - get { return (object)GetValue(ModuleContentProperty); } - set { SetValue(ModuleContentProperty, value); } + get { return (object)GetValue(PageContentProperty); } + set { SetValue(PageContentProperty, value); } } - public static readonly DependencyProperty ModuleTitleProperty = DependencyProperty.Register("ModuleTitle", typeof(string), typeof(SettingsPageControl), new PropertyMetadata(default(string))); - public static readonly DependencyProperty ModuleDescriptionProperty = DependencyProperty.Register("ModuleDescription", typeof(string), typeof(SettingsPageControl), new PropertyMetadata(default(string))); - public static readonly DependencyProperty ModuleImageSourceProperty = DependencyProperty.Register("ModuleImageSource", typeof(string), typeof(SettingsPageControl), new PropertyMetadata(default(string))); - public static readonly DependencyProperty ModuleContentProperty = DependencyProperty.Register("ModuleContent", typeof(object), typeof(SettingsPageControl), new PropertyMetadata(new Grid())); + public static readonly DependencyProperty TitleProperty = DependencyProperty.Register("Title", typeof(string), typeof(SettingsPageControl), new PropertyMetadata(default(string))); + public static readonly DependencyProperty DescriptionProperty = DependencyProperty.Register("Description", typeof(string), typeof(SettingsPageControl), new PropertyMetadata(default(string))); + public static readonly DependencyProperty HeroImageProperty = DependencyProperty.Register("HeroImage", typeof(string), typeof(SettingsPageControl), new PropertyMetadata(default(string))); + public static readonly DependencyProperty PageContentProperty = DependencyProperty.Register("PageContent", typeof(object), typeof(SettingsPageControl), new PropertyMetadata(new Grid())); } } diff --git a/src/settings-ui/Settings.UI/OOBE/Enums/PowerToysModulesEnum.cs b/src/settings-ui/Settings.UI/OOBE/Enums/PowerToysModulesEnum.cs index 6795ec4ab2..998a2a8f7f 100644 --- a/src/settings-ui/Settings.UI/OOBE/Enums/PowerToysModulesEnum.cs +++ b/src/settings-ui/Settings.UI/OOBE/Enums/PowerToysModulesEnum.cs @@ -7,7 +7,6 @@ namespace Microsoft.PowerToys.Settings.UI.OOBE.Enums public enum PowerToysModulesEnum { Overview = 0, - WhatsNew, AlwaysOnTop, Awake, ColorPicker, @@ -20,5 +19,6 @@ namespace Microsoft.PowerToys.Settings.UI.OOBE.Enums Run, ShortcutGuide, VideoConference, + WhatsNew, } } diff --git a/src/settings-ui/Settings.UI/OOBE/ViewModel/OobePowerToysModule.cs b/src/settings-ui/Settings.UI/OOBE/ViewModel/OobePowerToysModule.cs index 76cd71fa23..97be7276de 100644 --- a/src/settings-ui/Settings.UI/OOBE/ViewModel/OobePowerToysModule.cs +++ b/src/settings-ui/Settings.UI/OOBE/ViewModel/OobePowerToysModule.cs @@ -17,20 +17,6 @@ namespace Microsoft.PowerToys.Settings.UI.OOBE.ViewModel public bool IsNew { get; set; } - public string Image { get; set; } - - public string Icon { get; set; } - - public string FluentIcon { get; set; } - - public string PreviewImageSource { get; set; } - - public string Description { get; set; } - - public string Link { get; set; } - - public string DescriptionLink { get; set; } - public OobePowerToysModule() { } @@ -45,13 +31,6 @@ namespace Microsoft.PowerToys.Settings.UI.OOBE.ViewModel ModuleName = other.ModuleName; Tag = other.Tag; IsNew = other.IsNew; - Image = other.Image; - Icon = other.Icon; - FluentIcon = other.FluentIcon; - PreviewImageSource = other.PreviewImageSource; - Description = other.Description; - Link = other.Link; - DescriptionLink = other.DescriptionLink; timeOpened = other.timeOpened; } diff --git a/src/settings-ui/Settings.UI/OOBE/Views/OobeAlwaysOnTop.xaml b/src/settings-ui/Settings.UI/OOBE/Views/OobeAlwaysOnTop.xaml index f5ce24542e..e70f7d7bf6 100644 --- a/src/settings-ui/Settings.UI/OOBE/Views/OobeAlwaysOnTop.xaml +++ b/src/settings-ui/Settings.UI/OOBE/Views/OobeAlwaysOnTop.xaml @@ -9,11 +9,10 @@ xmlns:controls="using:Microsoft.PowerToys.Settings.UI.Controls" xmlns:toolkitcontrols="using:Microsoft.Toolkit.Uwp.UI.Controls"> - + - + @@ -29,13 +28,13 @@