From 9baaaefc5fc7028cd0e6cb0dc925f060010374a3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D7=90=D7=91=D7=99=D7=AA=D7=A8?=
 <79063413+Evyatar-E@users.noreply.github.com>
Date: Mon, 9 Jan 2023 16:07:35 +0200
Subject: [PATCH] [QuickAccent]Support the Hebrew character set (#22712)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: אביתר אסתרסון <79063413+EvyatarEsterson@users.noreply.github.com>
Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
---
 .../poweraccent/PowerAccent.Core/Languages.cs   | 17 +++++++++++++++++
 .../Settings.UI/Strings/en-us/Resources.resw    |  3 +++
 .../ViewModels/PowerAccentViewModel.cs          |  1 +
 .../Settings.UI/Views/PowerAccentPage.xaml      |  1 +
 4 files changed, 22 insertions(+)

diff --git a/src/modules/poweraccent/PowerAccent.Core/Languages.cs b/src/modules/poweraccent/PowerAccent.Core/Languages.cs
index 6a44cdef89..bf302ee819 100644
--- a/src/modules/poweraccent/PowerAccent.Core/Languages.cs
+++ b/src/modules/poweraccent/PowerAccent.Core/Languages.cs
@@ -21,6 +21,7 @@ namespace PowerAccent.Core
         EST,
         FR,
         HR,
+        HE,
         HU,
         IS,
         IT,
@@ -56,6 +57,7 @@ namespace PowerAccent.Core
                 Language.EST => GetDefaultLetterKeyEST(letter), // Estonian
                 Language.FR => GetDefaultLetterKeyFR(letter), // French
                 Language.HR => GetDefaultLetterKeyHR(letter), // Croatian
+                Language.HE => GetDefaultLetterKeyHE(letter), // Hebrew
                 Language.HU => GetDefaultLetterKeyHU(letter), // Hungarian
                 Language.IS => GetDefaultLetterKeyIS(letter), // Iceland
                 Language.IT => GetDefaultLetterKeyIT(letter), // Italian
@@ -448,6 +450,21 @@ namespace PowerAccent.Core
             };
         }
 
+        // Hebrew
+        private static string[] GetDefaultLetterKeyHE(LetterKey letter)
+        {
+            return letter switch
+            {
+                LetterKey.VK_A => new string[] { "שׂ", "שׁ" },
+                LetterKey.VK_G => new string[] { "ױ" },
+                LetterKey.VK_H => new string[] { "ײ" },
+                LetterKey.VK_U => new string[] { "וֹ", "וּ" },
+                LetterKey.VK_Y => new string[] { "װ" },
+                LetterKey.VK_COMMA => new string[] { "”", "״", "־", "–", "֫", "ֽ", "ֿ" },
+                _ => Array.Empty<string>(),
+            };
+        }
+
         // Hungarian
         private static string[] GetDefaultLetterKeyHU(LetterKey letter)
         {
diff --git a/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw b/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw
index 2995397d75..08da992c34 100644
--- a/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw
+++ b/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw
@@ -2725,6 +2725,9 @@ Activate by holding the key for the character you want to add an accent to, then
   <data name="QuickAccent_SelectedLanguage_German.Content" xml:space="preserve">
     <value>German</value>
   </data>
+  <data name="QuickAccent_SelectedLanguage_Hebrew.Content" xml:space="preserve">
+    <value>Hebrew</value>
+  </data>
   <data name="QuickAccent_SelectedLanguage_French.Content" xml:space="preserve">
     <value>French</value>
   </data>
diff --git a/src/settings-ui/Settings.UI/ViewModels/PowerAccentViewModel.cs b/src/settings-ui/Settings.UI/ViewModels/PowerAccentViewModel.cs
index 05f96c3d45..368f73155a 100644
--- a/src/settings-ui/Settings.UI/ViewModels/PowerAccentViewModel.cs
+++ b/src/settings-ui/Settings.UI/ViewModels/PowerAccentViewModel.cs
@@ -34,6 +34,7 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
             "EST",
             "FR",
             "DE",
+            "HE",
             "HU",
             "IS",
             "IT",
diff --git a/src/settings-ui/Settings.UI/Views/PowerAccentPage.xaml b/src/settings-ui/Settings.UI/Views/PowerAccentPage.xaml
index 49223e0e0c..00bed3803f 100644
--- a/src/settings-ui/Settings.UI/Views/PowerAccentPage.xaml
+++ b/src/settings-ui/Settings.UI/Views/PowerAccentPage.xaml
@@ -71,6 +71,7 @@
                             <ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Estonian" />
                             <ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_French" />
                             <ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_German" />
+                            <ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Hebrew" />
                             <ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Hungarian" />
                             <ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Icelandic" />
                             <ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Italian" />