From 9a65c36859ec51f8f2c1f82fa16dc78fd123e606 Mon Sep 17 00:00:00 2001 From: leileizhang Date: Fri, 11 Jul 2025 14:43:56 +0800 Subject: [PATCH] Fix WiX component GUID conflict between BgcodePreviewHandler and GcodePreviewHandler (#40553) ## Summary of the Pull Request Fixes WiX installer build failure caused by GUID conflict between `BgcodePreviewHandler` and `GcodePreviewHandler` components in the Resources.wxs file. ### Root cause Both `BgcodePreviewHandler` and `GcodePreviewHandler` components were using the same GUID suffix `07`, causing WiX build errors due to duplicate component GUIDs across all language variations. ### Fix Changed `BgcodePreviewHandler` component GUID suffix from `07` to `22` to ensure unique component identification. ## PR Checklist - [x] **Closes:** #40552 - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- installer/PowerToysSetup/Resources.wxs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/installer/PowerToysSetup/Resources.wxs b/installer/PowerToysSetup/Resources.wxs index 8f7ff494da..5da4db1390 100644 --- a/installer/PowerToysSetup/Resources.wxs +++ b/installer/PowerToysSetup/Resources.wxs @@ -233,15 +233,6 @@ - - - - - - + + + + + +