From 95dd85520b98f24afee155449b6112deb5ce1fe2 Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Tue, 19 Aug 2025 06:35:10 -0500 Subject: [PATCH] nits --- .../Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj | 4 ++-- .../Pages/WinGetExtensionPage.cs | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj b/src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj index 14689413c1..9058a8f9f9 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj @@ -25,10 +25,10 @@ - + true diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Pages/WinGetExtensionPage.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Pages/WinGetExtensionPage.cs index cdcf6cbed4..f4cbea48de 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Pages/WinGetExtensionPage.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Pages/WinGetExtensionPage.cs @@ -32,7 +32,7 @@ internal sealed partial class WinGetExtensionPage : DynamicListPage, IDisposable private CancellationTokenSource? _cancellationTokenSource; private Task>? _currentSearchTask; - private IEnumerable? _results; + private List? _results; public static string ExtensionsTag => "windows-commandpalette-extension"; @@ -63,16 +63,16 @@ internal sealed partial class WinGetExtensionPage : DynamicListPage, IDisposable return []; } - if (_results != null && _results.Any()) + if (_results != null && _results.Count != 0) { - var count = _results.Count(); + var count = _results.Count; var results = new ListItem[count]; var next = 0; for (var i = 0; i < count; i++) { try { - var li = PackageToListItem(_results.ElementAt(i)); + var li = PackageToListItem(_results[i]); results[next] = li; next++; } @@ -180,10 +180,10 @@ internal sealed partial class WinGetExtensionPage : DynamicListPage, IDisposable Logger.LogDebug($"Completed search for '{query}'"); lock (_resultsLock) { - this._results = results; + this._results = results.ToList(); } - RaiseItemsChanged(this._results.Count()); + RaiseItemsChanged(); } private async Task> DoSearchAsync(string query, CancellationToken ct) @@ -263,7 +263,7 @@ internal sealed partial class WinGetExtensionPage : DynamicListPage, IDisposable Logger.LogDebug($" got results for ({query})", memberName: nameof(DoSearchAsync)); - // FYI Using .ToArray or any other kind of enumberable loop + // FYI Using .ToArray or any other kind of enumerable loop // on arrays returned by the winget API are NOT trim safe var count = searchResults.Matches.Count; for (var i = 0; i < count; i++)