[New+] Hide existing new - remake (#44979)

## Summary of the Pull Request - Add the ability for users and admins (GPO) to control whether to display built in New on the context menu. - Changes to the setting are immediately reflected in the experience. - Built-in New is restored on uninstall. ## PR Checklist Note: Supersedes https://github.com/microsoft/PowerToys/pull/39843 - [x] **Closes**: [New+] Replace default New entry #37545 and Replace "New" with New+ option #37946 - [x] **Communication:** Discussed with @niels9001 - 1/22/2025 - [x] **Tests:** Completed manual test pass see highlight below - [x] **Localization:** All end-user-facing strings can be localized - [x] **Dev docs:** Updated "doc\devdocs\modules\newplus.md" - [n/a] **New binaries:** Added on the required places - [n/a] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [x] [WXS for installer] Updated installer (uninstall custom action) - [n/a] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [n/a] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [No] **Documentation updated:** Pending, coming soon. (original PR https://github.com/MicrosoftDocs/windows-dev-docs/pull/5473) ## Detailed Description of the Pull Request / Additional comments Added the ability for users' admins' to display Windows built-in New or not I'm NOT aware of an official supported way to do this, so I'm achieving this by adding an invalid context menu handler in place of New in the Computer\HKEY_CURRENT_USER\Software\Classes\Directory\background\ShellEx\ContextMenuHandlers\New Changes are immediate, after applying the change, built-in New is shown/hidden accordingly Updates to New+ Settings UI New setting introduced to track user' preference (saved to newplus/settings.json) GPO setting introduced for control New visibility via GPO (GPO wins over user preference) Updates to New+ power_module.cpp When runner is running new plus will also apply built-in New admin GPO and user preference (GPO wins over user preference) to ensure correct behavior on setting restore and GPO application. Updates to installer Uninstall always reenable built-in "New" context menu Updated DevDoc Added a note on how to manually restore built-in New ## Validation Steps Performed Windows 11 x64 Settings UI New+ enabled New+ disabled GPO setting enabled GPO settings disabled Manually updating newplus/settings.json Windows 11 ARM64 I tested the reg hack manually, but didn't go through a full pass. Windows 10 x64 NOT tested. Windows 11, Settings, New+ Disabled and no GPO <img width="1040" height="1002" alt="image" src="https://github.com/user-attachments/assets/1b827b10-f009-4b0b-954f-d9311d40d201" /> Windows 11, Settings, New+ Enabled and no GPO <img width="1015" height="781" alt="image" src="https://github.com/user-attachments/assets/a5fa09d3-7fd3-4830-99a4-5f2ac9ce1a38" /> Hide built-in New: Off (the default) <img width="321" height="417" alt="image" src="https://github.com/user-attachments/assets/355fea60-bbb8-4f11-b648-291aaf0c4a6d" /> Hide built-in New: On <img width="1015" height="87" alt="image" src="https://github.com/user-attachments/assets/e83e45c4-6b67-443b-b045-26e7dda2cf46" /> Modern <img width="308" height="360" alt="image" src="https://github.com/user-attachments/assets/b164b240-6e67-410c-8481-7db3ee3225b7" /> Classic <img width="308" height="289" alt="image" src="https://github.com/user-attachments/assets/e2b6c262-a311-454c-9c76-40cb11ff2970" /> Disabling New+ also unhide New <img width="1031" height="569" alt="image" src="https://github.com/user-attachments/assets/29b8dae7-8190-4e64-b106-c6861e472a3d" /> <img width="308" height="353" alt="image" src="https://github.com/user-attachments/assets/e1977d6b-dc85-4db4-b9ab-c7bb2b27dde2" /> Windows 11, Settings, New+ Enabled and with GPO Hide built-in New: GPO enabled <img width="1020" height="691" alt="image" src="https://github.com/user-attachments/assets/75053ab8-92c6-4d38-b1b8-9b0d8293c207" /> Hide built-in New: GPO disabled <img width="1050" height="161" alt="image" src="https://github.com/user-attachments/assets/1a50b841-ff01-4662-a923-aee63717c834" />
2026-04-03 17:56:44 +02:00 · 2026-03-01 03:32:38 -08:00
parent 3e1b07f52c
commit 90e81cbfd5
19 changed files with 363 additions and 6 deletions
--- a/src/settings-ui/Settings.UI/ViewModels/NewPlusViewModel.cs
+++ b/src/settings-ui/Settings.UI/ViewModels/NewPlusViewModel.cs
@@ -9,6 +9,7 @@ using System.IO;
 using System.Text.Json;
 using System.Threading.Tasks;
 using System.Windows;
+
 using global::PowerToys.GPOWrapper;
 using ManagedCommon;
 using Microsoft.PowerToys.Settings.UI.Library;
@@ -17,7 +18,7 @@ using Microsoft.PowerToys.Settings.UI.Library.Interfaces;
 using Microsoft.PowerToys.Settings.UI.Library.Utilities;
 using Microsoft.PowerToys.Settings.UI.Library.ViewModels.Commands;
 using Microsoft.PowerToys.Settings.UI.SerializationContext;
-
+using Microsoft.Win32;
 using static Microsoft.PowerToys.Settings.UI.Helpers.ShellGetFolder;

 namespace Microsoft.PowerToys.Settings.UI.ViewModels
@@ -32,6 +33,10 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels

        private const string ModuleName = NewPlusSettings.ModuleName;

+        private const string BuiltInNewRegistryPath = @"Software\Classes\Directory\Background\ShellEx\ContextMenuHandlers\New";
+        private const string BuiltNewCOMGuid = "{D969A300-E7FF-11d0-A93B-00A0C90F2719}";
+        private const string NewDisabledValuePrefix = "disabled_";
+
        public NewPlusViewModel(SettingsUtils settingsUtils, ISettingsRepository<GeneralSettings> settingsRepository, Func<string, int> ipcMSGCallBackFunc)
        {
            _settingsUtils = settingsUtils ?? throw new ArgumentNullException(nameof(settingsUtils));
@@ -51,6 +56,8 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
            InitializeEnabledValue();
            InitializeGpoValues();

+            _disableBuiltInNew = !IsBuiltInNewEnabled();
+
            // set the callback functions value to handle outgoing IPC message.
            SendConfigMSG = ipcMSGCallBackFunc;
        }
@@ -76,6 +83,10 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
            _hideFileExtensionGpoRuleConfiguration = GPOWrapper.GetConfiguredNewPlusHideTemplateFilenameExtensionValue();
            _hideFileExtensionIsGPOConfigured = _hideFileExtensionGpoRuleConfiguration == GpoRuleConfigured.Disabled || _hideFileExtensionGpoRuleConfiguration == GpoRuleConfigured.Enabled;

+            // Policy for Hide Built-in New toggle setting
+            _hideBuiltInNewContextMenuToggleSettingGPOConfigured = GPOWrapper.GetConfiguredNewPlusHideBuiltInNewContextMenuValue() == GpoRuleConfigured.Enabled
+                                                    || GPOWrapper.GetConfiguredNewPlusHideBuiltInNewContextMenuValue() == GpoRuleConfigured.Disabled;
+
            // Same for Replace Variables
            _replaceVariablesIsGPOConfigured = GPOWrapper.GetConfiguredNewPlusReplaceVariablesValue() == GpoRuleConfigured.Enabled
                                                    || GPOWrapper.GetConfiguredNewPlusReplaceVariablesValue() == GpoRuleConfigured.Disabled;
@@ -96,6 +107,8 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
                    OnPropertyChanged(nameof(IsHideFileExtSettingGPOConfigured));
                    OnPropertyChanged(nameof(IsReplaceVariablesSettingGPOConfigured));
                    OnPropertyChanged(nameof(IsReplaceVariablesSettingsCardEnabled));
+                    OnPropertyChanged(nameof(IsDisableBuiltInNewSettingsCardEnabled));
+                    OnPropertyChanged(nameof(IsNewPlusHideBuiltInNewToggleSettingGPOConfigured));

                    OutGoingGeneralSettings outgoingMessage = new OutGoingGeneralSettings(GeneralSettingsConfig);
                    SendConfigMSG(outgoingMessage.ToString());
@@ -106,6 +119,14 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
                    {
                        CopyTemplateExamples(_templateLocation);
                    }
+                    else
+                    {
+                        // Re-enable built-in New handler when NewPlus is disabled if allowed by GPO
+                        if (!IsNewPlusHideBuiltInNewToggleSettingGPOConfigured)
+                        {
+                            EnableBuiltInNewViaRegistry();
+                        }
+                    }
                }
            }
        }
@@ -164,6 +185,10 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels

        public bool IsReplaceVariablesSettingGPOConfigured => _isNewPlusEnabled && _replaceVariablesIsGPOConfigured;

+        public bool IsDisableBuiltInNewSettingsCardEnabled => _isNewPlusEnabled && !_hideBuiltInNewContextMenuToggleSettingGPOConfigured;
+
+        public bool IsNewPlusHideBuiltInNewToggleSettingGPOConfigured => _isNewPlusEnabled && _hideBuiltInNewContextMenuToggleSettingGPOConfigured;
+
        public bool HideStartingDigits
        {
            get => _hideStartingDigits;
@@ -206,6 +231,48 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
            }
        }

+        public bool HideBuiltInNew
+        {
+            get
+            {
+                if (IsNewPlusHideBuiltInNewToggleSettingGPOConfigured)
+                {
+                    return GPOWrapper.GetConfiguredNewPlusHideBuiltInNewContextMenuValue() == GpoRuleConfigured.Enabled;
+                }
+
+                return _disableBuiltInNew;
+            }
+
+            set
+            {
+                if (IsNewPlusHideBuiltInNewToggleSettingGPOConfigured)
+                {
+                    value = GPOWrapper.GetConfiguredNewPlusHideBuiltInNewContextMenuValue() == GpoRuleConfigured.Enabled;
+                }
+
+                if (_disableBuiltInNew != value)
+                {
+                    // Update New visibility right now
+                    if (_disableBuiltInNew)
+                    {
+                        EnableBuiltInNewViaRegistry();
+                    }
+                    else
+                    {
+                        DisableBuiltInNewViaRegistry();
+                    }
+
+                    _disableBuiltInNew = value;
+                    OnPropertyChanged(nameof(HideBuiltInNew));
+
+                    // Set the user preference for New visibility, which we then also use in powertoys_module.cpp to ensure
+                    // that backup/restore of settings work without having to update settings
+                    Settings.Properties.BuiltInNewHidePreference.Value = value;
+                    NotifySettingsChanged();
+                }
+            }
+        }
+
        public bool IsEnabledGpoConfigured
        {
            get => _enabledStateIsGPOConfigured;
@@ -271,12 +338,14 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
        private bool _hideFileExtension;
        private bool _hideStartingDigits;
        private bool _replaceVariables;
+        private bool _disableBuiltInNew; // reflects the current state of New visibility

        private GpoRuleConfigured _enabledGpoRuleConfiguration;
        private bool _enabledStateIsGPOConfigured;
        private GpoRuleConfigured _hideFileExtensionGpoRuleConfiguration;
        private bool _hideFileExtensionIsGPOConfigured;
        private bool _replaceVariablesIsGPOConfigured;
+        private bool _hideBuiltInNewContextMenuToggleSettingGPOConfigured;

        public void RefreshEnabledState()
        {
@@ -317,5 +386,87 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
            var hwnd = WinRT.Interop.WindowNative.GetWindowHandle(App.GetSettingsWindow());
            return await Task.FromResult(GetFolderDialogWithFlags(hwnd, FolderDialogFlags._BIF_NEWDIALOGSTYLE));
        }
+
+        private bool IsBuiltInNewEnabled()
+        {
+            try
+            {
+                using (var newKey = Registry.CurrentUser.OpenSubKey(BuiltInNewRegistryPath, writable: false))
+                {
+                    string builtInNewHandlerValue = newKey.GetValue(null, null) as string;
+
+                    if (builtInNewHandlerValue is null || string.Equals(builtInNewHandlerValue, BuiltNewCOMGuid, StringComparison.OrdinalIgnoreCase))
+                    {
+                        // If no default value for key, or GUID is BuiltNewCOMGuid then built-in New is enabled
+                        return true;
+                    }
+
+                    return false;
+                }
+            }
+            catch (Exception ex)
+            {
+                Logger.LogError("Failed to determine built-in New enablement status.", ex);
+            }
+
+            return false;
+        }
+
+        private void DisableBuiltInNewViaRegistry()
+        {
+            try
+            {
+                using (var newKey = Registry.CurrentUser.OpenSubKey(BuiltInNewRegistryPath, writable: true))
+                {
+                    string builtInNewHandlerValue = newKey.GetValue(null, null) as string;
+
+                    if (!string.IsNullOrEmpty(builtInNewHandlerValue) && builtInNewHandlerValue.StartsWith(NewDisabledValuePrefix, StringComparison.OrdinalIgnoreCase))
+                    {
+                        // Already disabled
+                        return;
+                    }
+
+                    // Any string value will disable the built-in New handler
+                    string newDisabledValue = NewDisabledValuePrefix + builtInNewHandlerValue;
+                    newKey.SetValue(string.Empty, newDisabledValue);
+                }
+
+                HideBuiltInNew = true;
+                OnPropertyChanged(nameof(HideBuiltInNew));
+            }
+            catch (Exception ex)
+            {
+                Logger.LogError("Failed to disable built-in New in the registry.", ex);
+                MessageBox.Show(ex.Message);
+            }
+        }
+
+        private void EnableBuiltInNewViaRegistry()
+        {
+            try
+            {
+                using (var newKey = Registry.CurrentUser.OpenSubKey(BuiltInNewRegistryPath, writable: true))
+                {
+                    string builtInNewHandlerValue = newKey.GetValue(null, null) as string;
+
+                    if (builtInNewHandlerValue is null)
+                    {
+                        // Already enabled
+                        return;
+                    }
+
+                    // Null key default value enables built-in New handler
+                    newKey.DeleteValue(null, true);
+                }
+
+                HideBuiltInNew = false;
+                OnPropertyChanged(nameof(HideBuiltInNew));
+            }
+            catch (Exception ex)
+            {
+                Logger.LogError("Failed to enable built-in New in the registry.", ex);
+                MessageBox.Show(ex.Message);
+            }
+        }
    }
 }