Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 18:57:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Enable code analysis on Keyboard Manager projects (#4455)

Browse Source 
* Enable code analysis and fix GetTickCount warning

* Fix arithmetic casting warning
This commit is contained in:
Arjun Balgovind
2020-06-24 14:55:02 -07:00
committed by GitHub
parent 2601d8b702
commit 8e758507b1
7 changed files with 25 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/modules/keyboardmanager/common/KeyDelay.cpp
View File

@@ -24,7 +24,7 @@ KeyTimedEvent KeyDelay::NextEvent()
return ev;
}
bool KeyDelay::CheckIfMillisHaveElapsed(DWORD first, DWORD last, DWORD duration)
bool KeyDelay::CheckIfMillisHaveElapsed(DWORD64 first, DWORD64 last, DWORD64 duration)
{
if (first < last && first <= first + duration)
{
@@ -32,8 +32,8 @@ bool KeyDelay::CheckIfMillisHaveElapsed(DWORD first, DWORD last, DWORD duration)
}
else
{
first += ULONG_MAX / 2;
last += ULONG_MAX / 2;
first += ULLONG_MAX / 2;
last += ULLONG_MAX / 2;
return first + duration < last;
}
}
@@ -99,7 +99,7 @@ bool KeyDelay::HandleOnHold(std::unique_lock<std::mutex>& cvLock)
}
}
if (CheckIfMillisHaveElapsed(_initialHoldKeyDown, GetTickCount(), LONG_PRESS_DELAY_MILLIS))
if (CheckIfMillisHaveElapsed(_initialHoldKeyDown, GetTickCount64(), LONG_PRESS_DELAY_MILLIS))
{
if (_onLongPressDetected != nullptr)
{