From 8c4ff37a50d8cad5ca68baa1e3144656fd975a42 Mon Sep 17 00:00:00 2001 From: Niels Laute Date: Fri, 6 Mar 2026 22:27:23 +0100 Subject: [PATCH] [CmdPal] Visual dock tweaks (#45954) ## Summary of the Pull Request - Changes the Dock height to 38px (from 32) to avoid item and app clipping. - Localization - Removing dead code - If the tooltip string is null or empty, the tooltip will not be shown - Adding hyperlinks on the General and Dock pages in Settings (to be updated to the corresponding docs via aka.ms) - The droptarget for an empty listview is now wider, and has a highlight-color to communicate an item can be dropped: image ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- .../Properties/Resources.Designer.cs | 4 +- .../Properties/Resources.resx | 4 +- .../Microsoft.CmdPal.UI/Dock/DockControl.xaml | 56 ++++++++++------ .../Dock/DockControl.xaml.cs | 34 +++++++++- .../Dock/DockItemControl.xaml | 7 +- .../Dock/DockItemControl.xaml.cs | 13 +++- .../Dock/DockSettingsToViews.cs | 13 +--- .../Settings/DockSettingsPage.xaml | 8 ++- .../Settings/GeneralPage.xaml | 7 +- .../Strings/en-us/Resources.resw | 66 +++++++++++++------ 10 files changed, 146 insertions(+), 66 deletions(-) diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs index 4562386ead..025e72a475 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs @@ -484,7 +484,7 @@ namespace Microsoft.CmdPal.UI.ViewModels.Properties { } /// - /// Looks up a localized string similar to Edit dock. + /// Looks up a localized string similar to Edit Dock. /// public static string dock_edit_dock_name { get { @@ -511,7 +511,7 @@ namespace Microsoft.CmdPal.UI.ViewModels.Properties { } /// - /// Looks up a localized string similar to Dock settings. + /// Looks up a localized string similar to Settings. /// public static string dock_settings_name { get { diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.resx b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.resx index 62b366a80c..686bed066e 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.resx +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.resx @@ -277,11 +277,11 @@ Fallbacks - Edit dock + Edit Dock Command name for editing the dock - Dock settings + Settings Command name for opening dock settings diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockControl.xaml b/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockControl.xaml index ccfbbc8a22..8f8341ac5c 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockControl.xaml +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockControl.xaml @@ -1,4 +1,4 @@ - + - + + x:Uid="Dock_EditMode_ShowTitles" + Click="ShowTitlesMenuItem_Click" /> + x:Uid="Dock_EditMode_ShowSubtitles" + Click="ShowSubtitlesMenuItem_Click" /> + x:Uid="Dock_EditMode_Unpin" + Click="UnpinBandMenuItem_Click"> @@ -140,9 +140,9 @@ @@ -221,9 +224,12 @@ @@ -247,8 +254,11 @@ @@ -281,7 +292,6 @@ ShouldConstrainToRootBounds="False" Style="{StaticResource TeachingTipWithoutCloseButtonStyle}" Target="{x:Bind ContentGrid}"> -