Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-11 05:52:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

[RegistryPreview]Fix wrong key path transversal when a key was a substring of a parent (#29311)

Browse Source 
Replaced String.Replace with String.Substring to avoid the removal of multiple instances of a string, rather than just the last one.
This commit is contained in:
Randy
2023-10-20 03:59:21 -07:00
committed by GitHub
parent 6e598f54af
commit 8c22f0c485
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/modules/registrypreview/RegistryPreviewUI/MainWindow.Utilities.cs
View File

@@ -774,7 +774,19 @@ namespace RegistryPreview
// before moving onto the next node, tag the previous node and update the path // before moving onto the next node, tag the previous node and update the path
previousNode = newNode; previousNode = newNode;
fullPath = fullPath.Replace(string.Format(CultureInfo.InvariantCulture, @"\{0}", individualKeys[i]), string.Empty);
// this used to use Replace but that would replace all instances of the same key name, which causes bugs.
try
{
int removeAt = fullPath.LastIndexOf(string.Format(CultureInfo.InvariantCulture, @"\{0}", individualKeys[i]), StringComparison.InvariantCulture);
if (removeAt > -1)
{
fullPath = fullPath.Substring(0, removeAt);
}
}
catch
{
}
// One last check: if we get here, the parent of this node is not yet in the tree, so we need to add it as a RootNode // One last check: if we get here, the parent of this node is not yet in the tree, so we need to add it as a RootNode
if (i == 0) if (i == 0)