Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-06 19:26:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

[PTRun]Fix locking link files for MSI installers. Warning 1946 (#37654)

Browse Source 
* [Runner] fix MSI installer issue. Warning 1946

* Fix catching exceptions

* Better error handling

* Revert "Better error handling"

This reverts commit 0f3ec2a3ef.
This commit is contained in:
Laszlo Nemeth
2025-02-27 20:17:43 +01:00
committed by GitHub
parent bf2685757a
commit 8a2d4745fa
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/modules/launcher/Wox.Infrastructure/ShellLinkHelper.cs
View File

@@ -136,13 +136,25 @@ namespace Wox.Infrastructure
var link = new ShellLink(); var link = new ShellLink();
const int STGM_READ = 0; const int STGM_READ = 0;
// Make sure not to open exclusive handles.
// See: https://github.com/microsoft/WSL/issues/11276
const int STGM_SHARE_DENY_NONE = 0x00000040;
const int STGM_TRANSACTED = 0x00010000;
try try
{ {
((IPersistFile)link).Load(path, STGM_READ); ((IPersistFile)link).Load(path, STGM_READ | STGM_SHARE_DENY_NONE | STGM_TRANSACTED);
} }
catch (System.IO.FileNotFoundException ex) catch (System.IO.FileNotFoundException ex)
{ {
Log.Exception("Path could not be retrieved", ex, GetType(), path); Log.Exception("Path could not be retrieved " + path, ex, GetType(), path);
Marshal.ReleaseComObject(link);
return string.Empty;
}
catch (System.Exception ex)
{
Log.Exception("Exception loading path " + path, ex, GetType(), path);
Marshal.ReleaseComObject(link);
return string.Empty; return string.Empty;
} }