From 8a07b7b5600e00926b4585e85ed00702223b5f7b Mon Sep 17 00:00:00 2001
From: Mike Griese <migrie@microsoft.com>
Date: Tue, 13 May 2025 12:24:26 -0500
Subject: [PATCH] Bump our telemetry package version (#39388)

Data collection is hard.

Our internal package, which was last bumped around August 2024,
mistakenly changed a load bearing string from `ETW_GROUP` to
`MSPG_GROUP`. The former sets the ETW group id. The later does nothing.

This PR represents bumping our dependency to the version with the fix.

Considering that none of our data for CmdPal worked anyways, I took the
opportunity to rename a bunch of our events that had totally generic
names.

Closes #38704

re: #38032
regressed around: #34078
---
 .pipelines/packages.config                                  | 2 +-
 .../cmdpal/Microsoft.CmdPal.UI/Events/BeginInvoke.cs        | 6 +++++-
 src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ColdLaunch.cs | 6 +++++-
 src/modules/cmdpal/Microsoft.CmdPal.UI/Events/OpenPage.cs   | 3 ++-
 .../cmdpal/Microsoft.CmdPal.UI/Events/ReactivateInstance.cs | 6 +++++-
 5 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/.pipelines/packages.config b/.pipelines/packages.config
index 43fa34c91c..c4bca409f9 100644
--- a/.pipelines/packages.config
+++ b/.pipelines/packages.config
@@ -1,4 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="Microsoft.PowerToys.Telemetry" version="2.0.2" />
+  <package id="Microsoft.PowerToys.Telemetry" version="2.0.3" />
 </packages>
diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/BeginInvoke.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/BeginInvoke.cs
index d6e8fcd423..37659cbd31 100644
--- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/BeginInvoke.cs
+++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/BeginInvoke.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Diagnostics.Tracing;
-using Microsoft.CommandPalette.Extensions;
 using Microsoft.PowerToys.Telemetry;
 using Microsoft.PowerToys.Telemetry.Events;
 
@@ -13,4 +12,9 @@ namespace Microsoft.CmdPal.UI.Events;
 public class BeginInvoke : EventBase, IEvent
 {
     public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public BeginInvoke()
+    {
+        EventName = "CmdPal_BeginInvoke";
+    }
 }
diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ColdLaunch.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ColdLaunch.cs
index cc85a4ec3c..0da950d5c4 100644
--- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ColdLaunch.cs
+++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ColdLaunch.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Diagnostics.Tracing;
-using Microsoft.CommandPalette.Extensions;
 using Microsoft.PowerToys.Telemetry;
 using Microsoft.PowerToys.Telemetry.Events;
 
@@ -13,4 +12,9 @@ namespace Microsoft.CmdPal.UI.Events;
 public class ColdLaunch : EventBase, IEvent
 {
     public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public ColdLaunch()
+    {
+        EventName = "CmdPal_ColdLaunch";
+    }
 }
diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/OpenPage.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/OpenPage.cs
index 6510c06651..8ff7107104 100644
--- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/OpenPage.cs
+++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/OpenPage.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Diagnostics.Tracing;
-using Microsoft.CommandPalette.Extensions;
 using Microsoft.PowerToys.Telemetry;
 using Microsoft.PowerToys.Telemetry.Events;
 
@@ -17,6 +16,8 @@ public class OpenPage : EventBase, IEvent
     public OpenPage(int pageDepth)
     {
         PageDepth = pageDepth;
+
+        EventName = "CmdPal_OpenPage";
     }
 
     public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ReactivateInstance.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ReactivateInstance.cs
index 7387881f26..c5f70d2905 100644
--- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ReactivateInstance.cs
+++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ReactivateInstance.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Diagnostics.Tracing;
-using Microsoft.CommandPalette.Extensions;
 using Microsoft.PowerToys.Telemetry;
 using Microsoft.PowerToys.Telemetry.Events;
 
@@ -13,4 +12,9 @@ namespace Microsoft.CmdPal.UI.Events;
 public class ReactivateInstance : EventBase, IEvent
 {
     public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public ReactivateInstance()
+    {
+        EventName = "CmdPal_ReactivateInstance";
+    }
 }