From 801fad09ba7a6f7da5c1137d2e8a9b574776996a Mon Sep 17 00:00:00 2001 From: Kai Tao <69313318+vanzue@users.noreply.github.com> Date: Mon, 28 Jul 2025 19:53:41 -0700 Subject: [PATCH] Fix a settings crash due to incompatible property name (#40854) ## Summary of the Pull Request ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder This pull request introduces a minor update to the `ZoomItProperties` class in the `Settings.UI.Library` project. The change adds a new property, `AnimateZoom`, with a JSON property name annotation. * [`src/settings-ui/Settings.UI.Library/ZoomItProperties.cs`](diffhunk://#diff-2cd3f90110c7ba387a449d246b4949c3f6cf7f746865f327dbb70f01feeb0cf1R81): Added a new `BoolProperty` named `AnimateZoom` with a `[JsonPropertyName("AnimnateZoom")]` attribute. - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed Locally checked, no broken any more --- src/settings-ui/Settings.UI.Library/ZoomItProperties.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs b/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs index 26d82dbbfe..aaaa80f9f7 100644 --- a/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs +++ b/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs @@ -78,6 +78,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library public BoolProperty ShowTrayIcon { get; set; } + [JsonPropertyName("AnimnateZoom")] public BoolProperty AnimateZoom { get; set; } public IntProperty ZoominSliderLevel { get; set; }