Update settings logic for file explorer preview (#1651)

* Update logic of settings for File Explorer preview

* Updated logic and added Unit tests

* Fix compiler warning for powerpreview project

* Update enable logic

* Update Disable logic

* Updated telemetry events
This commit is contained in:
udit3333
2020-03-24 16:23:27 -07:00
committed by GitHub
parent badcccab76
commit 7f1a854769
9 changed files with 251 additions and 247 deletions

View File

@@ -29,24 +29,40 @@ void Trace::UnregisterProvider()
TraceLoggingUnregister(g_hProvider);
}
void Trace::PreviewHandlerEnabled(bool enabled, LPCWSTR previewHandlerName)
void Trace::EnabledPowerPreview(bool enabled)
{
TraceLoggingWrite(
g_hProvider,
"PowerPreview_TweakUISettings_Enabled",
TraceLoggingWideString(previewHandlerName, "PreviewHanlder_FileType"),
"PowerPreview_Enabled",
TraceLoggingBoolean(enabled, "Enabled"),
ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
TraceLoggingBoolean(TRUE, "UTCReplace_AppSessionGuid"),
TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
}
void Trace::PowerPreviewSettingsUpDateFailed(LPCWSTR SettingsName)
void Trace::PowerPreviewSettingsUpdated(LPCWSTR SettingsName, bool oldState, bool newState, bool globalState)
{
TraceLoggingWrite(
g_hProvider,
"PowerPreview_TweakUISettings_SuccesfullyUpdatedSettings",
TraceLoggingWideString(SettingsName, "Previewer_Settings_Name"),
TraceLoggingBoolean(oldState, "Old_Settings_State"),
TraceLoggingBoolean(newState, "New_Settings_State"),
TraceLoggingBoolean(globalState, "Global_File_Explorer_Settings_State"),
ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
TraceLoggingBoolean(TRUE, "UTCReplace_AppSessionGuid"),
TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
}
void Trace::PowerPreviewSettingsUpdateFailed(LPCWSTR SettingsName, bool oldState, bool newState, bool globalState)
{
TraceLoggingWrite(
g_hProvider,
"PowerPreview_TweakUISettings_FailedUpdatingSettings",
TraceLoggingWideString(SettingsName, "ExceptionMessage"),
TraceLoggingWideString(SettingsName, "Previewer_Settings_Name"),
TraceLoggingBoolean(oldState, "Old_Settings_State"),
TraceLoggingBoolean(newState, "New_Settings_State"),
TraceLoggingBoolean(globalState, "Global_File_Explorer_Settings_State"),
ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
TraceLoggingBoolean(TRUE, "UTCReplace_AppSessionGuid"),
TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));