mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-03 09:46:54 +02:00
CmdPal: Manually iterate package metadata tags to prevent exceptions (#45502)
## Summary of the Pull Request This PR fixes an error that occurred when reading tags for the selected package in WinGet extensions when AOTed. The issue was caused by using LINQ over a WinRT proxy; this has been replaced with manual iteration over the collection to avoid the failure. The exception is now caught and logged as a warning by #44757. <img width="863" height="500" alt="image" src="https://github.com/user-attachments/assets/6e08e674-532e-4e9b-a5c6-f7e1c224c341" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #44487 - [x] Closes: #44486 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
This commit is contained in:
@@ -171,17 +171,24 @@ public partial class InstallPackageListItem : ListItem
|
||||
{
|
||||
if (metadata.Tags.Count > 0)
|
||||
{
|
||||
var tags = new ITag[metadata.Tags.Count];
|
||||
for (var i = 0; i < metadata.Tags.Count; i++)
|
||||
{
|
||||
var tag = new Tag(metadata.Tags[i]);
|
||||
tags[i] = tag;
|
||||
}
|
||||
|
||||
DetailsElement pair = new()
|
||||
{
|
||||
Key = "Tags",
|
||||
Data = new DetailsTags() { Tags = metadata.Tags.Select(t => new Tag(t)).ToArray() },
|
||||
Data = new DetailsTags { Tags = tags },
|
||||
};
|
||||
detailsElements.Add(pair);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
Logger.LogWarning($"Failed to retrieve tags from metadata: {ex.Message}");
|
||||
Logger.LogWarning($"Failed to retrieve tags from metadata: {ex}");
|
||||
}
|
||||
|
||||
return detailsElements;
|
||||
|
||||
Reference in New Issue
Block a user