From 76ab389e8826c61cc6085ccce50887feea2ae4b8 Mon Sep 17 00:00:00 2001 From: martinchrzan Date: Mon, 3 Aug 2020 22:03:00 +0200 Subject: [PATCH] Fixing potentially infinite loop with logs in Color Picker (#5558) --- src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs | 2 +- .../colorPicker/ColorPickerUI/Settings/UserSettings.cs | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs b/src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs index 5d665a83a2..2755745c49 100644 --- a/src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs +++ b/src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs @@ -64,7 +64,7 @@ namespace ColorPicker.Helpers var methodName = stackTrace.GetFrame(3)?.GetMethod(); var className = methodName?.DeclaringType.Name; - return "[Method]: " + methodName.Name + " [Class]: " + className; + return "[Method]: " + methodName?.Name + " [Class]: " + className; } } } diff --git a/src/modules/colorPicker/ColorPickerUI/Settings/UserSettings.cs b/src/modules/colorPicker/ColorPickerUI/Settings/UserSettings.cs index 13124522a4..1edc91327f 100644 --- a/src/modules/colorPicker/ColorPickerUI/Settings/UserSettings.cs +++ b/src/modules/colorPicker/ColorPickerUI/Settings/UserSettings.cs @@ -78,7 +78,13 @@ namespace ColorPicker.Settings } catch (Exception ex) { + if (retryCount > MaxNumberOfRetry) + { + retry = false; + } + Logger.LogError("Failed to read changed settings", ex); + Thread.Sleep(500); } } };