mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-03 01:36:31 +02:00
[CmdPal] Fix keyboard navigation double Tab stop in details panel (#46346)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Fixes a keyboard accessibility issue in Command Palette where Tab navigation would stop twice on container elements in the details panel instead of navigating to details panel and then directly to interactive controls. The items in the Details Panel aren't really interactable anyways (the AllAppsPage & ClipBoard History just displays details) This is part of the a11y bug batch. User Impact: Keyboard-only and assistive-technology users may experience confusion, extra navigation effort, and reduced efficiency when interacting with the Search Apps pane. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed https://github.com/user-attachments/assets/0d5f0f20-040c-4d22-b769-3fe318c66697
This commit is contained in:
committed by
GitHub
parent
5792d32d32
commit
75a0fe1d2f
@@ -85,7 +85,8 @@
|
|||||||
HorizontalAlignment="Stretch"
|
HorizontalAlignment="Stretch"
|
||||||
HorizontalContentAlignment="Left"
|
HorizontalContentAlignment="Left"
|
||||||
Click="Command_Click"
|
Click="Command_Click"
|
||||||
Style="{StaticResource SubtleButtonStyle}">
|
Style="{StaticResource SubtleButtonStyle}"
|
||||||
|
UseSystemFocusVisuals="{StaticResource UseSystemFocusVisuals}">
|
||||||
<StackPanel VerticalAlignment="Center" Orientation="Horizontal">
|
<StackPanel VerticalAlignment="Center" Orientation="Horizontal">
|
||||||
<cpcontrols:IconBox
|
<cpcontrols:IconBox
|
||||||
Width="16"
|
Width="16"
|
||||||
@@ -110,6 +111,7 @@
|
|||||||
Padding="0"
|
Padding="0"
|
||||||
Command="{x:Bind NavigateCommand, Mode=OneWay}"
|
Command="{x:Bind NavigateCommand, Mode=OneWay}"
|
||||||
NavigateUri="{x:Bind Link, Mode=OneWay}"
|
NavigateUri="{x:Bind Link, Mode=OneWay}"
|
||||||
|
UseSystemFocusVisuals="{StaticResource UseSystemFocusVisuals}"
|
||||||
Visibility="{x:Bind IsLink, Mode=OneWay}">
|
Visibility="{x:Bind IsLink, Mode=OneWay}">
|
||||||
<TextBlock Text="{x:Bind Text, Mode=OneWay}" TextWrapping="Wrap" />
|
<TextBlock Text="{x:Bind Text, Mode=OneWay}" TextWrapping="Wrap" />
|
||||||
</HyperlinkButton>
|
</HyperlinkButton>
|
||||||
@@ -119,6 +121,7 @@
|
|||||||
<StackPanel Orientation="Vertical" Spacing="4">
|
<StackPanel Orientation="Vertical" Spacing="4">
|
||||||
<TextBlock Style="{StaticResource DetailKeyTextBlockStyle}" Text="{x:Bind Key, Mode=OneWay}" />
|
<TextBlock Style="{StaticResource DetailKeyTextBlockStyle}" Text="{x:Bind Key, Mode=OneWay}" />
|
||||||
<ItemsControl
|
<ItemsControl
|
||||||
|
IsTabStop="False"
|
||||||
ItemTemplate="{StaticResource CommandTemplate}"
|
ItemTemplate="{StaticResource CommandTemplate}"
|
||||||
ItemsSource="{x:Bind Commands, Mode=OneWay}"
|
ItemsSource="{x:Bind Commands, Mode=OneWay}"
|
||||||
Visibility="{x:Bind HasCommands, Mode=OneWay}" />
|
Visibility="{x:Bind HasCommands, Mode=OneWay}" />
|
||||||
@@ -142,6 +145,7 @@
|
|||||||
<StackPanel Orientation="Vertical" Spacing="4">
|
<StackPanel Orientation="Vertical" Spacing="4">
|
||||||
<TextBlock Style="{StaticResource DetailKeyTextBlockStyle}" Text="{x:Bind Key, Mode=OneWay}" />
|
<TextBlock Style="{StaticResource DetailKeyTextBlockStyle}" Text="{x:Bind Key, Mode=OneWay}" />
|
||||||
<ItemsControl
|
<ItemsControl
|
||||||
|
IsTabStop="False"
|
||||||
ItemTemplate="{StaticResource TagTemplate}"
|
ItemTemplate="{StaticResource TagTemplate}"
|
||||||
ItemsSource="{x:Bind Tags, Mode=OneWay}"
|
ItemsSource="{x:Bind Tags, Mode=OneWay}"
|
||||||
Visibility="{x:Bind HasTags, Mode=OneWay}">
|
Visibility="{x:Bind HasTags, Mode=OneWay}">
|
||||||
@@ -394,10 +398,17 @@
|
|||||||
Margin="4"
|
Margin="4"
|
||||||
HorizontalAlignment="Stretch"
|
HorizontalAlignment="Stretch"
|
||||||
ui:VisualExtensions.NormalizedCenterPoint="0.5,0.5"
|
ui:VisualExtensions.NormalizedCenterPoint="0.5,0.5"
|
||||||
|
AutomationProperties.AccessibilityView="Content"
|
||||||
|
AutomationProperties.HelpText="{x:Bind ViewModel.Details.Body, Mode=OneWay}"
|
||||||
|
AutomationProperties.LandmarkType="Custom"
|
||||||
|
AutomationProperties.LocalizedLandmarkType="Details"
|
||||||
|
AutomationProperties.Name="{x:Bind ViewModel.Details.Title, Mode=OneWay}"
|
||||||
Background="{ThemeResource CardBackgroundFillColorDefaultBrush}"
|
Background="{ThemeResource CardBackgroundFillColorDefaultBrush}"
|
||||||
BorderBrush="{ThemeResource CmdPal.DividerStrokeColorDefaultBrush}"
|
BorderBrush="{ThemeResource CmdPal.DividerStrokeColorDefaultBrush}"
|
||||||
BorderThickness="1"
|
BorderThickness="1"
|
||||||
CornerRadius="{StaticResource ControlCornerRadius}"
|
CornerRadius="{StaticResource ControlCornerRadius}"
|
||||||
|
IsTabStop="True"
|
||||||
|
UseSystemFocusVisuals="{StaticResource UseSystemFocusVisuals}"
|
||||||
Visibility="Collapsed">
|
Visibility="Collapsed">
|
||||||
<animations:Implicit.ShowAnimations>
|
<animations:Implicit.ShowAnimations>
|
||||||
<animations:OpacityAnimation
|
<animations:OpacityAnimation
|
||||||
@@ -450,12 +461,14 @@
|
|||||||
Margin="0,4,0,24"
|
Margin="0,4,0,24"
|
||||||
Background="Transparent"
|
Background="Transparent"
|
||||||
Config="{StaticResource DefaultMarkdownConfig}"
|
Config="{StaticResource DefaultMarkdownConfig}"
|
||||||
|
IsTabStop="False"
|
||||||
Text="{x:Bind ViewModel.Details.Body, Mode=OneWay}"
|
Text="{x:Bind ViewModel.Details.Body, Mode=OneWay}"
|
||||||
UseEmphasisExtras="True"
|
UseEmphasisExtras="True"
|
||||||
UsePipeTables="True" />
|
UsePipeTables="True" />
|
||||||
|
|
||||||
<ItemsRepeater
|
<ItemsRepeater
|
||||||
Grid.Row="3"
|
Grid.Row="3"
|
||||||
|
IsTabStop="False"
|
||||||
ItemTemplate="{StaticResource DetailsDataTemplateSelector}"
|
ItemTemplate="{StaticResource DetailsDataTemplateSelector}"
|
||||||
ItemsSource="{x:Bind ViewModel.Details.Metadata, Mode=OneWay}">
|
ItemsSource="{x:Bind ViewModel.Details.Metadata, Mode=OneWay}">
|
||||||
<ItemsRepeater.Layout>
|
<ItemsRepeater.Layout>
|
||||||
|
|||||||
Reference in New Issue
Block a user