From e68999ea0d25750891886010def079c977b873cd Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:39:10 -0400 Subject: [PATCH 01/37] spelling: adjacent Signed-off-by: Josh Soref --- .../fancyzones/editor/FancyZonesEditor/GridDragHandles.cs | 8 ++++---- .../fancyzones/editor/FancyZonesEditor/GridEditor.xaml.cs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/GridDragHandles.cs b/src/modules/fancyzones/editor/FancyZonesEditor/GridDragHandles.cs index 43155a90ed..c126f6c1df 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/GridDragHandles.cs +++ b/src/modules/fancyzones/editor/FancyZonesEditor/GridDragHandles.cs @@ -461,10 +461,10 @@ namespace FancyZonesEditor _resizers.Clear(); } - public bool HasSnappedNonAdjascentResizers(GridResizer resizer) + public bool HasSnappedNonAdjacentResizers(GridResizer resizer) { /** - * Resizers between zones 0,1 and 4,5 are snapped to each other and not adjascent. + * Resizers between zones 0,1 and 4,5 are snapped to each other and not adjacent. * ------------------------------ * | 0 | 1 | * ------------------------------ @@ -473,7 +473,7 @@ namespace FancyZonesEditor * | 4 | 5 | * ------------------------------ * - * Resizers between zones 0,1 and 2,3 are snapped to each other and adjascent. + * Resizers between zones 0,1 and 2,3 are snapped to each other and adjacent. * ------------------------------ * | 0 | 1 | * ------------------------------ @@ -484,7 +484,7 @@ namespace FancyZonesEditor * * Vertical resizers should have same StartColumn and different StartRow. * Horizontal resizers should have same StartRow and different StartColumn. - * Difference between rows or colums should be more than 1. + * Difference between rows or columns should be more than 1. */ foreach (GridResizer r in _resizers) { diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/GridEditor.xaml.cs b/src/modules/fancyzones/editor/FancyZonesEditor/GridEditor.xaml.cs index cd1ee13dac..9b71ede841 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/GridEditor.xaml.cs +++ b/src/modules/fancyzones/editor/FancyZonesEditor/GridEditor.xaml.cs @@ -400,7 +400,7 @@ namespace FancyZonesEditor GridData.ResizeInfo resizeInfo = _data.CalculateResizeInfo(resizer, delta); if (resizeInfo.IsResizeAllowed) { - if (_dragHandles.HasSnappedNonAdjascentResizers(resizer)) + if (_dragHandles.HasSnappedNonAdjacentResizers(resizer)) { double spacing = 0; Settings settings = ((App)Application.Current).ZoneSettings; From d3771707474b8f34fc1c2a9762cbc82eae9e1ea0 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:39:14 -0400 Subject: [PATCH 02/37] spelling: bootstrapper Signed-off-by: Josh Soref --- doc/devdocs/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/devdocs/readme.md b/doc/devdocs/readme.md index cd873fda77..7ecd9bd2a4 100644 --- a/doc/devdocs/readme.md +++ b/doc/devdocs/readme.md @@ -97,7 +97,7 @@ Our installer is two parts, an EXE and an MSI. The EXE contains the MSI and han - From the `installer` folder open `PowerToysSetup.sln` in Visual Studio, in the `Solutions Configuration` drop-down menu select `Release`, from the `Build` menu choose `Build Solution`. - The resulting `PowerToysSetup.msi` installer will be available in the `installer\PowerToysSetup\x64\Release\` folder. -### Compiling Bootstraper Installer (.EXE) +### Compiling Bootstrapper Installer (.EXE) - MSI Installer needs to be built in release mode - Build `PowerToysBootstrapper` solution (`installer\PowerToysBootstrapper\`) From 1888a4cf9926561f16eb96b2be901348ee3cba18 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:39:18 -0400 Subject: [PATCH 03/37] spelling: catalog Signed-off-by: Josh Soref --- .../Microsoft.Plugin.Program/Storage/PackageRepository.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs index 9d787cc847..7c4b4e1f21 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs @@ -14,7 +14,7 @@ namespace Microsoft.Plugin.Program.Storage { /// /// A repository for storing packaged applications such as UWP apps or appx packaged desktop apps. - /// This repository will also monitor for changes to the PackageCatelog and update the repository accordingly + /// This repository will also monitor for changes to the PackageCatalog and update the repository accordingly /// internal class PackageRepository : ListRepository, IProgramRepository { From 37dbcb91cd640a5555f3e22630833d70639facc7 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:40:32 -0400 Subject: [PATCH 04/37] spelling: coming Signed-off-by: Josh Soref --- src/modules/fancyzones/lib/Settings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/fancyzones/lib/Settings.cpp b/src/modules/fancyzones/lib/Settings.cpp index c696b263d3..b782d926af 100644 --- a/src/modules/fancyzones/lib/Settings.cpp +++ b/src/modules/fancyzones/lib/Settings.cpp @@ -158,7 +158,7 @@ IFACEMETHODIMP_(void) FancyZonesSettings::CallCustomAction(PCWSTR action) noexce } catch (...) { - // Currently only custom action comming from main PowerToys window is request to launch editor. + // Currently only custom action coming from main PowerToys window is request to launch editor. // If new custom action is added, error message need to be modified. std::wstring errorMessage = GET_RESOURCE_STRING(IDS_FANCYZONES_EDITOR_LAUNCH_ERROR) + L" " + NonLocalizable::PowerToysIssuesURL; MessageBox(NULL, From 791b0cb90488250b8c6e255265047c54601f805b Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:40:36 -0400 Subject: [PATCH 05/37] spelling: consistency Signed-off-by: Josh Soref --- src/core/Microsoft.PowerToys.Settings.UI/Interop.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/Microsoft.PowerToys.Settings.UI/Interop.cs b/src/core/Microsoft.PowerToys.Settings.UI/Interop.cs index 2ad765b37f..3a74a233f4 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI/Interop.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI/Interop.cs @@ -23,7 +23,7 @@ namespace Microsoft.PowerToys.Settings.UI } } - [System.Diagnostics.CodeAnalysis.SuppressMessage("StyleCop.CSharp.NamingRules", "SA1310:Field names should not contain underscore", Justification = "Interop naming consistancy")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("StyleCop.CSharp.NamingRules", "SA1310:Field names should not contain underscore", Justification = "Interop naming consistency")] public const int SW_HIDE = 0; } } From 468e08dfa7608b336de6fb81916c22f86fb47d25 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:40:40 -0400 Subject: [PATCH 06/37] spelling: constructor Signed-off-by: Josh Soref --- doc/devdocs/modules/launcher/plugins/overview.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/devdocs/modules/launcher/plugins/overview.md b/doc/devdocs/modules/launcher/plugins/overview.md index ea6233c6c4..924d97fcde 100644 --- a/doc/devdocs/modules/launcher/plugins/overview.md +++ b/doc/devdocs/modules/launcher/plugins/overview.md @@ -5,7 +5,7 @@ The following basic functions are common to each of the plugins. They perform so Each plugin implements the `IPlugin` interface which comprises of the `Init()` and `Query()` functions. ### `Init` -- The `Init()` function initializes the context, storage and settings of each plugin. This is equivalent to a contructor and is the first function to be called in the `Main.cs` file for each plugin. +- The `Init()` function initializes the context, storage and settings of each plugin. This is equivalent to a constructor and is the first function to be called in the `Main.cs` file for each plugin. ### `Query` - For every query that the user enters into PT Run, the `PluginManager.cs` executes the `Query()` function in the `Main.cs` file corresponding to each Plugin. From a161a94241ebeecad2d52059f1a93033afafe5b2 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:40:44 -0400 Subject: [PATCH 07/37] spelling: correctly Signed-off-by: Josh Soref --- src/modules/launcher/Wox.Test/QueryBuilderTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/launcher/Wox.Test/QueryBuilderTest.cs b/src/modules/launcher/Wox.Test/QueryBuilderTest.cs index 2b99aea2bd..b3c50755c5 100644 --- a/src/modules/launcher/Wox.Test/QueryBuilderTest.cs +++ b/src/modules/launcher/Wox.Test/QueryBuilderTest.cs @@ -178,7 +178,7 @@ namespace Wox.Test } [Test] - public void QueryBuilderShouldSetTermsCorrentlyWhenCalled() + public void QueryBuilderShouldSetTermsCorrectlyWhenCalled() { // Arrange string searchQuery = "abcd efgh"; From aa19430d52ed3ca393044254121ca8f6d474cdb9 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:40:48 -0400 Subject: [PATCH 08/37] spelling: directory Signed-off-by: Josh Soref --- .../Utilities/SystemIOProvider.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/Microsoft.PowerToys.Settings.UI.Library/Utilities/SystemIOProvider.cs b/src/core/Microsoft.PowerToys.Settings.UI.Library/Utilities/SystemIOProvider.cs index c650c5957e..8519f90319 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.Library/Utilities/SystemIOProvider.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.Library/Utilities/SystemIOProvider.cs @@ -10,8 +10,8 @@ namespace Microsoft.PowerToys.Settings.UI.Library.Utilities { public bool CreateDirectory(string path) { - var directioryInfo = Directory.CreateDirectory(path); - return directioryInfo != null; + var directoryInfo = Directory.CreateDirectory(path); + return directoryInfo != null; } public void DeleteDirectory(string path) From beab8d2deb856e4b5f4feaf6caa0ed6a7b55aa9a Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:40:53 -0400 Subject: [PATCH 09/37] spelling: essentially Signed-off-by: Josh Soref --- tools/FancyZones_DrawLayoutTest/FancyZones_DrawLayoutTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/FancyZones_DrawLayoutTest/FancyZones_DrawLayoutTest.cpp b/tools/FancyZones_DrawLayoutTest/FancyZones_DrawLayoutTest.cpp index 679022b870..0547c99a19 100644 --- a/tools/FancyZones_DrawLayoutTest/FancyZones_DrawLayoutTest.cpp +++ b/tools/FancyZones_DrawLayoutTest/FancyZones_DrawLayoutTest.cpp @@ -76,7 +76,7 @@ int GetHighlightedZoneIdx(const std::vector& zones, const POINT& cursorPos void ShowZoneWindow() { - // InvalidateRect will esentially send WM_PAINT to main window. + // InvalidateRect will essentially send WM_PAINT to main window. UINT flags = SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE; SetWindowPos(mainWindow, nullptr, 0, 0, 0, 0, flags); From 4961601b842501eed84c17be9d4e618fc90d970b Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:01 -0400 Subject: [PATCH 10/37] spelling: exception Signed-off-by: Josh Soref --- .../Plugins/Microsoft.Plugin.Indexer/ContextMenuLoader.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/ContextMenuLoader.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/ContextMenuLoader.cs index 820fc2fc91..419f27391f 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/ContextMenuLoader.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/ContextMenuLoader.cs @@ -117,7 +117,7 @@ namespace Microsoft.Plugin.Indexer } // Function to add the context menu item to run as admin - [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "We want to keep the process alive, and instead log the exeption message")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "We want to keep the process alive, and instead log the exception message")] private static ContextMenuResult CreateRunAsAdminContextMenu(SearchResult record) { return new ContextMenuResult From e889e1a5c61dae19a0c809708444a5650f73139d Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:05 -0400 Subject: [PATCH 11/37] spelling: experimental Signed-off-by: Josh Soref --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 85164f8101..976b51acf3 100644 --- a/README.md +++ b/README.md @@ -109,7 +109,7 @@ WinGet install powertoys Install the [pre-release experimental version of PowerToys][github-prerelease-link] to try out this version. It includes all improvements from 0.23 in addition to the Video conference utility. Click on `Assets` to show the files available in the release and then download the .exe installer. -**Note:** We'll have 0.26 Experiemental out in the first week of November 2020. +**Note:** We'll have 0.26 Experimental out in the first week of November 2020. ### Other install methods From 034da586c89c6bad08c231c4388d0d6354420309 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:09 -0400 Subject: [PATCH 12/37] spelling: explicitly Signed-off-by: Josh Soref --- .../Microsoft.PowerToys.Settings.UI.Runner/MainWindow.xaml.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/Microsoft.PowerToys.Settings.UI.Runner/MainWindow.xaml.cs b/src/core/Microsoft.PowerToys.Settings.UI.Runner/MainWindow.xaml.cs index d2353b0ced..67cec70568 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.Runner/MainWindow.xaml.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.Runner/MainWindow.xaml.cs @@ -88,7 +88,7 @@ namespace Microsoft.PowerToys.Settings.UI.Runner shellPage.Refresh(); } - // XAML Islands: If the window is open, explicity force it to be shown to solve the blank dialog issue https://github.com/microsoft/PowerToys/issues/3384 + // XAML Islands: If the window is open, explicitly force it to be shown to solve the blank dialog issue https://github.com/microsoft/PowerToys/issues/3384 if (isOpen) { Show(); From 27bb96b61cdc641c2633f011f81189a8a9bbbd79 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:14 -0400 Subject: [PATCH 13/37] spelling: inferred Signed-off-by: Josh Soref --- .../ProgramArgumentParser/ProgramArgumentParserTests.cs | 2 +- src/modules/launcher/Plugins/Microsoft.Plugin.Program/Main.cs | 2 +- ...rogramArgumentParser.cs => InferredProgramArgumentParser.cs} | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename src/modules/launcher/Plugins/Microsoft.Plugin.Program/ProgramArgumentParser/{InferedProgramArgumentParser.cs => InferredProgramArgumentParser.cs} (95%) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/ProgramArgumentParser/ProgramArgumentParserTests.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/ProgramArgumentParser/ProgramArgumentParserTests.cs index 06179a493b..8420568d54 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/ProgramArgumentParser/ProgramArgumentParserTests.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/ProgramArgumentParser/ProgramArgumentParserTests.cs @@ -28,7 +28,7 @@ namespace Microsoft.Plugin.Program.UnitTests.ProgramArgumentParser var argumentParsers = new IProgramArgumentParser[] { new DoubleDashProgramArgumentParser(), - new InferedProgramArgumentParser(), + new InferredProgramArgumentParser(), new NoArgumentsArgumentParser(), }; diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Main.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Main.cs index 67b2dc78b3..1b875a19d1 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Main.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Main.cs @@ -26,7 +26,7 @@ namespace Microsoft.Plugin.Program private static readonly IProgramArgumentParser[] _programArgumentParsers = new IProgramArgumentParser[] { new DoubleDashProgramArgumentParser(), - new InferedProgramArgumentParser(), + new InferredProgramArgumentParser(), new NoArgumentsArgumentParser(), }; diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/ProgramArgumentParser/InferedProgramArgumentParser.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/ProgramArgumentParser/InferredProgramArgumentParser.cs similarity index 95% rename from src/modules/launcher/Plugins/Microsoft.Plugin.Program/ProgramArgumentParser/InferedProgramArgumentParser.cs rename to src/modules/launcher/Plugins/Microsoft.Plugin.Program/ProgramArgumentParser/InferredProgramArgumentParser.cs index b3aa16eb6f..faa41bf8e1 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/ProgramArgumentParser/InferedProgramArgumentParser.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/ProgramArgumentParser/InferredProgramArgumentParser.cs @@ -8,7 +8,7 @@ using Wox.Plugin; namespace Microsoft.Plugin.Program { - public class InferedProgramArgumentParser : IProgramArgumentParser + public class InferredProgramArgumentParser : IProgramArgumentParser { private static readonly Regex ArgumentPrefixRegex = new Regex("^(-|--|/)[a-zA-Z]+", RegexOptions.Compiled); From b0a584d5eec3f020e4b6aeb16ea4e3088adf25df Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:19 -0400 Subject: [PATCH 14/37] spelling: initialize Signed-off-by: Josh Soref --- src/runner/settings_window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runner/settings_window.cpp b/src/runner/settings_window.cpp index a6d0786672..aae24cac88 100644 --- a/src/runner/settings_window.cpp +++ b/src/runner/settings_window.cpp @@ -327,7 +327,7 @@ void run_settings_window() settings_isUserAnAdmin = L"false"; } - // create general settings file to initialze the settings file with installation configurations like : + // create general settings file to initialize the settings file with installation configurations like : // 1. Run on start up. PTSettingsHelper::save_general_settings(save_settings.to_json()); From 6c0efef967508f2dcd86d899ae6fe6a84cc8f76f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:23 -0400 Subject: [PATCH 15/37] spelling: intentionally Signed-off-by: Josh Soref --- .../launcher/Plugins/Microsoft.Plugin.Program/Programs/UWP.cs | 4 ++-- .../Microsoft.Plugin.Program/Programs/UWPApplication.cs | 4 ++-- .../Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs | 2 +- .../Storage/Win32ProgramRepository.cs | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWP.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWP.cs index 397ecb6a62..74c9c99a90 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWP.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWP.cs @@ -132,7 +132,7 @@ namespace Microsoft.Plugin.Program.Programs Version = PackageVersion.Unknown; } - [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentially keeping the process alive.")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentionally keeping the process alive.")] public static UWPApplication[] All() { var windows10 = new Version(10, 0); @@ -170,7 +170,7 @@ namespace Microsoft.Plugin.Program.Programs } } - [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentially keeping the process alive.")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentionally keeping the process alive.")] private static IEnumerable CurrentUserPackages() { var ps = PackageManagerWrapper.FindPackagesForCurrentUser(); diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs index 9ac90bfc64..59c6baed55 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs @@ -118,7 +118,7 @@ namespace Microsoft.Plugin.Program.Programs return result; } - [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentially keeping the process alive.")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentionally keeping the process alive.")] public List ContextMenus(string queryArguments, IPublicAPI api) { if (api == null) @@ -196,7 +196,7 @@ namespace Microsoft.Plugin.Program.Programs return contextMenus; } - [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentially keeping the process alive, and showing the user an error message")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentionally keeping the process alive, and showing the user an error message")] private async void Launch(IPublicAPI api, string queryArguments) { var appManager = new ApplicationActivationHelper.ApplicationActivationManager(); diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs index 6c5c49fb55..823cc9b26e 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs @@ -242,7 +242,7 @@ namespace Microsoft.Plugin.Program.Programs return result; } - [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentially keeping the process alive.")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentionally keeping the process alive.")] public List ContextMenus(string queryArguments, IPublicAPI api) { if (api == null) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs index 77ec40e3f2..0c847b76f0 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs @@ -88,7 +88,7 @@ namespace Microsoft.Plugin.Program.Storage } } - [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentially keeping the process alive>")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentionally keeping the process alive>")] private void OnAppRenamed(object sender, RenamedEventArgs e) { string oldPath = e.OldFullPath; From c2114d8e3b01d7b488cb3919807c44b9e904b30f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:27 -0400 Subject: [PATCH 16/37] spelling: maximum Signed-off-by: Josh Soref --- .../previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs b/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs index 52f52aa00c..74325b6164 100644 --- a/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs +++ b/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs @@ -31,7 +31,7 @@ namespace Microsoft.PowerToys.ThumbnailHandler.Svg public IStream Stream { get; private set; } /// - /// The maxium dimension (width or height) thumbnail we will generate. + /// The maximum dimension (width or height) thumbnail we will generate. /// private const uint MaxThumbnailSize = 10000; From 3bc040571572b96ca3fefbcc5acc2f263fdff46c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:33 -0400 Subject: [PATCH 17/37] spelling: milliseconds Signed-off-by: Josh Soref --- .../ColorPickerUI/Helpers/IThrottledActionInvoker.cs | 2 +- .../ColorPickerUI/Helpers/ThrottledActionInvoker.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/colorPicker/ColorPickerUI/Helpers/IThrottledActionInvoker.cs b/src/modules/colorPicker/ColorPickerUI/Helpers/IThrottledActionInvoker.cs index 6d1860e75d..678b40b3ed 100644 --- a/src/modules/colorPicker/ColorPickerUI/Helpers/IThrottledActionInvoker.cs +++ b/src/modules/colorPicker/ColorPickerUI/Helpers/IThrottledActionInvoker.cs @@ -8,6 +8,6 @@ namespace ColorPicker.Helpers { public interface IThrottledActionInvoker { - void ScheduleAction(Action action, int miliseconds); + void ScheduleAction(Action action, int milliseconds); } } diff --git a/src/modules/colorPicker/ColorPickerUI/Helpers/ThrottledActionInvoker.cs b/src/modules/colorPicker/ColorPickerUI/Helpers/ThrottledActionInvoker.cs index b27386f089..4d8cb8c42f 100644 --- a/src/modules/colorPicker/ColorPickerUI/Helpers/ThrottledActionInvoker.cs +++ b/src/modules/colorPicker/ColorPickerUI/Helpers/ThrottledActionInvoker.cs @@ -21,7 +21,7 @@ namespace ColorPicker.Helpers _timer.Tick += Timer_Tick; } - public void ScheduleAction(Action action, int miliseconds) + public void ScheduleAction(Action action, int milliseconds) { if (_timer.IsEnabled) { @@ -29,7 +29,7 @@ namespace ColorPicker.Helpers } _actionToRun = action; - _timer.Interval = new TimeSpan(0, 0, 0, 0, miliseconds); + _timer.Interval = new TimeSpan(0, 0, 0, 0, milliseconds); _timer.Start(); } From ade22bf48cda12d23158530ccee33b087b9b72e9 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:37 -0400 Subject: [PATCH 18/37] spelling: modifier Signed-off-by: Josh Soref --- src/modules/keyboardmanager/common/Helpers.cpp | 6 +++--- src/modules/keyboardmanager/common/Helpers.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/keyboardmanager/common/Helpers.cpp b/src/modules/keyboardmanager/common/Helpers.cpp index 3d82ccd95d..ee8483848f 100644 --- a/src/modules/keyboardmanager/common/Helpers.cpp +++ b/src/modules/keyboardmanager/common/Helpers.cpp @@ -270,13 +270,13 @@ namespace KeyboardManagerHelper return process_name; } - // Function to set key events for modifier keys: When shortcutToCompare is passed (non-empty shortcut), then the key event is sent only if both shortcut's don't have the same modifier key. When keyToBeReleased is passed (non-NULL), then the key event is sent if either the shortcuts don't have the same modfifier or if the shortcutToBeSent's modifier matches the keyToBeReleased + // Function to set key events for modifier keys: When shortcutToCompare is passed (non-empty shortcut), then the key event is sent only if both shortcut's don't have the same modifier key. When keyToBeReleased is passed (non-NULL), then the key event is sent if either the shortcuts don't have the same modifier or if the shortcutToBeSent's modifier matches the keyToBeReleased void SetModifierKeyEvents(const Shortcut& shortcutToBeSent, const ModifierKey& winKeyInvoked, LPINPUT keyEventArray, int& index, bool isKeyDown, ULONG_PTR extraInfoFlag, const Shortcut& shortcutToCompare, const DWORD& keyToBeReleased) { // If key down is to be sent, send in the order Win, Ctrl, Alt, Shift if (isKeyDown) { - // If shortcutToCompare is non-empty, then the key event is sent only if both shortcut's don't have the same modifier key. If keyToBeReleased is non-NULL, then the key event is sent if either the shortcuts don't have the same modfifier or if the shortcutToBeSent's modifier matches the keyToBeReleased + // If shortcutToCompare is non-empty, then the key event is sent only if both shortcut's don't have the same modifier key. If keyToBeReleased is non-NULL, then the key event is sent if either the shortcuts don't have the same modifier or if the shortcutToBeSent's modifier matches the keyToBeReleased if (shortcutToBeSent.GetWinKey(winKeyInvoked) != NULL && (shortcutToCompare.IsEmpty() || shortcutToBeSent.GetWinKey(winKeyInvoked) != shortcutToCompare.GetWinKey(winKeyInvoked)) && (keyToBeReleased == NULL || !shortcutToBeSent.CheckWinKey(keyToBeReleased))) { KeyboardManagerHelper::SetKeyEvent(keyEventArray, index, INPUT_KEYBOARD, (WORD)shortcutToBeSent.GetWinKey(winKeyInvoked), 0, extraInfoFlag); @@ -302,7 +302,7 @@ namespace KeyboardManagerHelper // If key up is to be sent, send in the order Shift, Alt, Ctrl, Win else { - // If shortcutToCompare is non-empty, then the key event is sent only if both shortcut's don't have the same modifier key. If keyToBeReleased is non-NULL, then the key event is sent if either the shortcuts don't have the same modfifier or if the shortcutToBeSent's modifier matches the keyToBeReleased + // If shortcutToCompare is non-empty, then the key event is sent only if both shortcut's don't have the same modifier key. If keyToBeReleased is non-NULL, then the key event is sent if either the shortcuts don't have the same modifier or if the shortcutToBeSent's modifier matches the keyToBeReleased if (shortcutToBeSent.GetShiftKey() != NULL && (shortcutToCompare.IsEmpty() || shortcutToBeSent.GetShiftKey() != shortcutToCompare.GetShiftKey() || shortcutToBeSent.CheckShiftKey(keyToBeReleased))) { KeyboardManagerHelper::SetKeyEvent(keyEventArray, index, INPUT_KEYBOARD, (WORD)shortcutToBeSent.GetShiftKey(), KEYEVENTF_KEYUP, extraInfoFlag); diff --git a/src/modules/keyboardmanager/common/Helpers.h b/src/modules/keyboardmanager/common/Helpers.h index 202b3a3af4..0bd550f246 100644 --- a/src/modules/keyboardmanager/common/Helpers.h +++ b/src/modules/keyboardmanager/common/Helpers.h @@ -96,7 +96,7 @@ namespace KeyboardManagerHelper // Function to return the executable name of the application in focus std::wstring GetCurrentApplication(bool keepPath); - // Function to set key events for modifier keys: When shortcutToCompare is passed (non-empty shortcut), then the key event is sent only if both shortcut's don't have the same modifier key. When keyToBeReleased is passed (non-NULL), then the key event is sent if either the shortcuts don't have the same modfifier or if the shortcutToBeSent's modifier matches the keyToBeReleased + // Function to set key events for modifier keys: When shortcutToCompare is passed (non-empty shortcut), then the key event is sent only if both shortcut's don't have the same modifier key. When keyToBeReleased is passed (non-NULL), then the key event is sent if either the shortcuts don't have the same modifier or if the shortcutToBeSent's modifier matches the keyToBeReleased void SetModifierKeyEvents(const Shortcut& shortcutToBeSent, const ModifierKey& winKeyInvoked, LPINPUT keyEventArray, int& index, bool isKeyDown, ULONG_PTR extraInfoFlag, const Shortcut& shortcutToCompare = Shortcut(), const DWORD& keyToBeReleased = NULL); // Function to filter the key codes for artificial key codes From ee6a9b3b6ba1bc97f98a339555af79753f687fed Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:41 -0400 Subject: [PATCH 19/37] spelling: occurred Signed-off-by: Josh Soref --- src/modules/fancyzones/lib/VirtualDesktopUtils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/fancyzones/lib/VirtualDesktopUtils.cpp b/src/modules/fancyzones/lib/VirtualDesktopUtils.cpp index fb0bf91318..5e7915d2d9 100644 --- a/src/modules/fancyzones/lib/VirtualDesktopUtils.cpp +++ b/src/modules/fancyzones/lib/VirtualDesktopUtils.cpp @@ -96,7 +96,7 @@ namespace VirtualDesktopUtils // Second fallback scenario is to get array of virtual desktops stored in registry, but not kept per // session. Note that we are taking first element from virtual desktop array, which is primary desktop. // If user has more than one virtual desktop, one of previous functions should return correct value, - // as desktop switch occured in current session. + // as desktop switch occurred in current session. else { std::vector ids{}; From 706bce07e5da14829395f307a6ce830b818ab7b6 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:45 -0400 Subject: [PATCH 20/37] spelling: parameters Signed-off-by: Josh Soref --- src/modules/launcher/Wox.Plugin/Properties/Resources.resx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/launcher/Wox.Plugin/Properties/Resources.resx b/src/modules/launcher/Wox.Plugin/Properties/Resources.resx index c5d21a23d5..609f1edd55 100644 --- a/src/modules/launcher/Wox.Plugin/Properties/Resources.resx +++ b/src/modules/launcher/Wox.Plugin/Properties/Resources.resx @@ -127,6 +127,6 @@ Unable to verify folders and files between {0} and {1} - paramaters: fromPath, toPath + parameters: fromPath, toPath \ No newline at end of file From 6e6ae6f1d315ef80ce7cafcbadb9ab72e01779dc Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:49 -0400 Subject: [PATCH 21/37] spelling: precedes Signed-off-by: Josh Soref --- src/modules/launcher/Wox.Infrastructure/StringMatcher.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs b/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs index 0e39c31779..6edc673adc 100644 --- a/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs +++ b/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs @@ -167,7 +167,7 @@ namespace Wox.Infrastructure return new MatchResult(false, UserSettingSearchPrecision); } - // To get the index of the closest space which preceeds the first matching index + // To get the index of the closest space which precedes the first matching index private static int CalculateClosestSpaceIndex(List spaceIndices, int firstMatchIndex) { if (spaceIndices.Count == 0) From c72ed776328dde2caed3cfef3c8a82ecd6f9020c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:54 -0400 Subject: [PATCH 22/37] spelling: recommended Signed-off-by: Josh Soref --- src/codeAnalysis/Rules.ruleset | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/codeAnalysis/Rules.ruleset b/src/codeAnalysis/Rules.ruleset index 98a7888fff..2b106a9730 100644 --- a/src/codeAnalysis/Rules.ruleset +++ b/src/codeAnalysis/Rules.ruleset @@ -1,5 +1,5 @@  - + From 9c6c7a82cb997d1853b28a1e98a01afd180fa77f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:41:59 -0400 Subject: [PATCH 23/37] spelling: registry Signed-off-by: Josh Soref --- .../launcher/Plugins/Microsoft.Plugin.Uri/Main.cs | 10 +++++----- .../{RegisteryWrapper.cs => RegistryWrapper.cs} | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) rename src/modules/launcher/Plugins/Microsoft.Plugin.Uri/{RegisteryWrapper.cs => RegistryWrapper.cs} (90%) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs index 35262b2011..0d9aac4552 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs @@ -22,7 +22,7 @@ namespace Microsoft.Plugin.Uri private readonly PluginJsonStorage _storage; private bool _disposed; private UriSettings _uriSettings; - private RegisteryWrapper _registeryWrapper; + private RegistryWrapper _registryWrapper; public Main() { @@ -30,7 +30,7 @@ namespace Microsoft.Plugin.Uri _uriSettings = _storage.Load(); _uriParser = new ExtendedUriParser(); _uriResolver = new UriResolver(); - _registeryWrapper = new RegisteryWrapper(); + _registryWrapper = new RegistryWrapper(); } public string BrowserIconPath { get; set; } @@ -109,14 +109,14 @@ namespace Microsoft.Plugin.Uri { try { - var progId = _registeryWrapper.GetRegistryValue("HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\Shell\\Associations\\UrlAssociations\\http\\UserChoice", "ProgId"); + var progId = _registryWrapper.GetRegistryValue("HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\Shell\\Associations\\UrlAssociations\\http\\UserChoice", "ProgId"); var programLocation = // Resolve App Icon (UWP) - _registeryWrapper.GetRegistryValue("HKEY_CLASSES_ROOT\\" + progId + "\\Application", "ApplicationIcon") + _registryWrapper.GetRegistryValue("HKEY_CLASSES_ROOT\\" + progId + "\\Application", "ApplicationIcon") // Resolves default file association icon (UWP + Normal) - ?? _registeryWrapper.GetRegistryValue("HKEY_CLASSES_ROOT\\" + progId + "\\DefaultIcon", null); + ?? _registryWrapper.GetRegistryValue("HKEY_CLASSES_ROOT\\" + progId + "\\DefaultIcon", null); // "Handles 'Indirect Strings' (UWP programs)" if (programLocation.StartsWith("@", StringComparison.Ordinal)) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/RegisteryWrapper.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/RegistryWrapper.cs similarity index 90% rename from src/modules/launcher/Plugins/Microsoft.Plugin.Uri/RegisteryWrapper.cs rename to src/modules/launcher/Plugins/Microsoft.Plugin.Uri/RegistryWrapper.cs index 86993799ae..2aad1b5412 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/RegisteryWrapper.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/RegistryWrapper.cs @@ -7,7 +7,7 @@ using Microsoft.Win32; namespace Microsoft.Plugin.Uri { - public class RegisteryWrapper : IRegistryWrapper + public class RegistryWrapper : IRegistryWrapper { public string GetRegistryValue(string registryLocation, string valueName) { From 054ab88ef16bbd52e02987e078b03b0e1de9a366 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:03 -0400 Subject: [PATCH 24/37] spelling: rendering Signed-off-by: Josh Soref --- .../previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs b/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs index 74325b6164..7f7c29f197 100644 --- a/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs +++ b/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs @@ -38,7 +38,7 @@ namespace Microsoft.PowerToys.ThumbnailHandler.Svg /// /// Captures an image representation of browser contents. /// - /// The WebBrowser instance rendring the SVG. + /// The WebBrowser instance rendering the SVG. /// The client rectangle to capture from. /// The default background color to apply. /// A Bitmap representing the browser contents. From 724ca6f06eb503640d67cb5e42928bda9badf38c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:07 -0400 Subject: [PATCH 25/37] spelling: representation Signed-off-by: Josh Soref --- .../ColorPickerUI/Helpers/ColorRepresentationHelper.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs b/src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs index 9472322986..230d8913c2 100644 --- a/src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs +++ b/src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs @@ -10,7 +10,7 @@ using Microsoft.PowerToys.Settings.UI.Library; namespace ColorPicker.Helpers { /// - /// Helper class to easier work with color represantation + /// Helper class to easier work with color representation /// internal static class ColorRepresentationHelper { From fd8b99bd8c695a74d3c28092dca3c16f2e0ef04d Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:11 -0400 Subject: [PATCH 26/37] spelling: retrieving Signed-off-by: Josh Soref --- src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs index 0d9aac4552..52bf264440 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs @@ -146,7 +146,7 @@ namespace Microsoft.Plugin.Uri catch (Exception e) { BrowserIconPath = DefaultIconPath; - Log.Exception("Exception when retreiving icon", e, GetType()); + Log.Exception("Exception when retrieving icon", e, GetType()); } } From d116298d2ff52ac168856328da6e6a7073077df6 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:16 -0400 Subject: [PATCH 27/37] spelling: shortcut Signed-off-by: Josh Soref --- .../keyboardmanager/test/OSLevelShortcutRemappingTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/keyboardmanager/test/OSLevelShortcutRemappingTests.cpp b/src/modules/keyboardmanager/test/OSLevelShortcutRemappingTests.cpp index fa3aad3a1a..5705bbfa5c 100644 --- a/src/modules/keyboardmanager/test/OSLevelShortcutRemappingTests.cpp +++ b/src/modules/keyboardmanager/test/OSLevelShortcutRemappingTests.cpp @@ -2237,7 +2237,7 @@ namespace RemappingLogicTests } // Test that shortcut is not disabled if the shortcut which was remapped to Disable is pressed followed by another key - TEST_METHOD (ShortcutDisable_ShouldNotDisableShortcutSuperset_AfterShorcutWasDisabled) + TEST_METHOD (ShortcutDisable_ShouldNotDisableShortcutSuperset_AfterShortcutWasDisabled) { Shortcut src; src.SetKey(VK_CONTROL); From 8720a0dcdf6129635abce80cbdf3e946123a99a3 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:20 -0400 Subject: [PATCH 28/37] spelling: source Signed-off-by: Josh Soref --- .../fancyzones/editor/FancyZonesEditor/GridData.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/GridData.cs b/src/modules/fancyzones/editor/FancyZonesEditor/GridData.cs index 6b2dcd4b39..9e61428498 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/GridData.cs +++ b/src/modules/fancyzones/editor/FancyZonesEditor/GridData.cs @@ -370,24 +370,24 @@ namespace FancyZonesEditor if (delta > 0) { - int sourcRow = 0; + int sourceRow = 0; for (int row = 0; row < rows; row++) { for (int col = 0; col < cols; col++) { if (row == draggedResizerStartRow + 1 && (col < resizer.StartCol || col >= resizer.EndCol)) { - newCellChildMap[row, col] = cellChildMap[sourcRow + 1, col]; + newCellChildMap[row, col] = cellChildMap[sourceRow + 1, col]; } else { - newCellChildMap[row, col] = cellChildMap[sourcRow, col]; + newCellChildMap[row, col] = cellChildMap[sourceRow, col]; } } if (row != draggedResizerStartRow) { - sourcRow++; + sourceRow++; } } From 2b235e0827e117bf67ca2ad4135431878f3f5e71 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:24 -0400 Subject: [PATCH 29/37] spelling: specific Signed-off-by: Josh Soref --- src/modules/keyboardmanager/common/KeyboardManagerState.cpp | 4 ++-- src/modules/keyboardmanager/common/KeyboardManagerState.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/modules/keyboardmanager/common/KeyboardManagerState.cpp b/src/modules/keyboardmanager/common/KeyboardManagerState.cpp index 7a91c84d45..c2061b5ac8 100644 --- a/src/modules/keyboardmanager/common/KeyboardManagerState.cpp +++ b/src/modules/keyboardmanager/common/KeyboardManagerState.cpp @@ -618,13 +618,13 @@ std::wstring KeyboardManagerState::GetCurrentConfigName() return currentConfig; } -// Sets the activated target application in app-specfic shortcut +// Sets the activated target application in app-specific shortcut void KeyboardManagerState::SetActivatedApp(const std::wstring& appName) { activatedAppSpecificShortcutTarget = appName; } -// Gets the activated target application in app-specfic shortcut +// Gets the activated target application in app-specific shortcut std::wstring KeyboardManagerState::GetActivatedApp() { return activatedAppSpecificShortcutTarget; diff --git a/src/modules/keyboardmanager/common/KeyboardManagerState.h b/src/modules/keyboardmanager/common/KeyboardManagerState.h index 85a0467249..70969de2d5 100644 --- a/src/modules/keyboardmanager/common/KeyboardManagerState.h +++ b/src/modules/keyboardmanager/common/KeyboardManagerState.h @@ -85,7 +85,7 @@ private: std::map> keyDelays; std::mutex keyDelays_mutex; - // Stores the activated target application in app-specfic shortcut + // Stores the activated target application in app-specific shortcut std::wstring activatedAppSpecificShortcutTarget; // Thread safe boolean value to check if remappings are currently enabled. This is used to disable remappings while the remap tables are being updated by the UI thread @@ -225,10 +225,10 @@ public: // Gets the Current Active Configuration Name. std::wstring GetCurrentConfigName(); - // Sets the activated target application in app-specfic shortcut + // Sets the activated target application in app-specific shortcut void SetActivatedApp(const std::wstring& appName); - // Gets the activated target application in app-specfic shortcut + // Gets the activated target application in app-specific shortcut std::wstring GetActivatedApp(); bool AreRemappingsEnabled(); From 3e20672efe517c10395b02b19f4d8cdc83b9347b Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:40:57 -0400 Subject: [PATCH 30/37] spelling: specification Signed-off-by: Josh Soref --- src/codeAnalysis/GlobalSuppressions.cs | 4 ++-- src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/codeAnalysis/GlobalSuppressions.cs b/src/codeAnalysis/GlobalSuppressions.cs index 84431d6686..cd784a785e 100644 --- a/src/codeAnalysis/GlobalSuppressions.cs +++ b/src/codeAnalysis/GlobalSuppressions.cs @@ -28,8 +28,8 @@ using System.Diagnostics.CodeAnalysis; // Non general supressions [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "The WebBrowser is loading source code to be shown to the user. No localization required.", MessageId = "System.Windows.Controls.WebBrowser.NavigateToString(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.CodeViewer.#UpdateCodeView(System.Func`2,System.String,System.String,System.Boolean)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "This is part of the markdown processing", MessageId = "System.Windows.Documents.Run.#ctor(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.Markdown.#ImageInlineEvaluator(System.Text.RegularExpressions.Match)")] -[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer especification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.ITemplateInfoExtensions.#GetQueryableProperties(Microsoft.TemplateEngine.Abstractions.ITemplateInfo)")] -[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer especification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.Composition.CompositionQuery.#Match(System.Collections.Generic.IEnumerable`1,Microsoft.Templates.Core.Composition.QueryablePropertyDictionary)")] +[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.ITemplateInfoExtensions.#GetQueryableProperties(Microsoft.TemplateEngine.Abstractions.ITemplateInfo)")] +[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.Composition.CompositionQuery.#Match(System.Collections.Generic.IEnumerable`1,Microsoft.Templates.Core.Composition.QueryablePropertyDictionary)")] [assembly: SuppressMessage("Usage", "VSTHRD103:Call async methods when in an async method", Justification = "Resource DictionaryWriter does not implement flush async", Scope = "member", Target = "~M:Microsoft.Templates.Core.PostActions.Catalog.Merge.MergeResourceDictionaryPostAction.ExecuteInternalAsync~System.Threading.Tasks.Task")] // Threading supressions diff --git a/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs b/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs index 94ba50d7d7..fb1de2ba4c 100644 --- a/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs +++ b/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs @@ -28,8 +28,8 @@ using System.Diagnostics.CodeAnalysis; // Non general supressions [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "The WebBrowser is loading source code to be shown to the user. No localization required.", MessageId = "System.Windows.Controls.WebBrowser.NavigateToString(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.CodeViewer.#UpdateCodeView(System.Func`2,System.String,System.String,System.Boolean)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "This is part of the markdown processing", MessageId = "System.Windows.Documents.Run.#ctor(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.Markdown.#ImageInlineEvaluator(System.Text.RegularExpressions.Match)")] -[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer especification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.ITemplateInfoExtensions.#GetQueryableProperties(Microsoft.TemplateEngine.Abstractions.ITemplateInfo)")] -[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer especification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.Composition.CompositionQuery.#Match(System.Collections.Generic.IEnumerable`1,Microsoft.Templates.Core.Composition.QueryablePropertyDictionary)")] +[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.ITemplateInfoExtensions.#GetQueryableProperties(Microsoft.TemplateEngine.Abstractions.ITemplateInfo)")] +[assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.Composition.CompositionQuery.#Match(System.Collections.Generic.IEnumerable`1,Microsoft.Templates.Core.Composition.QueryablePropertyDictionary)")] [assembly: SuppressMessage("Usage", "VSTHRD103:Call async methods when in an async method", Justification = "Resource DictionaryWriter does not implement flush async", Scope = "member", Target = "~M:Microsoft.Templates.Core.PostActions.Catalog.Merge.MergeResourceDictionaryPostAction.ExecuteInternalAsync~System.Threading.Tasks.Task")] // Threading supressions From 7442162cc0691cccf9220bd343d525ff2553fd22 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:28 -0400 Subject: [PATCH 31/37] spelling: suppressions Signed-off-by: Josh Soref --- src/codeAnalysis/GlobalSuppressions.cs | 4 ++-- src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/codeAnalysis/GlobalSuppressions.cs b/src/codeAnalysis/GlobalSuppressions.cs index cd784a785e..8ef1d2b41b 100644 --- a/src/codeAnalysis/GlobalSuppressions.cs +++ b/src/codeAnalysis/GlobalSuppressions.cs @@ -25,14 +25,14 @@ using System.Diagnostics.CodeAnalysis; [assembly: SuppressMessage("Microsoft.Design", "CA1009:DeclareEventHandlersCorrectly", Scope = "member", Target = "Microsoft.Templates.Core.Locations.TemplatesSynchronization.#SyncStatusChanged", Justification = "Using an Action does not allow the required notation")] -// Non general supressions +// Non general suppressions [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "The WebBrowser is loading source code to be shown to the user. No localization required.", MessageId = "System.Windows.Controls.WebBrowser.NavigateToString(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.CodeViewer.#UpdateCodeView(System.Func`2,System.String,System.String,System.Boolean)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "This is part of the markdown processing", MessageId = "System.Windows.Documents.Run.#ctor(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.Markdown.#ImageInlineEvaluator(System.Text.RegularExpressions.Match)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.ITemplateInfoExtensions.#GetQueryableProperties(Microsoft.TemplateEngine.Abstractions.ITemplateInfo)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.Composition.CompositionQuery.#Match(System.Collections.Generic.IEnumerable`1,Microsoft.Templates.Core.Composition.QueryablePropertyDictionary)")] [assembly: SuppressMessage("Usage", "VSTHRD103:Call async methods when in an async method", Justification = "Resource DictionaryWriter does not implement flush async", Scope = "member", Target = "~M:Microsoft.Templates.Core.PostActions.Catalog.Merge.MergeResourceDictionaryPostAction.ExecuteInternalAsync~System.Threading.Tasks.Task")] -// Threading supressions +// Threading suppressions [assembly: SuppressMessage("Microsoft.VisualStudio.Threading.Analyzers", "VSTHRD100:Avoid async void methods", Justification = "Event handlers needs async void", Scope = "member", Target = "~M:Microsoft.Templates.UI.Controls.Notification.OnClose")] [assembly: SuppressMessage("Microsoft.VisualStudio.Threading.Analyzers", "VSTHRD100:Avoid async void methods", Justification = "Event handlers needs async void", Scope = "member", Target = "~M:Microsoft.Templates.UI.ViewModels.Common.SavedTemplateViewModel.OnDelete")] [assembly: SuppressMessage("Microsoft.VisualStudio.Threading.Analyzers", "VSTHRD100:Avoid async void methods", Justification = "Event handlers needs async void", Scope = "member", Target = "~M:Microsoft.Templates.UI.ViewModels.Common.WizardNavigation.GoBack")] diff --git a/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs b/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs index fb1de2ba4c..24fb04bae4 100644 --- a/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs +++ b/src/modules/imageresizer/codeAnalysis/GlobalSuppressions.cs @@ -25,14 +25,14 @@ using System.Diagnostics.CodeAnalysis; [assembly: SuppressMessage("Microsoft.Design", "CA1009:DeclareEventHandlersCorrectly", Scope = "member", Target = "Microsoft.Templates.Core.Locations.TemplatesSynchronization.#SyncStatusChanged", Justification = "Using an Action does not allow the required notation")] -// Non general supressions +// Non general suppressions [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "The WebBrowser is loading source code to be shown to the user. No localization required.", MessageId = "System.Windows.Controls.WebBrowser.NavigateToString(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.CodeViewer.#UpdateCodeView(System.Func`2,System.String,System.String,System.Boolean)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "This is part of the markdown processing", MessageId = "System.Windows.Documents.Run.#ctor(System.String)", Scope = "member", Target = "Microsoft.Templates.UI.Controls.Markdown.#ImageInlineEvaluator(System.Text.RegularExpressions.Match)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.ITemplateInfoExtensions.#GetQueryableProperties(Microsoft.TemplateEngine.Abstractions.ITemplateInfo)")] [assembly: SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "We need to have the names of these keys in lowercase to be able to compare with the keys becoming form the template json. ContainsKey does not allow StringComparer specification to IgnoreCase", Scope = "member", Target = "Microsoft.Templates.Core.Composition.CompositionQuery.#Match(System.Collections.Generic.IEnumerable`1,Microsoft.Templates.Core.Composition.QueryablePropertyDictionary)")] [assembly: SuppressMessage("Usage", "VSTHRD103:Call async methods when in an async method", Justification = "Resource DictionaryWriter does not implement flush async", Scope = "member", Target = "~M:Microsoft.Templates.Core.PostActions.Catalog.Merge.MergeResourceDictionaryPostAction.ExecuteInternalAsync~System.Threading.Tasks.Task")] -// Threading supressions +// Threading suppressions [assembly: SuppressMessage("Microsoft.VisualStudio.Threading.Analyzers", "VSTHRD100:Avoid async void methods", Justification = "Event handlers needs async void", Scope = "member", Target = "~M:Microsoft.Templates.UI.Controls.Notification.OnClose")] [assembly: SuppressMessage("Microsoft.VisualStudio.Threading.Analyzers", "VSTHRD100:Avoid async void methods", Justification = "Event handlers needs async void", Scope = "member", Target = "~M:Microsoft.Templates.UI.ViewModels.Common.SavedTemplateViewModel.OnDelete")] [assembly: SuppressMessage("Microsoft.VisualStudio.Threading.Analyzers", "VSTHRD100:Avoid async void methods", Justification = "Event handlers needs async void", Scope = "member", Target = "~M:Microsoft.Templates.UI.ViewModels.Common.WizardNavigation.GoBack")] From ad9f88c487731967d822b63f10846457cccfe62f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:32 -0400 Subject: [PATCH 32/37] spelling: synchronized Signed-off-by: Josh Soref --- .../Storage/ListRepositoryTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/ListRepositoryTests.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/ListRepositoryTests.cs index fbd9f7b7d8..cbaaae7e7f 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/ListRepositoryTests.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/ListRepositoryTests.cs @@ -90,7 +90,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage } }); - // Assert that this does not throw. Collections that aren't syncronized will throw an invalidoperatioexception if the list is modified while enumerating + // Assert that this does not throw. Collections that aren't synchronized will throw an invalidoperatioexception if the list is modified while enumerating await Task.WhenAll(new Task[] { iterationTask, addTask }).ConfigureAwait(false); } @@ -129,7 +129,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage } }); - // Assert that this does not throw. Collections that aren't syncronized will throw an invalidoperatioexception if the list is modified while enumerating + // Assert that this does not throw. Collections that aren't synchronized will throw an invalidoperatioexception if the list is modified while enumerating await Task.WhenAll(new Task[] { iterationTask, addTask }).ConfigureAwait(false); } } From 23975d225d03a0c76d76397353e21b7be8988bc8 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:36 -0400 Subject: [PATCH 33/37] spelling: unofficial Signed-off-by: Josh Soref --- README.md | 2 +- doc/{unofficalInstallMethods.md => unofficialInstallMethods.md} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename doc/{unofficalInstallMethods.md => unofficialInstallMethods.md} (100%) diff --git a/README.md b/README.md index 976b51acf3..322e5ffc7f 100644 --- a/README.md +++ b/README.md @@ -113,7 +113,7 @@ Install the [pre-release experimental version of PowerToys][github-prerelease-li ### Other install methods -There are [community driven install methods](./doc/unofficalInstallMethods.md) such as Chocolatey and Scoop. If these are your preferred install solutions, this will have the install instructions. +There are [community driven install methods](./doc/unofficialInstallMethods.md) such as Chocolatey and Scoop. If these are your preferred install solutions, this will have the install instructions. ### Known issues diff --git a/doc/unofficalInstallMethods.md b/doc/unofficialInstallMethods.md similarity index 100% rename from doc/unofficalInstallMethods.md rename to doc/unofficialInstallMethods.md From 7e942a366cf398e2e59a590159478dfa33998089 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:41 -0400 Subject: [PATCH 34/37] spelling: update Signed-off-by: Josh Soref --- .../ViewModelTests/ImageResizer.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs index 5ebf32f6e0..dc4f66d586 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs @@ -236,7 +236,7 @@ namespace ViewModelTests } [TestMethod] - public void UpdateWidthAndHeightShouldUpateSizeWhenCorrectValuesAreProvided() + public void UpdateWidthAndHeightShouldUpdateSizeWhenCorrectValuesAreProvided() { // arrange ImageSize imageSize = new ImageSize() From 0a0b41393e6820391742eedc25cb673abb109e6a Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:45 -0400 Subject: [PATCH 35/37] spelling: utility Signed-off-by: Josh Soref --- .github/ISSUE_TEMPLATE/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 35ab18554f..ec3898aa7e 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -2,7 +2,7 @@ blank_issues_enabled: false contact_links: - name: "\U0001F4F7 Video Conference Mute Issue" url: https://github.com/microsoft/PowerToys/issues/6246 - about: Report Bug for the Video Conference Mute utiltity + about: Report Bug for the Video Conference Mute utility - name: "\U0001F6A8 Microsoft Security Response Center (MSRC)" url: https://msrc.microsoft.com/create-report about: Report security bugs From 98c9199f0e2055d851106690694aeb503422dd16 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:49 -0400 Subject: [PATCH 36/37] spelling: verify Signed-off-by: Josh Soref --- .../ViewModelTests/ColorPicker.cs | 2 +- .../ViewModelTests/FancyZones.cs | 2 +- .../ViewModelTests/General.cs | 2 +- .../ViewModelTests/ImageResizer.cs | 2 +- .../ViewModelTests/PowerLauncherViewModelTest.cs | 2 +- .../ViewModelTests/PowerPreview.cs | 2 +- .../ViewModelTests/PowerRename.cs | 2 +- .../ViewModelTests/ShortcutGuide.cs | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ColorPicker.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ColorPicker.cs index cc649c441e..1ddc93c17f 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ColorPicker.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ColorPicker.cs @@ -40,7 +40,7 @@ namespace ViewModelTests ColorPickerViewModel viewModel = new ColorPickerViewModel(mockSettingsUtils, generalSettingsRepository, ColorPickerIsEnabledByDefaultIPC); //Assert - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.Enabled.ColorPicker, viewModel.IsEnabled); Assert.AreEqual(originalSettings.Properties.ActivationShortcut.ToString(), viewModel.ActivationShortcut.ToString()); Assert.AreEqual(originalSettings.Properties.ChangeCursor, viewModel.ChangeCursor); diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/FancyZones.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/FancyZones.cs index 8f87d1fe0b..ead763064c 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/FancyZones.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/FancyZones.cs @@ -46,7 +46,7 @@ namespace ViewModelTests // Initialise View Model with test Config files FancyZonesViewModel viewModel = new FancyZonesViewModel(generalSettingsRepository, fancyZonesRepository, ColorPickerIsEnabledByDefault_IPC); - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.Enabled.FancyZones, viewModel.IsEnabled); Assert.AreEqual(originalSettings.Properties.FancyzonesAppLastZoneMoveWindows.Value, viewModel.AppLastZoneMoveWindows); Assert.AreEqual(originalSettings.Properties.FancyzonesBorderColor.Value, viewModel.ZoneBorderColor); diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/General.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/General.cs index bf543c8fcd..167037fc38 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/General.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/General.cs @@ -62,7 +62,7 @@ namespace ViewModelTests ipcMSGCheckForUpdatesCallBackFunc: SendCheckForUpdatesIPCMessage, configFileSubfolder: string.Empty); - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.AutoDownloadUpdates, viewModel.AutoDownloadUpdates); Assert.AreEqual(originalGeneralSettings.Packaged, viewModel.Packaged); Assert.AreEqual(originalGeneralSettings.PowertoysVersion, viewModel.PowerToysVersion); diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs index dc4f66d586..2ea3590483 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs @@ -57,7 +57,7 @@ namespace ViewModelTests Func SendMockIPCConfigMSG = msg => { return 0; }; ImageResizerViewModel viewModel = new ImageResizerViewModel(mockSettingsUtils, generalSettingsRepository, SendMockIPCConfigMSG); - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.Enabled.ImageResizer, viewModel.IsEnabled); Assert.AreEqual(ImageResizerViewModel.GetEncoderIndex(originalSettings.Properties.ImageresizerFallbackEncoder.Value), viewModel.Encoder); Assert.AreEqual(originalSettings.Properties.ImageresizerFileName.Value, viewModel.FileName); diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerLauncherViewModelTest.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerLauncherViewModelTest.cs index bd180e830c..9024e55650 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerLauncherViewModelTest.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerLauncherViewModelTest.cs @@ -65,7 +65,7 @@ namespace ViewModelTests Func SendMockIPCConfigMSG = msg => { return 0; }; PowerLauncherViewModel viewModel = new PowerLauncherViewModel(mockSettingsUtils, generalSettingsRepository, SendMockIPCConfigMSG, 32); - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.Enabled.PowerLauncher, viewModel.EnablePowerLauncher); Assert.AreEqual(originalSettings.Properties.ClearInputOnLaunch, viewModel.ClearInputOnLaunch); Assert.AreEqual(originalSettings.Properties.CopyPathLocation.ToString(), viewModel.CopyPathLocation.ToString()); diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerPreview.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerPreview.cs index d66a6839e0..a4b48e63db 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerPreview.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerPreview.cs @@ -54,7 +54,7 @@ namespace ViewModelTests Func SendMockIPCConfigMSG = msg => { return 0; }; PowerPreviewViewModel viewModel = new PowerPreviewViewModel(repository, generalSettingsRepository, SendMockIPCConfigMSG); - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.IsElevated, viewModel.IsElevated); Assert.AreEqual(originalSettings.Properties.EnableMdPreview, viewModel.MDRenderIsEnabled); Assert.AreEqual(originalSettings.Properties.EnableSvgPreview, viewModel.SVGRenderIsEnabled); diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerRename.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerRename.cs index 794dd1b972..937a163aa4 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerRename.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/PowerRename.cs @@ -53,7 +53,7 @@ namespace ViewModelTests Func SendMockIPCConfigMSG = msg => { return 0; }; PowerRenameViewModel viewModel = new PowerRenameViewModel(mockSettingsUtils, generalSettingsRepository, SendMockIPCConfigMSG); - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.Enabled.PowerRename, viewModel.IsEnabled); Assert.AreEqual(originalSettings.ExtendedContextMenuOnly, viewModel.EnabledOnContextExtendedMenu); Assert.AreEqual(originalSettings.MRUEnabled, viewModel.MRUEnabled); diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ShortcutGuide.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ShortcutGuide.cs index 0e4fb665dd..a6a41fc9d7 100644 --- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ShortcutGuide.cs +++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/ShortcutGuide.cs @@ -44,7 +44,7 @@ namespace ViewModelTests Func SendMockIPCConfigMSG = msg => { return 0; }; ShortcutGuideViewModel viewModel = new ShortcutGuideViewModel(generalSettingsRepository, shortcutSettingsRepository, SendMockIPCConfigMSG); - // Verifiy that the old settings persisted + // Verify that the old settings persisted Assert.AreEqual(originalGeneralSettings.Enabled.ShortcutGuide, viewModel.IsEnabled); Assert.AreEqual(originalSettings.Properties.OverlayOpacity.Value, viewModel.OverlayOpacity); Assert.AreEqual(originalSettings.Properties.PressTime.Value, viewModel.PressTime); From 450ccf6359333b99b81b9cc190d3a43c3620c85b Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Fri, 30 Oct 2020 14:42:53 -0400 Subject: [PATCH 37/37] spelling: viewmodel Signed-off-by: Josh Soref --- doc/devdocs/settingsv2/viewmodels.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/devdocs/settingsv2/viewmodels.md b/doc/devdocs/settingsv2/viewmodels.md index 18efd6344f..226ac3ea2b 100644 --- a/doc/devdocs/settingsv2/viewmodels.md +++ b/doc/devdocs/settingsv2/viewmodels.md @@ -18,7 +18,7 @@ The viewmodels are located within the [`Microsoft.PowerToys.Settings.UI.Library` ### Settings viewmodel anomalies - The reason behind using the `SettingsRepository` is to ensure that the settings process does not try to access the `settings.json` files directly but rather does it through this class which encapsulates all the file operations from the viewmodels. - However, this could not be expanded to all the viewmodels directly for the following reasons. Some refactoring must be done to unify these cases and to bring them under the same model: - - The PowerRename viewodel does not save the settings configurations in the same format as the rest of the powertoys, ie. {name, version, properties}. However, it only stores the properties directly. + - The PowerRename viewmodel does not save the settings configurations in the same format as the rest of the powertoys, ie. {name, version, properties}. However, it only stores the properties directly. - Some viewmodels expect the runner to create the file instead of creating the file themselves, like in keyboard manager. - The colorpicker powertoy creates the `settings.json` within the module. This must be taken care of when encapsulated within the settingsRepository. - Currently, all modules use the `SettingsRepository` to access the General Settings config.