From 734c73875164d0480c12373b95be6642eb1e20e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Pol=C3=A1=C5=A1ek?= Date: Mon, 2 Mar 2026 23:47:02 +0100 Subject: [PATCH] CmdPal: Move ListViewModel.TextToSuggest property update back to UI thread (#45878) ## Summary of the Pull Request This PR marshals the setting of the property ListViewModel.TextToSuggest in SetSelectedItem to the UI thread, so that the change notification is raised on that thread as well. Regressed in #45764 ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- .../Microsoft.CmdPal.UI.ViewModels/ListViewModel.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ListViewModel.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ListViewModel.cs index 64db00c3e1..da133125a8 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ListViewModel.cs +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ListViewModel.cs @@ -567,8 +567,12 @@ public partial class ListViewModel : PageViewModel, IDisposable WeakReferenceMessenger.Default.Send(); } - TextToSuggest = item.TextToSuggest; - WeakReferenceMessenger.Default.Send(new(item.TextToSuggest)); + var suggestion = item.TextToSuggest; + DoOnUiThread(() => + { + TextToSuggest = suggestion; + WeakReferenceMessenger.Default.Send(new(suggestion)); + }); }, ct); }