[VCM]disable by default and admin warning (#14686)

* Adding in InfoBar warning when not running as admin

* small newline text shift

* rolling out a text fix i didn't mean to commit

* defaulting to off, there are other spots is seems like

* [Runner] introduce is_enabled_by_default method and keep VCM disabled by default

* getting file back in good state

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
This commit is contained in:
Clint Rutkas
2021-12-07 05:50:04 -08:00
committed by GitHub
parent aa376a2c0d
commit 71380d6fb1
9 changed files with 43 additions and 21 deletions

View File

@@ -47,7 +47,7 @@ public:
std::strong_ordering operator<=>(const Hotkey&) const = default;
};
struct HotkeyEx
{
WORD modifiersMask = 0;
@@ -98,7 +98,7 @@ public:
*/
virtual bool on_hotkey(size_t hotkeyId) { return false; }
/* These are for enabling the legacy behavior of showing the shortcut guide after pressing the win key.
/* These are for enabling the legacy behavior of showing the shortcut guide after pressing the win key.
* keep_track_of_pressed_win_key returns true if the module wants to keep track of the win key being pressed.
* milliseconds_win_key_must_be_pressed returns the number of milliseconds the win key should be pressed before triggering the module.
* Don't use these for new modules.
@@ -110,6 +110,8 @@ public:
{
}
virtual bool is_enabled_by_default() const { return true; }
protected:
HANDLE CreateDefaultEvent(const wchar_t* eventName)
{

View File

@@ -527,6 +527,11 @@ void VideoConferenceModule::destroy()
instance = nullptr;
}
bool VideoConferenceModule::is_enabled_by_default() const
{
return false;
}
void VideoConferenceModule::sendSourceCameraNameUpdate()
{
if (!_settingsUpdateChannel.has_value() || settings.selectedCamera.empty())

View File

@@ -45,6 +45,7 @@ public:
virtual void disable() override;
virtual bool is_enabled() override;
virtual void destroy() override;
virtual bool is_enabled_by_default() const override;
virtual const wchar_t * get_key() override;