From 6fe4361a2093282f19588b5b7e6ad5f5bf20cb8d Mon Sep 17 00:00:00 2001 From: Gordon Lam <73506701+yeelam-gordon@users.noreply.github.com> Date: Tue, 24 Feb 2026 18:12:32 +0800 Subject: [PATCH] feat(settings-ui): crash fix - add back the missing default language option to resources (#45766) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add back the default language option to the resources for better localization support. This change is fixing a regression: Two bugs here: 1. The original commit by Stefan had a case mismatch (Default_language vs Default_Language) — latent bug 2. Niels's PR used Copilot CLI to find dead strings, which incorrectly removed a live resource due to the case mismatch --------- Co-authored-by: Claude Opus 4.6 (1M context) --- src/settings-ui/Settings.UI/Strings/en-us/Resources.resw | 3 +++ src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw b/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw index 0b1de24d2b..bdce13b760 100644 --- a/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw +++ b/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw @@ -4772,6 +4772,9 @@ The break timer font matches the text font. Restart + + Windows default + Arabic (Saudi Arabia) diff --git a/src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs b/src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs index 3919eb0a78..5ffc96d6a8 100644 --- a/src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs +++ b/src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs @@ -226,7 +226,7 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels // Supported languages. Taken from Resources.wxs + default + en-US private Dictionary langTagsAndIds = new Dictionary { - { string.Empty, "Default_language" }, + { string.Empty, "Default_Language" }, { "ar-SA", "Arabic_Saudi_Arabia_Language" }, { "cs-CZ", "Czech_Language" }, { "de-DE", "German_Language" },