Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-04 18:26:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

[KBM][Telemetry]Remove garrulous events (#18261)

Browse Source
This commit is contained in:
Jaime Bernardo
2022-05-16 10:10:56 +01:00
committed by GitHub
parent 3548e6820e
commit 6e6f474df7
4 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/modules/keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.cpp
View File

@@ -98,9 +98,6 @@ namespace KeyboardEventHandlers
if (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN)
{
// Log telemetry event when the key remap is invoked
Trace::KeyRemapInvoked(remapToKey);
// If Caps Lock is being remapped to Ctrl/Alt/Shift, then reset the modifier key state to fix issues in certain IME keyboards where the IME shortcut gets invoked since it detects that the modifier and Caps Lock is pressed even though it is suppressed by the hook - More information at the GitHub issue https://github.com/microsoft/PowerToys/issues/3397
if (remapToKey)
{
@@ -319,9 +316,6 @@ namespace KeyboardEventHandlers
UINT res = ii.SendVirtualInput((UINT)key_count, keyEventList, sizeof(INPUT));
delete[] keyEventList;
// Log telemetry event when shortcut remap is invoked
Trace::ShortcutRemapInvoked(remapToShortcut, activatedApp.has_value());
return 1;
}
}

4
src/modules/keyboardmanager/KeyboardManagerEngineLibrary/trace.cpp
View File

@@ -18,7 +18,7 @@ void Trace::UnregisterProvider() noexcept
TraceLoggingUnregister(g_hProvider);
}
// Log if a key remap has been invoked
// Log if a key remap has been invoked (not being used currently, due to being garrulous)
void Trace::KeyRemapInvoked(bool isKeyToKey) noexcept
{
if (isKeyToKey)
@@ -39,7 +39,7 @@ void Trace::KeyRemapInvoked(bool isKeyToKey) noexcept
}
}
// Log if a shortcut remap has been invoked
// Log if a shortcut remap has been invoked (not being used currently, due to being garrulous)
void Trace::ShortcutRemapInvoked(bool isShortcutToShortcut, bool isAppSpecific) noexcept
{
if (isAppSpecific)

4
src/modules/keyboardmanager/KeyboardManagerEngineLibrary/trace.h
View File

@@ -6,10 +6,10 @@ public:
static void RegisterProvider() noexcept;
static void UnregisterProvider() noexcept;
// Log if a key remap has been invoked
// Log if a key remap has been invoked (not being used currently, due to being garrulous)
static void KeyRemapInvoked(bool isKeyToKey) noexcept;
// Log if a shortcut remap has been invoked
// Log if a shortcut remap has been invoked (not being used currently, due to being garrulous)
static void ShortcutRemapInvoked(bool isShortcutToShortcut, bool isAppSpecific) noexcept;
// Log if an error occurs in KBM