From 6c691f59e807ee603b2f4ccad8751b1c34410292 Mon Sep 17 00:00:00 2001 From: PesBandi <127593627+PesBandi@users.noreply.github.com> Date: Sun, 1 Mar 2026 13:45:51 +0100 Subject: [PATCH] [OOBE] Properly localize View on GitHub and release date in What's new (#45847) ## Summary of the Pull Request * Move hardcoded string *View on GitHub* to `Resources.resw` * Respect `DateTimeFormat.MonthDayPattern` in release date * Dots in the date are escaped so that they don't accidentally trigger a markdown list ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [x] **Dev docs:** No need - [x] **New binaries:** None - [x] **Documentation updated:** No need ## Detailed Description of the Pull Request / Additional comments Nothing changes in the English version, only difference is in languages that don't use `MMMM d`. ## Validation Steps Performed Manually tested with Slovak, Czech, German, English. --- .../SettingsXAML/OOBE/Views/ScoobeReleaseNotesPage.xaml.cs | 3 ++- src/settings-ui/Settings.UI/Strings/en-us/Resources.resw | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/ScoobeReleaseNotesPage.xaml.cs b/src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/ScoobeReleaseNotesPage.xaml.cs index 278612290a..a26d15759c 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/ScoobeReleaseNotesPage.xaml.cs +++ b/src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/ScoobeReleaseNotesPage.xaml.cs @@ -86,7 +86,8 @@ namespace Microsoft.PowerToys.Settings.UI.OOBE.Views var releaseUrl = string.Format(CultureInfo.InvariantCulture, GitHubReleaseLinkTemplate, release.TagName); releaseNotesHtmlBuilder.AppendLine(CultureInfo.InvariantCulture, $"# {release.Name}"); - releaseNotesHtmlBuilder.AppendLine(CultureInfo.InvariantCulture, $"{release.PublishedDate.ToString("MMMM d, yyyy", CultureInfo.CurrentCulture)} • [View on GitHub]({releaseUrl})"); + string formattedDate = release.PublishedDate.ToString($"{CultureInfo.CurrentCulture.DateTimeFormat.MonthDayPattern}, yyyy", CultureInfo.CurrentCulture); + releaseNotesHtmlBuilder.AppendLine(CultureInfo.InvariantCulture, $"{formattedDate.Replace(".", "\\.")} • [{ResourceLoaderInstance.ResourceLoader.GetString("ScoobeReleaseNotes_ViewOnGitHub")}]({releaseUrl})"); releaseNotesHtmlBuilder.AppendLine(); releaseNotesHtmlBuilder.AppendLine(" "); releaseNotesHtmlBuilder.AppendLine(); diff --git a/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw b/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw index cffb5372be..8c9bed2782 100644 --- a/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw +++ b/src/settings-ui/Settings.UI/Strings/en-us/Resources.resw @@ -2195,6 +2195,9 @@ From there, simply click on one of the supported files in the File Explorer and What's new in PowerToys + + View on GitHub + PowerToys Settings Title of the settings window when running as user