[Analyzers][CPP] Turn on warning 4458 (#22265)

* Turn on warning 4458

Fix the errors by changing variable names and
supressing the warning on winRT GDI headers

* explaining the warning disables
This commit is contained in:
sosssego
2022-11-29 14:10:48 +00:00
committed by GitHub
parent 21a9c82df4
commit 6a6c45189e
14 changed files with 75 additions and 52 deletions

View File

@@ -95,7 +95,7 @@ namespace
}
// Enumerate all the events in the result set.
void PrintResults(EVT_HANDLE hResults)
void PrintResults(EVT_HANDLE results)
{
DWORD status = ERROR_SUCCESS;
EVT_HANDLE hEvents[BATCH_SIZE];
@@ -104,7 +104,7 @@ namespace
while (true)
{
// Get a block of events from the result set.
if (!EvtNext(hResults, BATCH_SIZE, hEvents, INFINITE, 0, &dwReturned))
if (!EvtNext(results, BATCH_SIZE, hEvents, INFINITE, 0, &dwReturned))
{
if (ERROR_NO_MORE_ITEMS != (status = GetLastError()))
{

View File

@@ -162,8 +162,8 @@ private:
{
auto path = tmpDir;
path += "installationFolderStructure.txt";
std::wofstream os = std::wofstream(path);
return os;
std::wofstream out_s = std::wofstream(path);
return out_s;
}
public:
Reporter(const path& tmpDir)